Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update toast component styling #565

Merged
merged 1 commit into from
Sep 8, 2020
Merged

feat: update toast component styling #565

merged 1 commit into from
Sep 8, 2020

Conversation

ciduarte
Copy link

@ciduarte ciduarte commented Sep 2, 2020

No description provided.

@ciduarte ciduarte force-pushed the ciduarte/toast branch 2 times, most recently from 00504fc to e0d8ca3 Compare September 2, 2020 13:55
@ciduarte ciduarte force-pushed the ciduarte/toast branch 6 times, most recently from 3bb3f25 to f179560 Compare September 3, 2020 13:23
abutterworth
abutterworth reviewed Sep 3, 2020
View reviewed changes
src/Toast/index.jsx Outdated Show resolved Hide resolved
abutterworth
abutterworth reviewed Sep 3, 2020
View reviewed changes
src/Toast/index.jsx Outdated Show resolved Hide resolved
abutterworth
abutterworth suggested changes Sep 3, 2020
View reviewed changes
Copy link
Contributor

@abutterworth abutterworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nitpicks, but overall looks great.

@abutterworth
Copy link
Contributor

Also note some lint errors:

/home/travis/build/edx/paragon/src/Toast/index.jsx
  4:1   error  More than 1 blank line not allowed               no-multiple-empty-lines
  8:36  error  Useless path segments for "../", should be ".."  import/no-useless-path-segments

@ciduarte ciduarte force-pushed the ciduarte/toast branch 2 times, most recently from 6db4cbd to 9bfe1ac Compare September 4, 2020 20:43
@abutterworth abutterworth self-requested a review September 4, 2020 20:50
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 88.37% when pulling d1274ae on ciduarte/toast into 8ebfb8b on master.

@ciduarte ciduarte merged commit 6de2b62 into master Sep 8, 2020
@ciduarte ciduarte deleted the ciduarte/toast branch September 8, 2020 14:52
@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 11.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abutterworth abutterworth abutterworth approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ciduarte @abutterworth @coveralls @edx-semantic-release