-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BD-46] docs: updated docs site navigation #1803
[BD-46] docs: updated docs site navigation #1803
Conversation
Thanks for the pull request, @PKulkoRaccoonGang! When this pull request is ready, tag your edX technical lead. |
✅ Deploy Preview for paragon-openedx ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #1803 +/- ##
==========================================
+ Coverage 90.73% 91.07% +0.33%
==========================================
Files 233 234 +1
Lines 4082 4122 +40
Branches 966 981 +15
==========================================
+ Hits 3704 3754 +50
+ Misses 371 361 -10
Partials 7 7 see 31 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
c5fd7ca
to
54979ed
Compare
c8480b4
to
732c88c
Compare
22676b5
to
a246573
Compare
a246573
to
dfa5c1d
Compare
@PKulkoRaccoonGang @viktorrusakov This is looking great. I shared the deploy preview around to a couple engineers internally to get their feedback as well. One high-level feedback item is that the re-design loses the search bar on the home page since its now only in the sidebar navigation on child pages. In talking to Kayva (designer), we would like to add the search bar back to the header persistent across the site, but also keep the search bar in the sidebar nav on the child pages. |
7dd3c25
to
1dbd234
Compare
@PKulkoRaccoonGang I see you've also added Container Width option to settings |
@PKulkoRaccoonGang also, when I open the menu popup locally, I get couple of prop types warnings, could you please take a look at them |
@PKulkoRaccoonGang 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
🎉 This PR is included in version 20.32.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 21.0.0-alpha.23 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Implement left and right sidebars from the design above.
Figma design
Deploy Preview
Paragon site documentation
Merge Checklist
example
app?wittjeff
andadamstankiewicz
as reviewers on this PR.Post-merge Checklist