Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BD-46] docs: add Segment event for when the 'Show code' block is opened/closed #2002

Conversation

PKulkoRaccoonGang
Copy link
Contributor

@PKulkoRaccoonGang PKulkoRaccoonGang commented Feb 7, 2023

Description

Issue #1937

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@openedx-webhooks openedx-webhooks added the blended PR is managed through 2U's blended developmnt program label Feb 7, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @PKulkoRaccoonGang!

When this pull request is ready, tag your edX technical lead.

@netlify
Copy link

netlify bot commented Feb 7, 2023

Deploy Preview for paragon-openedx ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 67623d6
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/6448d1eaa24cf200086c6dbb
😎 Deploy Preview https://deploy-preview-2002--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/add-Segment-event-for-when-the-Show-code-block-is-opened-closed branch 2 times, most recently from 5be94ea to 623931c Compare February 8, 2023 00:10
@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (9ceae87) 91.04% compared to head (4dfd167) 91.04%.

❗ Current head 4dfd167 differs from pull request most recent head 67623d6. Consider uploading reports for the commit 67623d6 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2002   +/-   ##
=======================================
  Coverage   91.04%   91.04%           
=======================================
  Files         234      234           
  Lines        4122     4122           
  Branches      981      981           
=======================================
  Hits         3753     3753           
  Misses        362      362           
  Partials        7        7           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@PKulkoRaccoonGang PKulkoRaccoonGang changed the title [BD-46] DRAFT: add Segment event for when the 'Show code' block is opened/closed [BD-46] docs: add Segment event for when the 'Show code' block is opened/closed Feb 8, 2023
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/add-Segment-event-for-when-the-Show-code-block-is-opened-closed branch from 19ff4d5 to 260c539 Compare February 8, 2023 01:55
www/src/components/CodeBlock.tsx Outdated Show resolved Hide resolved
www/src/components/CodeBlock.tsx Outdated Show resolved Hide resolved
www/src/components/CodeBlock.tsx Outdated Show resolved Hide resolved
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/add-Segment-event-for-when-the-Show-code-block-is-opened-closed branch from 9e5285f to 973d296 Compare February 8, 2023 11:40
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/add-Segment-event-for-when-the-Show-code-block-is-opened-closed branch 3 times, most recently from 8a6b470 to a5f655e Compare February 9, 2023 22:15
@adamstankiewicz adamstankiewicz linked an issue Apr 21, 2023 that may be closed by this pull request
2 tasks
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/add-Segment-event-for-when-the-Show-code-block-is-opened-closed branch from a5f655e to 13bea8d Compare April 23, 2023 14:49
@viktorrusakov viktorrusakov merged commit 4945983 into openedx:master Apr 26, 2023
9 checks passed
@openedx-webhooks
Copy link

@PKulkoRaccoonGang 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 20.32.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 21.0.0-alpha.23 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blended PR is managed through 2U's blended developmnt program released on @alpha released
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add Segment event for when the "Show code" block is opened/closed
4 participants