Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BD-46] feat: added Bootstrap icons #2324

Merged

Conversation

PKulkoRaccoonGang
Copy link
Contributor

@PKulkoRaccoonGang PKulkoRaccoonGang commented May 22, 2023

Description

Issue: #2310

Deploy Preview

Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@openedx-webhooks openedx-webhooks added the blended PR is managed through 2U's blended developmnt program label May 22, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented May 22, 2023

Thanks for the pull request, @PKulkoRaccoonGang!

When this pull request is ready, tag your edX technical lead.

@netlify
Copy link

netlify bot commented May 22, 2023

Deploy Preview for paragon-openedx ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 559f4c5
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/6479b38d83848900087557c2
😎 Deploy Preview https://deploy-preview-2324--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@PKulkoRaccoonGang PKulkoRaccoonGang marked this pull request as draft May 22, 2023 15:26
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/added-bootstrap-icons branch 2 times, most recently from cd280e9 to 042386c Compare May 23, 2023 07:09
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0a2fbb3) 91.38% compared to head (559f4c5) 91.38%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2324   +/-   ##
=======================================
  Coverage   91.38%   91.38%           
=======================================
  Files         234      234           
  Lines        4120     4120           
  Branches      982      982           
=======================================
  Hits         3765     3765           
  Misses        348      348           
  Partials        7        7           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/added-bootstrap-icons branch from 042386c to c4da25c Compare May 23, 2023 07:15
@PKulkoRaccoonGang PKulkoRaccoonGang marked this pull request as ready for review May 23, 2023 07:20
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/added-bootstrap-icons branch from 7aa8377 to c470213 Compare May 24, 2023 13:53
Copy link
Member

@kalebjdavenport kalebjdavenport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! I haven't run it locally but if you need a review let me know and I can do that to confirm it all looks as expected.

@viktorrusakov viktorrusakov linked an issue May 26, 2023 that may be closed by this pull request
@viktorrusakov
Copy link
Contributor

@TheEarlyNerd Sorry for the delayed response. Another review definitely would not hurt, so feel free to take a look 🙂

@viktorrusakov viktorrusakov force-pushed the Peter_Kulko/added-bootstrap-icons branch from ec5f36e to 65016ed Compare June 2, 2023 08:57
@viktorrusakov viktorrusakov force-pushed the Peter_Kulko/added-bootstrap-icons branch from 65016ed to 559f4c5 Compare June 2, 2023 09:16
@viktorrusakov viktorrusakov merged commit ea83de0 into openedx:master Jun 2, 2023
11 checks passed
@openedx-webhooks
Copy link

@PKulkoRaccoonGang 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 20.41.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blended PR is managed through 2U's blended developmnt program released
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Bootstrap Brand Icons
5 participants