test!: Don't validate salesforce orgs against orgs.yml #15
Conversation
BREAKING CHANGE: We no longer test that the "Account Name" for the CSV has a valid entry in the orgs.yaml file in the same directory. This doesn't make sense because salesforce is now the source of truth so also needing we can trust it to have valid orgs. And if it doesn't that should be fixed in the salesforce process and not here.
feanil
force-pushed
the
feanil/update_salesforce_test
branch
from
ac9f88d
to
3e71265
Compare
|
The org.yml file is still being used by openedx-webooks in some way so while I think it makes sense to remove it in the long term, I think the task is a bit complex so I'm not gonna do that as a part of this change. |
|
Do we have a plan to put the information in salesforce and update openedx-webhooks to use it? We've removed some validation before replacing it, it seems. |
|
The information is already in Salesforce, the org is included in the exported file, but we're saying we don't need an additional external validation because Salesforce is the source-of-truth. Is there a use case for another system needing the list of orgs? |
That would be a good thing to find out before a breaking change in the validation :) It's perhaps not needed now, but the OSPR bot reads orgs.yaml to determine internal/external/contractor. |
|
I honestly think having the CLA check file updated reliably is more important. This accomplishes that. Happy to fix forward if necessary. |
|
@nedbat so it sounds like we need to update openedx-webhooks bot to read orgs from the CSV as well? I'll add a ticket for that. |
BREAKING CHANGE: We no longer test that the "Account Name" for the CSV has a valid
entry in the orgs.yaml file in the same directory. This doesn't make sense because
salesforce is now the source of truth so also needing we can trust it to have valid
orgs. And if it doesn't that should be fixed in the salesforce process and not here.