Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test failure] TC_LEARNER_7: Can't create an account #318

Closed
kdmccormick opened this issue Oct 20, 2023 · 16 comments
Closed

[Test failure] TC_LEARNER_7: Can't create an account #318

kdmccormick opened this issue Oct 20, 2023 · 16 comments
Assignees
Labels
needs triage release blocker Blocks the upcoming release (fix needed)
Milestone

Comments

@kdmccormick
Copy link
Member

kdmccormick commented Oct 20, 2023

Release

Quince

Expected behavior

"Register" lets me create an account

Actual behavior

Error: We couldn't create your account.
Please check your responses and try again.

Steps to reproduce

Additional information

image

Notes:

@kdmccormick kdmccormick changed the title [Test failure] ID???: Can't create an account [Test failure] TC_LEARNER_7: Can't create an account Oct 20, 2023
@sambapete
Copy link

@kdmccormick I definitely encountered the same issue on the demo / test server. I didn't report it yet as I was giving time to @regisb in order to fix potential issues with the MFEs that were made available earlier today by @arbrandes. Thanks for reporting it.

@fayyazahmed66
Copy link

Same. I am also not able to register.
signup

@mariajgrimaldi mariajgrimaldi added this to the Quince.1 milestone Oct 24, 2023
@sambapete
Copy link

Still unable to create an account after Dean officially announced testing earlier today.

@kdmccormick
Copy link
Member Author

In my notes I said:

I am noticing the same behavior on a laptop installation of Tutor Nightly, both in local and dev modes.

Unfortunately, this turned out to be a separate issue, caused by the pyjkest->pyjwt upgrade which merged after the Quince cut. (it's now fixed in Tutor nightly).

So, we currently have no leads on what might be causing this.

Is there anyone with an account already created that can confirm whether login works? Or are we all locked out right now?

@mariajgrimaldi
Copy link
Member

@kdmccormick: I logged in using the default credentials listed here, but of course I didn't create the account.

@regisb
Copy link
Contributor

regisb commented Oct 27, 2023

This is definitely a critical issue, but please don't let it block your testing. You can login with existing admin or student credentials:

@mariajgrimaldi mariajgrimaldi added quince testing release blocker Blocks the upcoming release (fix needed) labels Oct 30, 2023
@ghassanmas ghassanmas self-assigned this Nov 2, 2023
@ghassanmas
Copy link
Member

I've been looking into this and I am sitll debuggin it, I will report here as soon as I find something or open a PR..etc

ghassanmas added a commit to ghassanmas/frontend-app-authn that referenced this issue Nov 2, 2023
  When country is not required to submit, the displayValue check
  will always return true. This fixes it by only check it if it's
  needed through the config `SHOW_CONFIGURABLE_EDX_FIELDS`

  This issue might has been discoverd at edx.org becuase edx.org
  requires the Country to be filled when creating an account,
  however this is not the case for Open edX by default, hence the
  issue reported below

  Ref: openedx/wg-build-test-release/issues/318
@ghassanmas
Copy link
Member

Regarding the account creation issue, I opened a PR upstream to fix it openedx/frontend-app-authn#1099 I am sure it will resolve it but I am not sure if it’s the best solution… I think at least we know now, where is it coming from; The Country Field

@mariajgrimaldi
Copy link
Member

mariajgrimaldi commented Nov 6, 2023

I tested this on my local environment, which worked like a charm! Now I'm wondering what changed that now is failing. @ghassanmas: do you have a clue on what could have happened? 🤔

@ghassanmas
Copy link
Member

Now I'm wondering what changed that now is failing. @ghassanmas: do you have a clue on what could have happened? 🤔

@mariajgrimaldi I didn't quite get that, could you elobrate please? What is failing exactly?

@mariajgrimaldi
Copy link
Member

@ghassanmas: the registration process

@ghassanmas
Copy link
Member

It still fails on edly (the main sandbox) because still my PR, needs to be merged and backported. Or do you mean it stills fails for you locally?

@mariajgrimaldi
Copy link
Member

@ghassanmas: I tested locally and it's working. I meant why it's failing in quince. Sorry if I wasn't clear😅

regisb pushed a commit to overhangio/frontend-app-authn that referenced this issue Nov 13, 2023
  When country is not required to submit, the displayValue check
  will always return true. This fixes it by only check it if it's
  needed through the config `SHOW_CONFIGURABLE_EDX_FIELDS`

  This issue might has been discoverd at edx.org becuase edx.org
  requires the Country to be filled when creating an account,
  however this is not the case for Open edX by default, hence the
  issue reported below

  Ref: openedx/wg-build-test-release/issues/318
@regisb
Copy link
Contributor

regisb commented Nov 13, 2023

I deployed Ghassan's fix on the demo server, so users should be able to sign up. Again, this is a temporary fix and we will need to merge (and backport) Ghassan's PR before the Quince release.

kdmccormick pushed a commit to openedx/frontend-app-authn that referenced this issue Nov 13, 2023
When country is not required to submit, the displayValue check
will always return true. This fixes it by only check it if it's
needed through the config `SHOW_CONFIGURABLE_EDX_FIELDS`

This issue might has been discoverd at edx.org becuase edx.org
requires the Country to be filled when creating an account,
however this is not the case for Open edX by default, hence the
issue reported below

Ref: openedx/wg-build-test-release/issues/318
arbrandes pushed a commit to arbrandes/frontend-app-authn that referenced this issue Nov 17, 2023
When country is not required to submit, the displayValue check
will always return true. This fixes it by only check it if it's
needed through the config `SHOW_CONFIGURABLE_EDX_FIELDS`

This issue might has been discoverd at edx.org becuase edx.org
requires the Country to be filled when creating an account,
however this is not the case for Open edX by default, hence the
issue reported below

Ref: openedx/wg-build-test-release/issues/318
arbrandes pushed a commit to openedx/frontend-app-authn that referenced this issue Nov 17, 2023
When country is not required to submit, the displayValue check
will always return true. This fixes it by only check it if it's
needed through the config `SHOW_CONFIGURABLE_EDX_FIELDS`

This issue might has been discoverd at edx.org becuase edx.org
requires the Country to be filled when creating an account,
however this is not the case for Open edX by default, hence the
issue reported below

Ref: openedx/wg-build-test-release/issues/318
@mariajgrimaldi
Copy link
Member

This was fixed by the PR linked above.

@fayyazahmed66
Copy link

@mariajgrimaldi Verified. Thanks.

snglth pushed a commit to Abstract-Tech/community-theme-authn that referenced this issue Jan 9, 2024
When country is not required to submit, the displayValue check
will always return true. This fixes it by only check it if it's
needed through the config `SHOW_CONFIGURABLE_EDX_FIELDS`

This issue might has been discoverd at edx.org becuase edx.org
requires the Country to be filled when creating an account,
however this is not the case for Open edX by default, hence the
issue reported below

Ref: openedx/wg-build-test-release/issues/318
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage release blocker Blocks the upcoming release (fix needed)
Projects
Development

No branches or pull requests

6 participants