Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test failure] <TC_LEARNER_REDWOOD_17>: The learner cannot return to the other sections if he chooses the locked unit in the sidebar #363

Open
mariiamoskalenko opened this issue May 23, 2024 · 12 comments
Labels
redwood release testing Affects the upcoming release (attention needed)
Milestone

Comments

@mariiamoskalenko
Copy link

Release

Redwood

Expected behavior

As a user, I want to be able to navigate between sections if I'm on the locked unit so that I can easily return to the section with the prerequisite and finish the assignment

Actual behavior

As a user, I CANNOT navigate between sections if I'm on the locked unit so that I have to return to the outline and spend additional time trying to figure out what is going on

Steps to reproduce

  1. Enrol into the course with subsections with prerequisites (I created this one for test).
  2. Start with any subsection.
  3. Go to the "locked unit" - with the pre-requisite on the subsection.
  4. There are no sections and subsections, just a "course outline".
Screen.Recording.2024-05-23.at.17.22.02.mov

Additional information

I'm testing it with the staff user, through Audit mode (maybe it affects smth).

@mariiamoskalenko mariiamoskalenko added release testing Affects the upcoming release (attention needed) needs triage labels May 23, 2024
@mariajgrimaldi
Copy link
Member

mariajgrimaldi commented May 24, 2024

@mariiamoskalenko: thanks for the report! Please, could you test with the student user as well? Here are the credentials:
username: student@overhang.io
password: student

@mariiamoskalenko
Copy link
Author

For the learner, it's even more strange.
Here is the video - the learner receives an error "There was an error loading this course.".

Here is the video

Screen.Recording.2024-05-24.at.17.16.20.mov

@mariiamoskalenko
Copy link
Author

Should I report it separately for the instructor and for the learner?

@mariiamoskalenko
Copy link
Author

As an Admin now I see that the prerequisite section is locked (but it's not supposed to be locked).

image

@crathbun428
Copy link

crathbun428 commented May 24, 2024

@mariiamoskalenko and @mariajgrimaldi - I tested this as a student and got the same error message. I went into the course in studio as staff and published and scheduled everything that had not been published or scheduled for the course (most of the locked and prerequisite units). Once everything in the course was published and scheduled, this weird behavior did not appear for either the learner account or the staff/admin account. This behavior only appears when there are locked or prerequisite units that haven't been scheduled in the course.

@crathbun428
Copy link

crathbun428 commented May 24, 2024

@mariiamoskalenko and @mariajgrimaldi - I suppose the one question I have is that when staff views a course as "live," shouldn't I see the locked icons on subsections/units locked behind an incomplete pre-requisite? Or is this counter to how things behave today?

(Another weird note about this screenshot is that subsections appear as complete when the units don't appear as complete I can create a minor bug ticket for this, but I suspect this might have to do with how completions are handled, and not have to do with the left-sidebar nav, but I'll document this regardless).
Screenshot 2024-05-24 at 11 58 07 AM

@mariajgrimaldi mariajgrimaldi added this to the Redwood.1 milestone May 24, 2024
@mariajgrimaldi
Copy link
Member

mariajgrimaldi commented May 24, 2024

@crathbun428: thanks for figuring this out!

I suppose the one question I have is that when staff views a course as "live," shouldn't I see the locked icons on subsections/units locked behind an incomplete pre-requisite? Or is this counter to how things behave today?

We don't have the sidebar in quince, so we can't compare the two. But in quince, we can access the locked content without any sign, as in Redwood:

Screencast.from.24-05-24.17.39.08.webm

Without any indication that that's the locked content, as it's currently happening.

(Another weird note about this screenshot is that subsections appear as complete when the units don't appear as complete I can create a minor bug ticket for this, but I suspect this might have to do with how completions are handled, and not have to do with the left-sidebar nav, but I'll document this regardless).

Is this the same behavior as in this bug report?

Thanks!

@mariiamoskalenko
Copy link
Author

@mariajgrimaldi yes, it looks like the same bug.

@mariajgrimaldi should I create a separate bug report for a student? Because I described this one about the Instructor experience.

Also, there is an additional issue: units of the section without the prerequisite are also shown with locked units on the navigation sidebar. Should it be reported as a separate issue?

@mariajgrimaldi
Copy link
Member

mariajgrimaldi commented May 28, 2024

@mariiamoskalenko: if all the inconsistent behavior you found is related to the same scenario but with different roles, then we can use the same report. But be sure to include all the info in the issue description. I'll use that info to replicate the behavior and report it to the corresponding repos for maintainers to review.

Now, I think we should open a new report for the other issue you mentioned:

units of the section without the prerequisite are also shown with locked units on the navigation sidebar.

So it's easier to track.

@mariajgrimaldi
Copy link
Member

@mariiamoskalenko: as @crathbun428 mentioned here:

Once everything in the course was published and scheduled, this weird behavior did not appear for either the learner account or the staff/admin account. This behavior only appears when there are locked or prerequisite units that haven't been scheduled in the course.

I can't either reproduce the error. Could you try again, considering those conditions? You can test with this course.

@mariiamoskalenko
Copy link
Author

Yes, I confirm that I cannot reproduce it now.

@mariajgrimaldi
Copy link
Member

@mariiamoskalenko: thank you! In the meantime, I'll open an issue for the weird behavior when the subsections/units are not published so the maintainers know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
redwood release testing Affects the upcoming release (attention needed)
Projects
Status: In progress
Development

No branches or pull requests

3 participants