New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/#315 deviating stats #324
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oedb_session fixtures was moved to conftest.py which is accessible by all tests
This test class verifies results for each step of run_ding0().
* tests/core/network/test_network.py::TestGridDing0::test_grid_stats * tests/tools/test_results.py::TestCalculateStats
* Updated expected data * Expected edges hard-coded as strings now * Simplified comparison and asserts (element-wise) * Asserts all 30 edges are compared (inkluding cable distributors) * Still preserves order of edges
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #315
Actually, it's not really fixed. Clearly spoken, we ship around the issue of non-deterministic results with ding0 when using Python>=3.5 by just allowing Python version >=3.6.
The problematic piece of code was not found in the end. It's quite likely that the solution is related to the following change:
Money quote from Python 3.6 what's new
Because Pandas 0.20.3 isn't available with Python >=3.7, currently, only Python 3.6 is supported.
Furthermore, it introduces
While implementing the fix for #315, it also closes #314.
As a result and in order to clean up, I would suggest to