Package update and python version update to 3.7 - 3.9 #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 20 commits
April 30, 2021 16:09
* test_rings * test_get_connected_lines_from_bus * test_get_connected_components_from_bus * test_get_neighbours Changed documentation of get_neighbours: * returns a set not a list Changed get_connected_components_from_bus: When searching connected switches it was searched in self.switches_df.bus_open. I think self.switches_df.bus_closed is correct, because in self.switches_df.bus_open only "virtual_..." are listed and not the "real" bus.
test_topology.py - test_get_connected_lines_from_bus tests if bus is in each line separately test_topology.py - test_get_connected_components_from_bus test if return dataframes of not connected components are empty
Change the way of CRS transformation method Reduced the calling of proj2equidistant to prevent performance loss
Content of Dataframe is equal but assert_frame_equal fails, therefore workaround with .to_string()
pd.testing.assert_frame_equal(
> timeseries_obj.loads_active_power, loads_active_power
)
E AssertionError: (None, <Hour>)
network/test_timeseries.py:99: AssertionError
Updated compare values, only small differences don't know why the changes occur
Fixed test_add_storage_unit_timeseries with pandas 1.2.4 TypeError: ufunc 'isfinite' not supported for the input types, and the inputs could not be safely coerced to any supported types according to the casting rule ''safe''
Expected value deviated a bit, don't know why.
KeyError: "Passing list-likes to .loc or [] with any missing labels is no longer supported.
KeyError: "Passing list-likes to .loc or [] with any missing labels is no longer supported.
KeyError: "Passing list-likes to .loc or [] with any missing labels is no longer supported.
Use numpy.isclose()
> assert (gens_before[gens_before["type"] == "solar"].p_nom.sum() ==
edisgo.topology.generators_df[
edisgo.topology.generators_df["type"] == "solar"].p_nom.sum())
E assert 10.203790999999992 == 10.203790999999994
io/test_generators_import.py:458: AssertionError
Added .tolist() in numpy.isclose(...) E TypeError: ufunc 'isfinite' not supported for the input types, and the inputs could not be safely coerced to any supported types according to the casting rule ''safe''
This was referenced Jul 9, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated packages and python version for python 3.7 to 3.9 all tests are passing.
Setup.py updated that an error occur if python 3.6 is installed
Todo: