Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carrier naming land transport EV within grid.egon_etrago_load #1105

Closed
khelfen opened this issue Feb 15, 2023 · 6 comments · Fixed by #1111
Closed

Carrier naming land transport EV within grid.egon_etrago_load #1105

khelfen opened this issue Feb 15, 2023 · 6 comments · Fixed by #1111
Assignees
Labels
🐛 bug Something isn't working

Comments

@khelfen
Copy link
Contributor

khelfen commented Feb 15, 2023

@nesnoj within the table grid.egon_etrago_load there are two carriers for EV at the moment. land transport EV and land_transport_EV. Is there any reasoning for that? Should we change land transport EV to land_transport_EV as at the moment it is the only carrier with whitespaces instead of underscores?

@khelfen khelfen added the 🐛 bug Something isn't working label Feb 15, 2023
@nesnoj
Copy link
Member

nesnoj commented Feb 16, 2023

Hey @khelfen, I used land transport EV as it is used in p-e-s as well and I wanted to be in line with its carrier naming (which was also requested by @ClaraBuettner earlier). But I can alter this if needed.
Moreover, I used further carriers with spaces such as BEV charger. Am I to adjust all of them?

@IlkaCu This was discussed yesterday but unfortunately I wasn't able to take part. Shall I change it?

@khelfen
Copy link
Contributor Author

khelfen commented Feb 16, 2023

Hey @khelfen, I used land transport EV as it is used in p-e-s as well and I wanted to be in line with its carrier naming (which was also requested by @ClaraBuettner earlier). But I can alter this if needed. Moreover, I used further carriers with spaces such as BEV charger. Am I to adjust all of them?

@IlkaCu This was discussed yesterday but unfortunately I wasn't able to take part. Shall I change it?

In that case I'm just wondering where does land_transport_EV come from? I couldn't find it mentioned in the code base anywhere. TBH land transport EV is fine with me (having your reasoning in mind) but the double naming is confusing 🤔

@nesnoj
Copy link
Member

nesnoj commented Feb 16, 2023

In that case I'm just wondering where does land_transport_EV come from? I couldn't find it mentioned in the code base anywhere. TBH land transport EV is fine with me (having your reasoning in mind) but the double naming is confusing thinking

I found some replacements for the p-e-s components here (search for carrier.str.replace(" ", "_")) but this only covers neighboring countries, doesn't it?
@IlkaCu @ClaraBuettner Please drop us a note if you have more information or a clear opinion how to proceed.

@nesnoj
Copy link
Member

nesnoj commented Feb 23, 2023

From today's webco: I will rename the carriers

@khelfen
Copy link
Contributor Author

khelfen commented Feb 23, 2023

From today's webco: I will rename the carriers

@mltja FYI

@nesnoj
Copy link
Member

nesnoj commented Feb 23, 2023

I checked the DB tables and it depends on the scnenario:

  • eGon2035: white spaces
  • eGon2035_lowflex: white spaces
  • eGon100RE: white spaces (my components) and underscores (only 14, I guess they come from p-e-s)
  • eGon100RE_lowflex: white spaces

nesnoj added a commit that referenced this issue Feb 23, 2023
…inuous-integration/run-everything-2022-11-10
nesnoj added a commit that referenced this issue Mar 28, 2023
…-transport-ev

Change eMob MIT carrier names in eMob model timeseries generation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants