Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gas sanity checks #1006

Closed
wants to merge 44 commits into from
Closed

Gas sanity checks #1006

wants to merge 44 commits into from

Conversation

AmeliaNadal
Copy link
Contributor

@AmeliaNadal AmeliaNadal commented Oct 25, 2022 •
edited

Fixes #864 .

Depends on #931.

Before merging into dev-branch, please make sure that

  • the CHANGELOG.rst was updated.
  • new and adjusted code is formated using black and isort.
  • the Dataset-version is updated when existing datasets are adjusted.
  • the branch was merged into the
    continuous-integration/run-everything-over-the-weekend-branch.
  • the workflow is running successful in test mode. -> some checks work also in test mode but not all of them
  • the workflow is running successful in Everything mode.

AmeliaNadal added 30 commits July 27, 2022 10:13
Update CHANGELOG
d689b33
Increase dataset version
0239f8a
Merge dev into features/#844-biogas_gen_eGon100RE
0e406ff
Resolve merging conflict
f09a1c5
Improve doc
ef72e21
Separate download of data in dedicated function
8b6dbae
Merge branch 'dev' into features/#844-biogas_gen_eGon100RE
f8c48fe
Merge branch 'dev' into features/#844-biogas_gen_eGon100RE
94a5f55
Insert function to ovrwrite gas parameter
e09265f
Correct typo
9cc8147
Use variable for 'CH4'
18673a2
Merge branch 'features/#881-cross-bording-pipes-eGon100RE-DE' into fe…
5889be9 
…atures/#844-biogas_gen_eGon100RE
Create biogas generators abroad
98dc3d3
Move functions to other file
f3c5030
Apply black and isort
b3d083c
Adjust documentation
742a69c
Correct function call and function argument, modify Overwriting function
b4b58af
Apply black
6799822
Increase dataset version - GasNeighbourgs
c8d9f9a
Remove useless variable
c4f59d2
Add missing download task to CH4Production dataset
6b0db02
Add missing dependency
a8c7986
Apply black
0eec244
Merge branch 'dev' into branch features/#844-biogas_gen_eGon100RE
eb4b16e 
'
Mode change
92e6b22
Merge branch 'features/#940-adjust-H2-industrial-loads' into features/#…
d877064 
…864-gas-sanity-checks
Resolve CHANGELOG conflict
f1e956f
Undo accidental change
febdd98
Updat CHANGELOG
40c7d70
First draft gas sanity checks
516c322
@AmeliaNadal AmeliaNadal self-assigned this Oct 25, 2022
@IlkaCu
Copy link
Member

IlkaCu commented Dec 14, 2022

If I understand it right this PR includes changes about the 100RE scenario which shouldn't be merged right now. Can you 'divide' this PR into a 'eGon2035' and a 'eGon100RE' part, where the first one does not depend on #931?

@AmeliaNadal
Copy link
Contributor Author

AmeliaNadal commented Dec 14, 2022 •
edited

If I understand it right this PR includes changes about the 100RE scenario which shouldn't be merged right now. Can you 'divide' this PR into a 'eGon2035' and a 'eGon100RE' part, where the first one does not depend on #931?

The sanity checks for gas need to be completed, so I would close this PR and create two new ones as you've suggested:

@AmeliaNadal AmeliaNadal deleted the features/#864-gas-sanity-checks branch March 27, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IlkaCu IlkaCu Awaiting requested review from IlkaCu

Assignees

@AmeliaNadal AmeliaNadal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create sanity checks for gas sector for eGon2035
2 participants
@AmeliaNadal @IlkaCu