Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function to download MaStR data from Zenodo #130

Merged
merged 6 commits into from Mar 4, 2021

Conversation

gplssm
Copy link
Contributor

@gplssm gplssm commented Mar 4, 2021

Download cleaned data from Zenodo.

Fixes #14

@gplssm
Copy link
Contributor Author

gplssm commented Mar 4, 2021

Hey @ClaraBuettner,
I added some code for download of data from Zenodo and linked it in the pipeline.
I chose to download only "cleaned" data for now. But this can be configured in the function. Remember, cleaned data is the same as raw data, just filtered (the definition will change).
I didn't do more than providing the CSV files. Can you work with or do have other things that I should do here?

And for reference: https://open-mastr.readthedocs.io/en/dev/data_documentation.html#

@ClaraBuettner
Copy link
Contributor

Thank you, I can work with this!
It is still marked as draft, does that mean that you currently don't want to merge this?

@gplssm
Copy link
Contributor Author

gplssm commented Mar 4, 2021

Thank you, I can work with this!

😎

It is still marked as draft, does that mean that you currently don't want to merge this?

At least I wanted to discuss with you first.
Since you seem happy with this as intermediate solution, I would be ok to merge it to dev and create a new issue for adding post-processing or simply download post-processed MaStR data later.

I add a note to the CHANGELOG and make the PR ready for review then.

@gplssm gplssm marked this pull request as ready for review March 4, 2021 11:05
@gplssm gplssm merged commit d04b8e8 into dev Mar 4, 2021
@gplssm gplssm deleted the features/#14-integrate-open-mastr-data branch March 4, 2021 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate open_MaStR
2 participants