Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit number of parallel processes per task #269

Merged
merged 7 commits into from Oct 5, 2021

Conversation

ClaraBuettner
Copy link
Contributor

Closes #265

@ClaraBuettner ClaraBuettner mentioned this pull request Jun 3, 2021
@ClaraBuettner ClaraBuettner marked this pull request as ready for review June 3, 2021 14:28
@ClaraBuettner ClaraBuettner requested a review from gnn June 3, 2021 14:28
@ClaraBuettner
Copy link
Contributor Author

@gnn: The number of parallel processes is currently manually set to one in each tasks which uses multi processing. I could also add a variable, e.g. max_processes_per_task to the configuration file which is one by default but could also be increased.

@ClaraBuettner
Copy link
Contributor Author

The number of parallel process per task is now part of the cli and stored in the egon-data.configuration file. It is just one value for all tests, it's not task-specific because this would require information about the task dependencies.
I tested it and it worked fine.

KathiEsterl added a commit that referenced this pull request Sep 3, 2021
@ClaraBuettner
Copy link
Contributor Author

I updated the branch with the current dev and run it in test mode.

@nesnoj The task hh_demand_profiles.houseprofiles-in-census-cells takes 6:30 min with processes-per-task=2 and 8 min with processes-per-task=1 for Schleswig Holstein. So it is slower, but not linear to the number of processes.
If you're ok with this, I will merge this into the continuous integration branch to see how it performs for Germany with processes-per-task=2.

@nesnoj
Copy link
Member

nesnoj commented Sep 9, 2021

If you're ok with this, I will merge this into the continuous integration branch to see how it performs for Germany with processes-per-task=2.

Yepp, go ahead 👍

@KathiEsterl KathiEsterl merged commit 509cf02 into dev Oct 5, 2021
@ClaraBuettner
Copy link
Contributor Author

This branch was somehow merged intodev via another branch but the changes are not on dev anymore. I'm wondering why this happened...
@KathiEsterl: Was it intended to merge this branch?

@KathiEsterl
Copy link
Contributor

This branch was somehow merged intodev via another branch but the changes are not on dev anymore. I'm wondering why this happened... @KathiEsterl: Was it intended to merge this branch?

I never meant to do anything with this branch!
I think while commiting something to the DSM-branch I used the Hashtag for this PR although I probably meant something else... That's how this got mixed up. It looks like I merged it together with the DSM-branch then, but I am not sure as I had checked all the changes in the DSM-branch before merging in detail. I don't really know what happened here...
I am sorry for that! Let me know if I can help with that.

@ClaraBuettner
Copy link
Contributor Author

I never meant to do anything with this branch! I think while commiting something to the DSM-branch I used the Hashtag for this PR although I probably meant something else... That's how this got mixed up. It looks like I merged it together with the DSM-branch then, but I am not sure as I had checked all the changes in the DSM-branch before merging in detail. I don't really know what happened here... I am sorry for that! Let me know if I can help with that.

I can imagine that it happened because there was still the commit in your branch, even if it was reverted later git thought this was merged. The code changes are not in dev branch, if we want to have them I can re-do the commits.
I already checked that this only happened in this PR.

@ClaraBuettner ClaraBuettner deleted the features/#265-limit-number-of-processes-per-task branch February 24, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set maximum number of processes per task
3 participants