Features/improve gas aggregation #775
Conversation
|
@AmeliaNadal I will be available again to check this PR on Wednesday 01.06. If it is not urgent, I can take care of it that day. Is it ok? |
Yes, this is completely fine :) |
| @@ -357,6 +357,8 @@ Changed | |||
| `#581 <https://github.com/openego/eGon-data/issues/581>`_ | |||
| * Update deposit id to access v0.7 of the zenodo repository | |||
| `#736 <https://github.com/openego/eGon-data/issues/736>`_ | |||
| * Improve CH4 stores and productions aggregation by removing dedicated task | |||
| `#PR775 <https://github.com/openego/eGon-data/pull/775>`_ | |||
There was a problem hiding this comment.
Normally we reference the issue that is solved by the PR.
There was a problem hiding this comment.
There is no issue associated to the PR, should I create one?
|
@AmeliaNadal could you send me the link of the issue where that motivated this PR, please? |
There is no issue associated to the PR, should I create one? |
I applied black and isort to all the modified files (dc35548) and I don't think you need to run this branch to test it, but it is up to you if you think it is neccessary to approve the PR ;) |
It is mostly to give a bit of context of the purpose of the changes. In this case, I think we can omit it. |
Since the changes are not so big, the changes are straightforward, and it was tested for SH and Germany I don't consider it necessary to run this branch. |
This PR has for aim to improve the aggregation of the gas stores and generators by:
In this way, the aggregation of gas stores and generators will be consistent to the one of industrial gas loads (see #761).
Before merging into
dev-branch, please make sure thatCHANGELOG.rstwas updated.blackandisort.Dataset-version is updated when existing datasets are adjusted.continuous-integration/run-everything-over-the-weekend-branch.test mode.Everythingmode.