Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the reconcile logic which add route without waiting for all endpoints up #24

Merged
merged 5 commits into from Mar 25, 2019
Merged

fix the reconcile logic which add route without waiting for all endpoints up #24

merged 5 commits into from Mar 25, 2019

Conversation

magicsong
Copy link

Add jenkinsfile

@magicsong magicsong added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 22, 2019
@magicsong magicsong added this to the v1 milestone Mar 22, 2019
@magicsong magicsong self-assigned this Mar 22, 2019
@magicsong magicsong added this to In progress in Porter v1 kanban via automation Mar 22, 2019
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: magicsong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 22, 2019
@ks-ci-bot ks-ci-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 22, 2019
@magicsong magicsong changed the title fix jenkinsfile [WIP] fix jenkinsfile Mar 22, 2019
@ks-ci-bot ks-ci-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 22, 2019
@magicsong magicsong changed the title [WIP] fix jenkinsfile fix the controller which add route without waiting for all endpoints up Mar 25, 2019
@ks-ci-bot ks-ci-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 25, 2019
@magicsong magicsong changed the title fix the controller which add route without waiting for all endpoints up fix the reconcile logic which add route without waiting for all endpoints up Mar 25, 2019
@magicsong magicsong added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2019
@ks-ci-bot ks-ci-bot merged commit 99ef7c5 into openelb:master Mar 25, 2019
Porter v1 kanban automation moved this from In progress to Done Mar 25, 2019
@magicsong magicsong deleted the jenkins branch March 25, 2019 06:36
@magicsong magicsong mentioned this pull request Mar 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@magicsong magicsong

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
No open projects
Porter v1 kanban
  
Done
Milestone
v1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@magicsong @ks-ci-bot