Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ench: add a better context abstraction #277

Closed
wants to merge 1 commit into from

Conversation

amalthundiyil
Copy link
Contributor

Currently openelb doesn't have an abstraction to work with the context.Context which can come very handy often. This PR adds a new appctx package along with tests which acts as a better interface to work with context.Context.

Signed-off-by: Amal Thundiyil amal.s.thundiyil@gmail.com

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: amal-thundiyil
To complete the pull request process, please assign chaunceyjiang after the PR has been reviewed.
You can assign the PR to them by writing /assign @chaunceyjiang in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: amal-thundiyil
To complete the pull request process, please assign chaunceyjiang after the PR has been reviewed.
You can assign the PR to them by writing /assign @chaunceyjiang in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 26, 2022
Signed-off-by: Amal Thundiyil <amal.s.thundiyil@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants