Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add CIDR range for NICs in layer2 #282

Merged
merged 1 commit into from Jul 4, 2022
Merged

feat: add CIDR range for NICs in layer2 #282

merged 1 commit into from Jul 4, 2022

Conversation

amalthundiyil
Copy link
Contributor

@amalthundiyil amalthundiyil commented May 28, 2022 •
edited

Description

Previously only IP of NIC could be added as annotation to node. With this PR, a CIDR format IP range can be used for identification of an NIC. All possible networks are iterated over in the CIDR range and selected accordingly.

Related Links

Signed-off-by: Amal Thundiyil amal.s.thundiyil@gmail.com

@ks-ci-bot ks-ci-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 28, 2022
@chaunceyjiang
Copy link
Contributor

Thank you for your work. I will test this PR later

@chaunceyjiang
Copy link
Contributor

/lgtm
/cc @renyunkang

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label May 29, 2022
@chaunceyjiang
Copy link
Contributor

/lgtm cancel

@ks-ci-bot ks-ci-bot removed lgtm Indicates that a PR is ready to be merged. labels May 29, 2022
@chaunceyjiang
Copy link
Contributor

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label May 30, 2022
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 1fb4a7ee0fd999c196354f8b97911958e48fcda9

1 similar comment
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 1fb4a7ee0fd999c196354f8b97911958e48fcda9

@chaunceyjiang
Copy link
Contributor

kindly ping @amal-thundiyil

@amalthundiyil
Copy link
Contributor Author

@chaunceyjiang, is there anything you'd like me to change in this PR?

@chaunceyjiang
Copy link
Contributor

@amal-thundiyil

Could you please provide some test screenshots?

@amalthundiyil
feat(layer2): add CIDR range for NICs
dd65a4a 
Signed-off-by: Amal Thundiyil <amal.s.thundiyil@gmail.com>
@ks-ci-bot ks-ci-bot removed lgtm Indicates that a PR is ready to be merged. labels Jun 21, 2022
@amalthundiyil
Copy link
Contributor Author

@amal-thundiyil
Could you please provide some test screenshots?

Sorry for the delayed response. I have added a test.

@renyunkang
Copy link
Member

When defining eip in this way, it is still necessary to specify spec.interface with the actual NIC or can_reach: ${ip}. Is it impossible to solve the unmeasurable NIC and ip mentioned in the issue?

@chaunceyjiang
Copy link
Contributor

Thanks!
/lgtm

@ks-ci-bot ks-ci-bot added lgtm Indicates that a PR is ready to be merged. labels Jul 4, 2022
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 86c740cd0551f6ea48a5855f30260253241a9c5f

1 similar comment
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 86c740cd0551f6ea48a5855f30260253241a9c5f

@renyunkang
Copy link
Member

Regarding the value of openelb eip, we still need to solve it in other ways. There is no problem with node labels specifying NICs using the CIDR range.
(We use the network card specified by eip to listen for arp requests. Use layer2.porter.kubesphere.io/v1alpha1 to specify the next hop, and the mac corresponding to the specified ip as the arp response packet.)

Thanks !!!

/lgtm
/approve

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amal-thundiyil, renyunkang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amal-thundiyil, renyunkang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 4, 2022
@ks-ci-bot ks-ci-bot merged commit 77e6670 into openelb:master Jul 4, 2022
@amalthundiyil amalthundiyil deleted the ip branch July 4, 2022 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaunceyjiang chaunceyjiang chaunceyjiang left review comments

@renyunkang renyunkang renyunkang left review comments

Assignees

@chaunceyjiang chaunceyjiang

@renyunkang renyunkang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unpredictable Node IP addresses
4 participants
@amalthundiyil @chaunceyjiang @ks-ci-bot @renyunkang