Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an http server for web ui #290

Merged
merged 24 commits into from Apr 14, 2023
Merged

Add an http server for web ui #290

merged 24 commits into from Apr 14, 2023

Conversation

AnuragThePathak
Copy link
Contributor

@AnuragThePathak AnuragThePathak commented Jun 30, 2022 •
edited

Description

A new http server with the basic has been added for the web ui to be developed. Watch of openelb resources are not supported at this moment.

Related links:

#244

@ks-ci-bot ks-ci-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 30, 2022
@AnuragThePathak
Copy link
Contributor Author

/lint

ks-ci-bot
ks-ci-bot reviewed Jun 30, 2022
View reviewed changes
Copy link
Collaborator

@ks-ci-bot ks-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AnuragThePathak: 4 warnings.

In response to this:

/lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pkg/server/options.go Outdated Show resolved Hide resolved
pkg/server/options.go Outdated Show resolved Hide resolved
pkg/server/options.go Outdated Show resolved Hide resolved
pkg/server/server.go Outdated Show resolved Hide resolved
@AnuragThePathak AnuragThePathak force-pushed the server-setup branch 2 times, most recently from 6bdad9d to 5f599ba Compare July 1, 2022 08:09
@AnuragThePathak AnuragThePathak marked this pull request as draft July 1, 2022 10:13
@ks-ci-bot ks-ci-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jul 1, 2022
@AnuragThePathak
add an http server
22f521c 
Signed-off-by: Anurag Pathak <anuragpathak911@gmail.com>
@AnuragThePathak
add endpoints interface and request handling in http server
e7c439c 
Signed-off-by: Anurag Pathak <anuragpathak911@gmail.com>
@AnuragThePathak AnuragThePathak force-pushed the server-setup branch 2 times, most recently from 28f8734 to cbd1963 Compare July 1, 2022 17:46
@AnuragThePathak
add endpoints, services and store for bgpconf in http server
60fe298 
Signed-off-by: Anurag Pathak <anuragpathak911@gmail.com>
@AnuragThePathak
add endpoints, services and store for bgppeer in http server
5af562e 
Signed-off-by: Anurag Pathak <anuragpathak911@gmail.com>
@ks-ci-bot ks-ci-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 1, 2022
@AnuragThePathak
add endpoints, services and store for eip in http server
a6c9f3a 
Signed-off-by: Anurag Pathak <anuragpathak911@gmail.com>
@AnuragThePathak
fix a few grammatical issues in comments in server
d855c3a 
Signed-off-by: Anurag Pathak <anuragpathak911@gmail.com>
@AnuragThePathak
fix problem of not sending correct status code in http server
55cbed9 
Signed-off-by: Anurag Pathak <anuragpathak911@gmail.com>
@AnuragThePathak AnuragThePathak marked this pull request as ready for review July 2, 2022 11:22
@ks-ci-bot ks-ci-bot removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jul 2, 2022
@AnuragThePathak
Copy link
Contributor Author

/assign @renyunkang

@AnuragThePathak
replace custom signal handler by controller-runtime signal handler
fc2a388 
Signed-off-by: Anurag Pathak <anuragpathak911@gmail.com>
@renyunkang
Copy link
Member

Yes I'm aware that it's a much needed feature, I tried to add it as well, but things were not working as expected while using PUT requests with the Kubernetes client. Hence, I thought maybe I should focus on frontend part now and tackle that later.

okay

@AnuragThePathak
update routers and handlers to delete resources by name
0d9339b 
Signed-off-by: Anurag Pathak <anuragpathak911@gmail.com>
@AnuragThePathak
fix inconsistent naming in comment for godocs
a79632a 
Signed-off-by: Anurag Pathak <anuragpathak911@gmail.com>
@AnuragThePathak
add patching options for openelb resources
8e858c7 
Signed-off-by: Anurag Pathak <anuragpathak911@gmail.com>
@AnuragThePathak
Copy link
Contributor Author

It seems like OpenElb doesn't allow modifying EIPs. So most probably there's no use of having PATCH method for EIP. Now should I completely remove the handler also or keep that?

@renyunkang
Copy link
Member

It seems like OpenElb doesn't allow modifying EIPs. So most probably there's no use of having PATCH method for EIP. Now should I completely remove the handler also or keep that?

We allow update operations on eip, now only enable/disable eip.

@AnuragThePathak
update cors in http server
944c9c6 
Signed-off-by: Anurag Pathak <anuragpathak911@gmail.com>
@AnuragThePathak
Copy link
Contributor Author

While writing the code for frontend we can see that some changes are required in the CORS, routes and a few minor things.

@AnuragThePathak
update bgp routes as per requirement of frontend
f935c07 
Signed-off-by: Anurag Pathak <anuragpathak911@gmail.com>
@AnuragThePathak
update order imports in http server
236d888 
Signed-off-by: Anurag Pathak <anuragpathak911@gmail.com>
@AnuragThePathak
update allowed-origins in http server
43c1639 
Signed-off-by: Anurag Pathak <anuragpathak911@gmail.com>
@AnuragThePathak
fix issue of patch not properly working
bf1eec1 
Signed-off-by: Anurag Pathak <anuragpathak911@gmail.com>
@AnuragThePathak
add put method in http-server
e5137f3 
Signed-off-by: Anurag Pathak <anuragpathak911@gmail.com>
@renyunkang
Copy link
Member

/lgtm
/approve

@ks-ci-bot ks-ci-bot added lgtm Indicates that a PR is ready to be merged. labels Apr 14, 2023
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 33275f3f2ca4ca0f72ae07f996252c14c5d27070

1 similar comment
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 33275f3f2ca4ca0f72ae07f996252c14c5d27070

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AnuragThePathak, renyunkang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AnuragThePathak, renyunkang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 14, 2023
@ks-ci-bot ks-ci-bot merged commit 8a0266a into openelb:master Apr 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaunceyjiang chaunceyjiang chaunceyjiang left review comments

@renyunkang renyunkang renyunkang left review comments

@ks-ci-bot ks-ci-bot ks-ci-bot left review comments

Assignees

@renyunkang renyunkang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AnuragThePathak @chaunceyjiang @renyunkang @ks-ci-bot