Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

design(pkg/bgp): use GoBGP pkg/config for BgpConf RPC requests #305

Closed
wants to merge 6 commits into from
Closed

design(pkg/bgp): use GoBGP pkg/config for BgpConf RPC requests #305

wants to merge 6 commits into from

Conversation

amalthundiyil
Copy link
Contributor

Signed-off-by: Amal Thundiyil amal.s.thundiyil@gmail.com

Description

What type of PR is this ?: /kind design

Related links:

@amalthundiyil
refactor(speaker/bgp): add clientset to BGP speaker
2f9707b 
Signed-off-by: Amal Thundiyil <amal.s.thundiyil@gmail.com>
@amalthundiyil
design(pkg/bgp): use GoBGP pkg/config for RPC requests in BgpConf
a06118d 
Signed-off-by: Amal Thundiyil <amal.s.thundiyil@gmail.com>
@amalthundiyil
fix(bgp): modify tests and RPC requests
8c87590 
Signed-off-by: Amal Thundiyil <amal.s.thundiyil@gmail.com>
@amalthundiyil
tests(bgp): use temporary files for GoBGP config
b6f26f5 
Signed-off-by: Amal Thundiyil <amal.s.thundiyil@gmail.com>
@amalthundiyil
style(pkg/bgp): replace BgpConf with api.Global for type conversion
a7f1d13 
Signed-off-by: Amal Thundiyil <amal.s.thundiyil@gmail.com>
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: amal-thundiyil
To complete the pull request process, please assign chaunceyjiang after the PR has been reviewed.
You can assign the PR to them by writing /assign @chaunceyjiang in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: amal-thundiyil
To complete the pull request process, please assign chaunceyjiang after the PR has been reviewed.
You can assign the PR to them by writing /assign @chaunceyjiang in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 19, 2022
@amalthundiyil
feat(pkg/bgp): support all BgpConf type conversion
b4afbb8 
Signed-off-by: Amal Thundiyil <amal.s.thundiyil@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amalthundiyil @ks-ci-bot