Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add doc about setting up in real router. fix #33 #36

Merged
merged 1 commit into from Mar 29, 2019

Conversation

magicsong
Copy link

No description provided.

@magicsong magicsong added the doc document issue label Mar 29, 2019
@magicsong magicsong added this to the v1 milestone Mar 29, 2019
@magicsong magicsong self-assigned this Mar 29, 2019
@magicsong magicsong added this to In progress in Porter v1 kanban via automation Mar 29, 2019
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: magicsong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 29, 2019
@magicsong magicsong added the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2019
@ks-ci-bot ks-ci-bot merged commit 78282b1 into openelb:master Mar 29, 2019
Porter v1 kanban automation moved this from In progress to Done Mar 29, 2019
@magicsong magicsong deleted the doc branch March 29, 2019 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. doc document issue lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants