Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

La Crosse County Misspelled #35

Closed
nbdavies opened this issue Mar 14, 2018 · 2 comments
Closed

La Crosse County Misspelled #35

nbdavies opened this issue Mar 14, 2018 · 2 comments

Comments

@nbdavies
Copy link
Contributor

nbdavies commented Mar 14, 2018 •
edited
Loading

This came to light when I tried to run the load utility in the openelections-core repo. This tried to match county name from the CSVs in this repo to OCD IDs.

It failed, because there is no "Lacrosse" county in Wisconsin, but "Lacrosse" appears in about 1/3 of our CSV data, and "La Crosse" (correct) in the other 2/3.

There are also office names that include the incorrect county name, including circuit court and district attorney.
@nbdavies nbdavies mentioned this issue Apr 10, 2018
Merged
@davipo
Copy link
Contributor

davipo commented Apr 23, 2018

Do we have sufficient tests for this issue? If so, can it be closed?

@nbdavies
Copy link
Contributor Author

Yup, the fix included updates to the test file that would catch this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davipo @nbdavies