-
Notifications
You must be signed in to change notification settings - Fork 688
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
libgpiod: modify test 'gpioset: toggle (continuous)'
Look for level transitions when testing toggling values because using fixed delays to assume value changes is not reliable. Signed-off-by: Joe Slater <joe.slater@windriver.com> Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> Signed-off-by: Khem Raj <raj.khem@gmail.com>
- Loading branch information
1 parent
ce00fec
commit 45a8bb2
Showing
2 changed files
with
69 additions
and
0 deletions.
There are no files selected for viewing
67 changes: 67 additions & 0 deletions
67
meta-oe/recipes-support/libgpiod/libgpiod-2.x/gpio-tools-test-bats-modify.patch
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,67 @@ | ||
From 53f9670d6af1bd0745c1df9c469b269c72607b23 Mon Sep 17 00:00:00 2001 | ||
From: Joe Slater <joe.slater@windriver.com> | ||
Date: Tue, 6 Jun 2023 08:04:27 -0700 | ||
Subject: [PATCH] tools: tests: modify delays in toggle test | ||
|
||
The test "gpioset: toggle (continuous)" uses fixed delays to test | ||
toggling values. This is not reliable, so we switch to looking | ||
for transitions from one value to another. | ||
|
||
We wait for a transition up to 1.5 seconds. | ||
|
||
Signed-off-by: Joe Slater <joe.slater@windriver.com> | ||
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> | ||
|
||
Upstream-status: accepted | ||
|
||
Signed-off-by: Joe Slater <joe.slater@windriver.com> | ||
--- | ||
tools/gpio-tools-test.bats | 21 ++++++++++++++++----- | ||
1 file changed, 16 insertions(+), 5 deletions(-) | ||
|
||
diff --git a/tools/gpio-tools-test.bats b/tools/gpio-tools-test.bats | ||
index c83ca7d..929c35a 100755 | ||
--- a/tools/gpio-tools-test.bats | ||
+++ b/tools/gpio-tools-test.bats | ||
@@ -141,6 +141,20 @@ gpiosim_check_value() { | ||
[ "$VAL" = "$EXPECTED" ] | ||
} | ||
|
||
+gpiosim_wait_value() { | ||
+ local OFFSET=$2 | ||
+ local EXPECTED=$3 | ||
+ local DEVNAME=${GPIOSIM_DEV_NAME[$1]} | ||
+ local CHIPNAME=${GPIOSIM_CHIP_NAME[$1]} | ||
+ local PORT=$GPIOSIM_SYSFS/$DEVNAME/$CHIPNAME/sim_gpio$OFFSET/value | ||
+ | ||
+ for i in {1..15}; do | ||
+ [ "$(<$PORT)" = "$EXPECTED" ] && return | ||
+ sleep 0.1 | ||
+ done | ||
+ return 1 | ||
+} | ||
+ | ||
gpiosim_cleanup() { | ||
for CHIP in ${!GPIOSIM_CHIP_NAME[@]} | ||
do | ||
@@ -1567,15 +1581,12 @@ request_release_line() { | ||
gpiosim_check_value sim0 4 0 | ||
gpiosim_check_value sim0 7 0 | ||
|
||
- sleep 1 | ||
- | ||
- gpiosim_check_value sim0 1 0 | ||
+ gpiosim_wait_value sim0 1 0 | ||
gpiosim_check_value sim0 4 1 | ||
gpiosim_check_value sim0 7 1 | ||
|
||
- sleep 1 | ||
|
||
- gpiosim_check_value sim0 1 1 | ||
+ gpiosim_wait_value sim0 1 1 | ||
gpiosim_check_value sim0 4 0 | ||
gpiosim_check_value sim0 7 0 | ||
} | ||
-- | ||
2.25.1 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters