Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hash for x264 appears to no longer be correct #2

Closed
dhylands opened this issue May 29, 2014 · 3 comments
Closed

Hash for x264 appears to no longer be correct #2

dhylands opened this issue May 29, 2014 · 3 comments

Comments

@dhylands
Copy link

I've been working with the Intel Galileo, which I think is using the dylan branch.

The meta-oe/recipes-multimedia/x264/x264_git.bb file contains:

SRCREV = "1cffe9f406cc54f4759fc9eeb85598fb8cae66c7"

which appears to no longer exist in the git.videolan.org repository. I found this tree on gitorious: https://gitorious.org/gxk-media/x264/commits/1cffe9f406cc54f4759fc9eeb85598fb8cae66c7 which has the correct hash, and by comparing the description, I was able to determine that the corresponding hash in the current git.videolan.org repository is c6bfcec47c9d1fff0489a30215501babea29f59c

I wasn't quite sure what the development procedure for this repo was, so I thought I would raise the issue and ask how to proceed.

I'm happy to do a pull request. I noticed that x264 doesn't seem to exist in the master branch, and I wasn't sure of the significance of that either.

@ghost
Copy link

ghost commented Jul 28, 2014

So I edited meta-clanton_v1.0.1/meta-oe/meta-oe/recipes-multimedia/x264/x264_git.bb and changed the hash.

Here's my patch

diff --git a/meta-oe/recipes-multimedia/x264/x264_git.bb b/meta-oe/recipes-multimedia/x264/x264_git.bb
index 5222d1d..b1b131a 100644
--- a/meta-oe/recipes-multimedia/x264/x264_git.bb
+++ b/meta-oe/recipes-multimedia/x264/x264_git.bb
@@ -11,7 +11,7 @@ DEPENDS = "yasm-native"
SRC_URI = "git://git.videolan.org/x264.git
file://don-t-default-to-cortex-a9-with-neon.patch
"
-SRCREV = "1cffe9f406cc54f4759fc9eeb85598fb8cae66c7"
+SRCREV = "bfed708c5358a2b4ef65923fb0683cefa9184e6f"

PV = "r2230+git"

@ghost
Copy link

ghost commented Jul 28, 2014

if you find this useful then please let me know

philb pushed a commit that referenced this issue Jul 8, 2015
the patch comes from:
https://bugs.launchpad.net/ubuntu/+source/netkit-telnet/+bug/507455
https://launchpadlibrarian.net/37882973/0001-telnetd-Fix-deadlock-on-cleanup.patch

The cleanup function in telnetd is called both directly and on SIGCHLD
signals. This, unfortunately, triggered a deadlock in eglibc 2.9 while
running on a 2.6.31.11 kernel.

What we were seeing is hangs like these:

  (gdb) bt
  #0  0xb7702424 in __kernel_vsyscall ()
  #1  0xb7658e61 in __lll_lock_wait_private () from ./lib/libc.so.6
  #2  0xb767e7b5 in _L_lock_15 () from ./lib/libc.so.6
  #3  0xb767e6e0 in utmpname () from ./lib/libc.so.6
  #4  0xb76bcde7 in logout () from ./lib/libutil.so.1
  #5  0x0804c827 in cleanup ()
  #6  <signal handler called>
  #7  0xb7702424 in __kernel_vsyscall ()
  #8  0xb7641003 in __fcntl_nocancel () from ./lib/libc.so.6
  #9  0xb767e0c3 in getutline_r_file () from ./lib/libc.so.6
  #10 0xb767d675 in getutline_r () from ./lib/libc.so.6
  #11 0xb76bce42 in logout () from ./lib/libutil.so.1
  #12 0x0804c827 in cleanup ()
  #13 0x0804a0b5 in telnet ()
  #14 0x0804a9c3 in main ()

and what has happened here is that the user closes the telnet session
via the escape character. This causes telnetd to call cleanup in frame
the SIGCHLD signal is delivered while telnetd is executing cleanup.

Telnetd then calls the signal handler for SIGCHLD, which is cleanup().
Ouch. The actual deadlock is in libc. getutline_r in frame #10 gets the
__libc_utmp_lock lock, and utmpname above does the same thing in frame

The fix registers the SIGCHLD handler as cleanup_sighandler, and makes
cleanup disable the SIGCHLD signal before calling cleanup_sighandler.

Signed-off-by: Simon Kagstrom <simon.kagstrom@netinsight.net>
Signed-off-by: Li Wang <li.wang@windriver.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
philb pushed a commit that referenced this issue Jul 15, 2015
the patch comes from:
https://bugs.launchpad.net/ubuntu/+source/netkit-telnet/+bug/507455
https://launchpadlibrarian.net/37882973/0001-telnetd-Fix-deadlock-on-cleanup.patch

The cleanup function in telnetd is called both directly and on SIGCHLD
signals. This, unfortunately, triggered a deadlock in eglibc 2.9 while
running on a 2.6.31.11 kernel.

What we were seeing is hangs like these:

  (gdb) bt
  #0  0xb7702424 in __kernel_vsyscall ()
  #1  0xb7658e61 in __lll_lock_wait_private () from ./lib/libc.so.6
  #2  0xb767e7b5 in _L_lock_15 () from ./lib/libc.so.6
  #3  0xb767e6e0 in utmpname () from ./lib/libc.so.6
  #4  0xb76bcde7 in logout () from ./lib/libutil.so.1
  #5  0x0804c827 in cleanup ()
  #6  <signal handler called>
  #7  0xb7702424 in __kernel_vsyscall ()
  #8  0xb7641003 in __fcntl_nocancel () from ./lib/libc.so.6
  #9  0xb767e0c3 in getutline_r_file () from ./lib/libc.so.6
  #10 0xb767d675 in getutline_r () from ./lib/libc.so.6
  #11 0xb76bce42 in logout () from ./lib/libutil.so.1
  #12 0x0804c827 in cleanup ()
  #13 0x0804a0b5 in telnet ()
  #14 0x0804a9c3 in main ()

and what has happened here is that the user closes the telnet session
via the escape character. This causes telnetd to call cleanup in frame
the SIGCHLD signal is delivered while telnetd is executing cleanup.

Telnetd then calls the signal handler for SIGCHLD, which is cleanup().
Ouch. The actual deadlock is in libc. getutline_r in frame #10 gets the
__libc_utmp_lock lock, and utmpname above does the same thing in frame

The fix registers the SIGCHLD handler as cleanup_sighandler, and makes
cleanup disable the SIGCHLD signal before calling cleanup_sighandler.

Signed-off-by: Simon Kagstrom <simon.kagstrom@netinsight.net>
Signed-off-by: Li Wang <li.wang@windriver.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
philb pushed a commit that referenced this issue Jul 15, 2015
the patch comes from:
https://bugs.launchpad.net/ubuntu/+source/netkit-telnet/+bug/507455
https://launchpadlibrarian.net/37882973/0001-telnetd-Fix-deadlock-on-cleanup.patch

The cleanup function in telnetd is called both directly and on SIGCHLD
signals. This, unfortunately, triggered a deadlock in eglibc 2.9 while
running on a 2.6.31.11 kernel.

What we were seeing is hangs like these:

  (gdb) bt
  #0  0xb7702424 in __kernel_vsyscall ()
  #1  0xb7658e61 in __lll_lock_wait_private () from ./lib/libc.so.6
  #2  0xb767e7b5 in _L_lock_15 () from ./lib/libc.so.6
  #3  0xb767e6e0 in utmpname () from ./lib/libc.so.6
  #4  0xb76bcde7 in logout () from ./lib/libutil.so.1
  #5  0x0804c827 in cleanup ()
  #6  <signal handler called>
  #7  0xb7702424 in __kernel_vsyscall ()
  #8  0xb7641003 in __fcntl_nocancel () from ./lib/libc.so.6
  #9  0xb767e0c3 in getutline_r_file () from ./lib/libc.so.6
  #10 0xb767d675 in getutline_r () from ./lib/libc.so.6
  #11 0xb76bce42 in logout () from ./lib/libutil.so.1
  #12 0x0804c827 in cleanup ()
  #13 0x0804a0b5 in telnet ()
  #14 0x0804a9c3 in main ()

and what has happened here is that the user closes the telnet session
via the escape character. This causes telnetd to call cleanup in frame
the SIGCHLD signal is delivered while telnetd is executing cleanup.

Telnetd then calls the signal handler for SIGCHLD, which is cleanup().
Ouch. The actual deadlock is in libc. getutline_r in frame #10 gets the
__libc_utmp_lock lock, and utmpname above does the same thing in frame

The fix registers the SIGCHLD handler as cleanup_sighandler, and makes
cleanup disable the SIGCHLD signal before calling cleanup_sighandler.

Signed-off-by: Simon Kagstrom <simon.kagstrom@netinsight.net>
Signed-off-by: Li Wang <li.wang@windriver.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
philb pushed a commit that referenced this issue Jul 16, 2015
the patch comes from:
https://bugs.launchpad.net/ubuntu/+source/netkit-telnet/+bug/507455
https://launchpadlibrarian.net/37882973/0001-telnetd-Fix-deadlock-on-cleanup.patch

The cleanup function in telnetd is called both directly and on SIGCHLD
signals. This, unfortunately, triggered a deadlock in eglibc 2.9 while
running on a 2.6.31.11 kernel.

What we were seeing is hangs like these:

  (gdb) bt
  #0  0xb7702424 in __kernel_vsyscall ()
  #1  0xb7658e61 in __lll_lock_wait_private () from ./lib/libc.so.6
  #2  0xb767e7b5 in _L_lock_15 () from ./lib/libc.so.6
  #3  0xb767e6e0 in utmpname () from ./lib/libc.so.6
  #4  0xb76bcde7 in logout () from ./lib/libutil.so.1
  #5  0x0804c827 in cleanup ()
  #6  <signal handler called>
  #7  0xb7702424 in __kernel_vsyscall ()
  #8  0xb7641003 in __fcntl_nocancel () from ./lib/libc.so.6
  #9  0xb767e0c3 in getutline_r_file () from ./lib/libc.so.6
  #10 0xb767d675 in getutline_r () from ./lib/libc.so.6
  #11 0xb76bce42 in logout () from ./lib/libutil.so.1
  #12 0x0804c827 in cleanup ()
  #13 0x0804a0b5 in telnet ()
  #14 0x0804a9c3 in main ()

and what has happened here is that the user closes the telnet session
via the escape character. This causes telnetd to call cleanup in frame
the SIGCHLD signal is delivered while telnetd is executing cleanup.

Telnetd then calls the signal handler for SIGCHLD, which is cleanup().
Ouch. The actual deadlock is in libc. getutline_r in frame #10 gets the
__libc_utmp_lock lock, and utmpname above does the same thing in frame

The fix registers the SIGCHLD handler as cleanup_sighandler, and makes
cleanup disable the SIGCHLD signal before calling cleanup_sighandler.

Signed-off-by: Simon Kagstrom <simon.kagstrom@netinsight.net>
Signed-off-by: Li Wang <li.wang@windriver.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
philb pushed a commit that referenced this issue Jul 27, 2015
the patch comes from:
https://bugs.launchpad.net/ubuntu/+source/netkit-telnet/+bug/507455
https://launchpadlibrarian.net/37882973/0001-telnetd-Fix-deadlock-on-cleanup.patch

The cleanup function in telnetd is called both directly and on SIGCHLD
signals. This, unfortunately, triggered a deadlock in eglibc 2.9 while
running on a 2.6.31.11 kernel.

What we were seeing is hangs like these:

  (gdb) bt
  #0  0xb7702424 in __kernel_vsyscall ()
  #1  0xb7658e61 in __lll_lock_wait_private () from ./lib/libc.so.6
  #2  0xb767e7b5 in _L_lock_15 () from ./lib/libc.so.6
  #3  0xb767e6e0 in utmpname () from ./lib/libc.so.6
  #4  0xb76bcde7 in logout () from ./lib/libutil.so.1
  #5  0x0804c827 in cleanup ()
  #6  <signal handler called>
  #7  0xb7702424 in __kernel_vsyscall ()
  #8  0xb7641003 in __fcntl_nocancel () from ./lib/libc.so.6
  #9  0xb767e0c3 in getutline_r_file () from ./lib/libc.so.6
  #10 0xb767d675 in getutline_r () from ./lib/libc.so.6
  #11 0xb76bce42 in logout () from ./lib/libutil.so.1
  #12 0x0804c827 in cleanup ()
  #13 0x0804a0b5 in telnet ()
  #14 0x0804a9c3 in main ()

and what has happened here is that the user closes the telnet session
via the escape character. This causes telnetd to call cleanup in frame
the SIGCHLD signal is delivered while telnetd is executing cleanup.

Telnetd then calls the signal handler for SIGCHLD, which is cleanup().
Ouch. The actual deadlock is in libc. getutline_r in frame #10 gets the
__libc_utmp_lock lock, and utmpname above does the same thing in frame

The fix registers the SIGCHLD handler as cleanup_sighandler, and makes
cleanup disable the SIGCHLD signal before calling cleanup_sighandler.

Signed-off-by: Simon Kagstrom <simon.kagstrom@netinsight.net>
Signed-off-by: Li Wang <li.wang@windriver.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
philb pushed a commit that referenced this issue Jul 29, 2015
the patch comes from:
https://bugs.launchpad.net/ubuntu/+source/netkit-telnet/+bug/507455
https://launchpadlibrarian.net/37882973/0001-telnetd-Fix-deadlock-on-cleanup.patch

The cleanup function in telnetd is called both directly and on SIGCHLD
signals. This, unfortunately, triggered a deadlock in eglibc 2.9 while
running on a 2.6.31.11 kernel.

What we were seeing is hangs like these:

  (gdb) bt
  #0  0xb7702424 in __kernel_vsyscall ()
  #1  0xb7658e61 in __lll_lock_wait_private () from ./lib/libc.so.6
  #2  0xb767e7b5 in _L_lock_15 () from ./lib/libc.so.6
  #3  0xb767e6e0 in utmpname () from ./lib/libc.so.6
  #4  0xb76bcde7 in logout () from ./lib/libutil.so.1
  #5  0x0804c827 in cleanup ()
  #6  <signal handler called>
  #7  0xb7702424 in __kernel_vsyscall ()
  #8  0xb7641003 in __fcntl_nocancel () from ./lib/libc.so.6
  #9  0xb767e0c3 in getutline_r_file () from ./lib/libc.so.6
  #10 0xb767d675 in getutline_r () from ./lib/libc.so.6
  #11 0xb76bce42 in logout () from ./lib/libutil.so.1
  #12 0x0804c827 in cleanup ()
  #13 0x0804a0b5 in telnet ()
  #14 0x0804a9c3 in main ()

and what has happened here is that the user closes the telnet session
via the escape character. This causes telnetd to call cleanup in frame
the SIGCHLD signal is delivered while telnetd is executing cleanup.

Telnetd then calls the signal handler for SIGCHLD, which is cleanup().
Ouch. The actual deadlock is in libc. getutline_r in frame #10 gets the
__libc_utmp_lock lock, and utmpname above does the same thing in frame

The fix registers the SIGCHLD handler as cleanup_sighandler, and makes
cleanup disable the SIGCHLD signal before calling cleanup_sighandler.

Signed-off-by: Simon Kagstrom <simon.kagstrom@netinsight.net>
Signed-off-by: Li Wang <li.wang@windriver.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
philb pushed a commit that referenced this issue Jul 30, 2015
the patch comes from:
https://bugs.launchpad.net/ubuntu/+source/netkit-telnet/+bug/507455
https://launchpadlibrarian.net/37882973/0001-telnetd-Fix-deadlock-on-cleanup.patch

The cleanup function in telnetd is called both directly and on SIGCHLD
signals. This, unfortunately, triggered a deadlock in eglibc 2.9 while
running on a 2.6.31.11 kernel.

What we were seeing is hangs like these:

  (gdb) bt
  #0  0xb7702424 in __kernel_vsyscall ()
  #1  0xb7658e61 in __lll_lock_wait_private () from ./lib/libc.so.6
  #2  0xb767e7b5 in _L_lock_15 () from ./lib/libc.so.6
  #3  0xb767e6e0 in utmpname () from ./lib/libc.so.6
  #4  0xb76bcde7 in logout () from ./lib/libutil.so.1
  #5  0x0804c827 in cleanup ()
  #6  <signal handler called>
  #7  0xb7702424 in __kernel_vsyscall ()
  #8  0xb7641003 in __fcntl_nocancel () from ./lib/libc.so.6
  #9  0xb767e0c3 in getutline_r_file () from ./lib/libc.so.6
  #10 0xb767d675 in getutline_r () from ./lib/libc.so.6
  #11 0xb76bce42 in logout () from ./lib/libutil.so.1
  #12 0x0804c827 in cleanup ()
  #13 0x0804a0b5 in telnet ()
  #14 0x0804a9c3 in main ()

and what has happened here is that the user closes the telnet session
via the escape character. This causes telnetd to call cleanup in frame
the SIGCHLD signal is delivered while telnetd is executing cleanup.

Telnetd then calls the signal handler for SIGCHLD, which is cleanup().
Ouch. The actual deadlock is in libc. getutline_r in frame #10 gets the
__libc_utmp_lock lock, and utmpname above does the same thing in frame

The fix registers the SIGCHLD handler as cleanup_sighandler, and makes
cleanup disable the SIGCHLD signal before calling cleanup_sighandler.

Signed-off-by: Simon Kagstrom <simon.kagstrom@netinsight.net>
Signed-off-by: Li Wang <li.wang@windriver.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
philb pushed a commit that referenced this issue Jul 31, 2015
The bluetooth.service runs bluetoothd to manage bluetooth devices, if
present, in the system.  By design, it should be running in either of
two cases:
1. A userspace utility (e.g. networkmanager) has made a dbus request
   for bluetooth services provided by org.bluez.  Even without this
   patch, the bluetooth.service gets run via dbus activation under the
   systmed aliased name 'dbus-org-bluez.service'. Perfect!
2. A bluetooth device is added to the system.  When a bluetooth device
   is added, udev triggers the special systemd target, bluetooth.target
   intended to pull in any services needed for bluetooth linked under
   bluetooth.target.wants.

Enable bluetooth.service so it gets linked under bluetooth.target.wants
and bluetoothd gets started when a user adds a bluetooth device to the
system.

To be clear, this isn't forcing bluetooth to be running all the time---
only when either of #1 or #2 are true.

Signed-off-by: Ash Charles <ashcharles@gmail.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
philb pushed a commit that referenced this issue Aug 3, 2015
the patch comes from:
https://bugs.launchpad.net/ubuntu/+source/netkit-telnet/+bug/507455
https://launchpadlibrarian.net/37882973/0001-telnetd-Fix-deadlock-on-cleanup.patch

The cleanup function in telnetd is called both directly and on SIGCHLD
signals. This, unfortunately, triggered a deadlock in eglibc 2.9 while
running on a 2.6.31.11 kernel.

What we were seeing is hangs like these:

  (gdb) bt
  #0  0xb7702424 in __kernel_vsyscall ()
  #1  0xb7658e61 in __lll_lock_wait_private () from ./lib/libc.so.6
  #2  0xb767e7b5 in _L_lock_15 () from ./lib/libc.so.6
  #3  0xb767e6e0 in utmpname () from ./lib/libc.so.6
  #4  0xb76bcde7 in logout () from ./lib/libutil.so.1
  #5  0x0804c827 in cleanup ()
  #6  <signal handler called>
  #7  0xb7702424 in __kernel_vsyscall ()
  #8  0xb7641003 in __fcntl_nocancel () from ./lib/libc.so.6
  #9  0xb767e0c3 in getutline_r_file () from ./lib/libc.so.6
  #10 0xb767d675 in getutline_r () from ./lib/libc.so.6
  #11 0xb76bce42 in logout () from ./lib/libutil.so.1
  #12 0x0804c827 in cleanup ()
  #13 0x0804a0b5 in telnet ()
  #14 0x0804a9c3 in main ()

and what has happened here is that the user closes the telnet session
via the escape character. This causes telnetd to call cleanup in frame
the SIGCHLD signal is delivered while telnetd is executing cleanup.

Telnetd then calls the signal handler for SIGCHLD, which is cleanup().
Ouch. The actual deadlock is in libc. getutline_r in frame #10 gets the
__libc_utmp_lock lock, and utmpname above does the same thing in frame

The fix registers the SIGCHLD handler as cleanup_sighandler, and makes
cleanup disable the SIGCHLD signal before calling cleanup_sighandler.

Signed-off-by: Simon Kagstrom <simon.kagstrom@netinsight.net>
Signed-off-by: Li Wang <li.wang@windriver.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
philb pushed a commit that referenced this issue Aug 3, 2015
The bluetooth.service runs bluetoothd to manage bluetooth devices, if
present, in the system.  By design, it should be running in either of
two cases:
1. A userspace utility (e.g. networkmanager) has made a dbus request
   for bluetooth services provided by org.bluez.  Even without this
   patch, the bluetooth.service gets run via dbus activation under the
   systmed aliased name 'dbus-org-bluez.service'. Perfect!
2. A bluetooth device is added to the system.  When a bluetooth device
   is added, udev triggers the special systemd target, bluetooth.target
   intended to pull in any services needed for bluetooth linked under
   bluetooth.target.wants.

Enable bluetooth.service so it gets linked under bluetooth.target.wants
and bluetoothd gets started when a user adds a bluetooth device to the
system.

To be clear, this isn't forcing bluetooth to be running all the time---
only when either of #1 or #2 are true.

Signed-off-by: Ash Charles <ashcharles@gmail.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
philb pushed a commit that referenced this issue Aug 17, 2015
the patch comes from:
https://bugs.launchpad.net/ubuntu/+source/netkit-telnet/+bug/507455
https://launchpadlibrarian.net/37882973/0001-telnetd-Fix-deadlock-on-cleanup.patch

The cleanup function in telnetd is called both directly and on SIGCHLD
signals. This, unfortunately, triggered a deadlock in eglibc 2.9 while
running on a 2.6.31.11 kernel.

What we were seeing is hangs like these:

  (gdb) bt
  #0  0xb7702424 in __kernel_vsyscall ()
  #1  0xb7658e61 in __lll_lock_wait_private () from ./lib/libc.so.6
  #2  0xb767e7b5 in _L_lock_15 () from ./lib/libc.so.6
  #3  0xb767e6e0 in utmpname () from ./lib/libc.so.6
  #4  0xb76bcde7 in logout () from ./lib/libutil.so.1
  #5  0x0804c827 in cleanup ()
  #6  <signal handler called>
  #7  0xb7702424 in __kernel_vsyscall ()
  #8  0xb7641003 in __fcntl_nocancel () from ./lib/libc.so.6
  #9  0xb767e0c3 in getutline_r_file () from ./lib/libc.so.6
  #10 0xb767d675 in getutline_r () from ./lib/libc.so.6
  #11 0xb76bce42 in logout () from ./lib/libutil.so.1
  #12 0x0804c827 in cleanup ()
  #13 0x0804a0b5 in telnet ()
  #14 0x0804a9c3 in main ()

and what has happened here is that the user closes the telnet session
via the escape character. This causes telnetd to call cleanup in frame
the SIGCHLD signal is delivered while telnetd is executing cleanup.

Telnetd then calls the signal handler for SIGCHLD, which is cleanup().
Ouch. The actual deadlock is in libc. getutline_r in frame #10 gets the
__libc_utmp_lock lock, and utmpname above does the same thing in frame

The fix registers the SIGCHLD handler as cleanup_sighandler, and makes
cleanup disable the SIGCHLD signal before calling cleanup_sighandler.

Signed-off-by: Simon Kagstrom <simon.kagstrom@netinsight.net>
Signed-off-by: Li Wang <li.wang@windriver.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
philb pushed a commit that referenced this issue Aug 17, 2015
The bluetooth.service runs bluetoothd to manage bluetooth devices, if
present, in the system.  By design, it should be running in either of
two cases:
1. A userspace utility (e.g. networkmanager) has made a dbus request
   for bluetooth services provided by org.bluez.  Even without this
   patch, the bluetooth.service gets run via dbus activation under the
   systmed aliased name 'dbus-org-bluez.service'. Perfect!
2. A bluetooth device is added to the system.  When a bluetooth device
   is added, udev triggers the special systemd target, bluetooth.target
   intended to pull in any services needed for bluetooth linked under
   bluetooth.target.wants.

Enable bluetooth.service so it gets linked under bluetooth.target.wants
and bluetoothd gets started when a user adds a bluetooth device to the
system.

To be clear, this isn't forcing bluetooth to be running all the time---
only when either of #1 or #2 are true.

Signed-off-by: Ash Charles <ashcharles@gmail.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
philb pushed a commit that referenced this issue Aug 18, 2015
The bluetooth.service runs bluetoothd to manage bluetooth devices, if
present, in the system.  By design, it should be running in either of
two cases:
1. A userspace utility (e.g. networkmanager) has made a dbus request
   for bluetooth services provided by org.bluez.  Even without this
   patch, the bluetooth.service gets run via dbus activation under the
   systmed aliased name 'dbus-org-bluez.service'. Perfect!
2. A bluetooth device is added to the system.  When a bluetooth device
   is added, udev triggers the special systemd target, bluetooth.target
   intended to pull in any services needed for bluetooth linked under
   bluetooth.target.wants.

Enable bluetooth.service so it gets linked under bluetooth.target.wants
and bluetoothd gets started when a user adds a bluetooth device to the
system.

To be clear, this isn't forcing bluetooth to be running all the time---
only when either of #1 or #2 are true.

Signed-off-by: Ash Charles <ashcharles@gmail.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
philb pushed a commit that referenced this issue Aug 18, 2015
the patch comes from:
https://bugs.launchpad.net/ubuntu/+source/netkit-telnet/+bug/507455
https://launchpadlibrarian.net/37882973/0001-telnetd-Fix-deadlock-on-cleanup.patch

The cleanup function in telnetd is called both directly and on SIGCHLD
signals. This, unfortunately, triggered a deadlock in eglibc 2.9 while
running on a 2.6.31.11 kernel.

What we were seeing is hangs like these:

  (gdb) bt
  #0  0xb7702424 in __kernel_vsyscall ()
  #1  0xb7658e61 in __lll_lock_wait_private () from ./lib/libc.so.6
  #2  0xb767e7b5 in _L_lock_15 () from ./lib/libc.so.6
  #3  0xb767e6e0 in utmpname () from ./lib/libc.so.6
  #4  0xb76bcde7 in logout () from ./lib/libutil.so.1
  #5  0x0804c827 in cleanup ()
  #6  <signal handler called>
  #7  0xb7702424 in __kernel_vsyscall ()
  #8  0xb7641003 in __fcntl_nocancel () from ./lib/libc.so.6
  #9  0xb767e0c3 in getutline_r_file () from ./lib/libc.so.6
  #10 0xb767d675 in getutline_r () from ./lib/libc.so.6
  #11 0xb76bce42 in logout () from ./lib/libutil.so.1
  #12 0x0804c827 in cleanup ()
  #13 0x0804a0b5 in telnet ()
  #14 0x0804a9c3 in main ()

and what has happened here is that the user closes the telnet session
via the escape character. This causes telnetd to call cleanup in frame
the SIGCHLD signal is delivered while telnetd is executing cleanup.

Telnetd then calls the signal handler for SIGCHLD, which is cleanup().
Ouch. The actual deadlock is in libc. getutline_r in frame #10 gets the
__libc_utmp_lock lock, and utmpname above does the same thing in frame

The fix registers the SIGCHLD handler as cleanup_sighandler, and makes
cleanup disable the SIGCHLD signal before calling cleanup_sighandler.

Signed-off-by: Simon Kagstrom <simon.kagstrom@netinsight.net>
Signed-off-by: Li Wang <li.wang@windriver.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
philb pushed a commit that referenced this issue Aug 18, 2015
the patch comes from:
https://bugs.launchpad.net/ubuntu/+source/netkit-telnet/+bug/507455
https://launchpadlibrarian.net/37882973/0001-telnetd-Fix-deadlock-on-cleanup.patch

The cleanup function in telnetd is called both directly and on SIGCHLD
signals. This, unfortunately, triggered a deadlock in eglibc 2.9 while
running on a 2.6.31.11 kernel.

What we were seeing is hangs like these:

  (gdb) bt
  #0  0xb7702424 in __kernel_vsyscall ()
  #1  0xb7658e61 in __lll_lock_wait_private () from ./lib/libc.so.6
  #2  0xb767e7b5 in _L_lock_15 () from ./lib/libc.so.6
  #3  0xb767e6e0 in utmpname () from ./lib/libc.so.6
  #4  0xb76bcde7 in logout () from ./lib/libutil.so.1
  #5  0x0804c827 in cleanup ()
  #6  <signal handler called>
  #7  0xb7702424 in __kernel_vsyscall ()
  #8  0xb7641003 in __fcntl_nocancel () from ./lib/libc.so.6
  #9  0xb767e0c3 in getutline_r_file () from ./lib/libc.so.6
  #10 0xb767d675 in getutline_r () from ./lib/libc.so.6
  #11 0xb76bce42 in logout () from ./lib/libutil.so.1
  #12 0x0804c827 in cleanup ()
  #13 0x0804a0b5 in telnet ()
  #14 0x0804a9c3 in main ()

and what has happened here is that the user closes the telnet session
via the escape character. This causes telnetd to call cleanup in frame
the SIGCHLD signal is delivered while telnetd is executing cleanup.

Telnetd then calls the signal handler for SIGCHLD, which is cleanup().
Ouch. The actual deadlock is in libc. getutline_r in frame #10 gets the
__libc_utmp_lock lock, and utmpname above does the same thing in frame

The fix registers the SIGCHLD handler as cleanup_sighandler, and makes
cleanup disable the SIGCHLD signal before calling cleanup_sighandler.

Signed-off-by: Simon Kagstrom <simon.kagstrom@netinsight.net>
Signed-off-by: Li Wang <li.wang@windriver.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
philb pushed a commit that referenced this issue Aug 20, 2015
the patch comes from:
https://bugs.launchpad.net/ubuntu/+source/netkit-telnet/+bug/507455
https://launchpadlibrarian.net/37882973/0001-telnetd-Fix-deadlock-on-cleanup.patch

The cleanup function in telnetd is called both directly and on SIGCHLD
signals. This, unfortunately, triggered a deadlock in eglibc 2.9 while
running on a 2.6.31.11 kernel.

What we were seeing is hangs like these:

  (gdb) bt
  #0  0xb7702424 in __kernel_vsyscall ()
  #1  0xb7658e61 in __lll_lock_wait_private () from ./lib/libc.so.6
  #2  0xb767e7b5 in _L_lock_15 () from ./lib/libc.so.6
  #3  0xb767e6e0 in utmpname () from ./lib/libc.so.6
  #4  0xb76bcde7 in logout () from ./lib/libutil.so.1
  #5  0x0804c827 in cleanup ()
  #6  <signal handler called>
  #7  0xb7702424 in __kernel_vsyscall ()
  #8  0xb7641003 in __fcntl_nocancel () from ./lib/libc.so.6
  #9  0xb767e0c3 in getutline_r_file () from ./lib/libc.so.6
  #10 0xb767d675 in getutline_r () from ./lib/libc.so.6
  #11 0xb76bce42 in logout () from ./lib/libutil.so.1
  #12 0x0804c827 in cleanup ()
  #13 0x0804a0b5 in telnet ()
  #14 0x0804a9c3 in main ()

and what has happened here is that the user closes the telnet session
via the escape character. This causes telnetd to call cleanup in frame
the SIGCHLD signal is delivered while telnetd is executing cleanup.

Telnetd then calls the signal handler for SIGCHLD, which is cleanup().
Ouch. The actual deadlock is in libc. getutline_r in frame #10 gets the
__libc_utmp_lock lock, and utmpname above does the same thing in frame

The fix registers the SIGCHLD handler as cleanup_sighandler, and makes
cleanup disable the SIGCHLD signal before calling cleanup_sighandler.

Signed-off-by: Simon Kagstrom <simon.kagstrom@netinsight.net>
Signed-off-by: Li Wang <li.wang@windriver.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
philb pushed a commit that referenced this issue Aug 24, 2015
the patch comes from:
https://bugs.launchpad.net/ubuntu/+source/netkit-telnet/+bug/507455
https://launchpadlibrarian.net/37882973/0001-telnetd-Fix-deadlock-on-cleanup.patch

The cleanup function in telnetd is called both directly and on SIGCHLD
signals. This, unfortunately, triggered a deadlock in eglibc 2.9 while
running on a 2.6.31.11 kernel.

What we were seeing is hangs like these:

  (gdb) bt
  #0  0xb7702424 in __kernel_vsyscall ()
  #1  0xb7658e61 in __lll_lock_wait_private () from ./lib/libc.so.6
  #2  0xb767e7b5 in _L_lock_15 () from ./lib/libc.so.6
  #3  0xb767e6e0 in utmpname () from ./lib/libc.so.6
  #4  0xb76bcde7 in logout () from ./lib/libutil.so.1
  #5  0x0804c827 in cleanup ()
  #6  <signal handler called>
  #7  0xb7702424 in __kernel_vsyscall ()
  #8  0xb7641003 in __fcntl_nocancel () from ./lib/libc.so.6
  #9  0xb767e0c3 in getutline_r_file () from ./lib/libc.so.6
  #10 0xb767d675 in getutline_r () from ./lib/libc.so.6
  #11 0xb76bce42 in logout () from ./lib/libutil.so.1
  #12 0x0804c827 in cleanup ()
  #13 0x0804a0b5 in telnet ()
  #14 0x0804a9c3 in main ()

and what has happened here is that the user closes the telnet session
via the escape character. This causes telnetd to call cleanup in frame
the SIGCHLD signal is delivered while telnetd is executing cleanup.

Telnetd then calls the signal handler for SIGCHLD, which is cleanup().
Ouch. The actual deadlock is in libc. getutline_r in frame #10 gets the
__libc_utmp_lock lock, and utmpname above does the same thing in frame

The fix registers the SIGCHLD handler as cleanup_sighandler, and makes
cleanup disable the SIGCHLD signal before calling cleanup_sighandler.

Signed-off-by: Simon Kagstrom <simon.kagstrom@netinsight.net>
Signed-off-by: Li Wang <li.wang@windriver.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
philb pushed a commit that referenced this issue Aug 24, 2015
the patch comes from:
https://bugs.launchpad.net/ubuntu/+source/netkit-telnet/+bug/507455
https://launchpadlibrarian.net/37882973/0001-telnetd-Fix-deadlock-on-cleanup.patch

The cleanup function in telnetd is called both directly and on SIGCHLD
signals. This, unfortunately, triggered a deadlock in eglibc 2.9 while
running on a 2.6.31.11 kernel.

What we were seeing is hangs like these:

  (gdb) bt
  #0  0xb7702424 in __kernel_vsyscall ()
  #1  0xb7658e61 in __lll_lock_wait_private () from ./lib/libc.so.6
  #2  0xb767e7b5 in _L_lock_15 () from ./lib/libc.so.6
  #3  0xb767e6e0 in utmpname () from ./lib/libc.so.6
  #4  0xb76bcde7 in logout () from ./lib/libutil.so.1
  #5  0x0804c827 in cleanup ()
  #6  <signal handler called>
  #7  0xb7702424 in __kernel_vsyscall ()
  #8  0xb7641003 in __fcntl_nocancel () from ./lib/libc.so.6
  #9  0xb767e0c3 in getutline_r_file () from ./lib/libc.so.6
  #10 0xb767d675 in getutline_r () from ./lib/libc.so.6
  #11 0xb76bce42 in logout () from ./lib/libutil.so.1
  #12 0x0804c827 in cleanup ()
  #13 0x0804a0b5 in telnet ()
  #14 0x0804a9c3 in main ()

and what has happened here is that the user closes the telnet session
via the escape character. This causes telnetd to call cleanup in frame
the SIGCHLD signal is delivered while telnetd is executing cleanup.

Telnetd then calls the signal handler for SIGCHLD, which is cleanup().
Ouch. The actual deadlock is in libc. getutline_r in frame #10 gets the
__libc_utmp_lock lock, and utmpname above does the same thing in frame

The fix registers the SIGCHLD handler as cleanup_sighandler, and makes
cleanup disable the SIGCHLD signal before calling cleanup_sighandler.

Signed-off-by: Simon Kagstrom <simon.kagstrom@netinsight.net>
Signed-off-by: Li Wang <li.wang@windriver.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
philb pushed a commit that referenced this issue Aug 27, 2015
the patch comes from:
https://bugs.launchpad.net/ubuntu/+source/netkit-telnet/+bug/507455
https://launchpadlibrarian.net/37882973/0001-telnetd-Fix-deadlock-on-cleanup.patch

The cleanup function in telnetd is called both directly and on SIGCHLD
signals. This, unfortunately, triggered a deadlock in eglibc 2.9 while
running on a 2.6.31.11 kernel.

What we were seeing is hangs like these:

  (gdb) bt
  #0  0xb7702424 in __kernel_vsyscall ()
  #1  0xb7658e61 in __lll_lock_wait_private () from ./lib/libc.so.6
  #2  0xb767e7b5 in _L_lock_15 () from ./lib/libc.so.6
  #3  0xb767e6e0 in utmpname () from ./lib/libc.so.6
  #4  0xb76bcde7 in logout () from ./lib/libutil.so.1
  #5  0x0804c827 in cleanup ()
  #6  <signal handler called>
  #7  0xb7702424 in __kernel_vsyscall ()
  #8  0xb7641003 in __fcntl_nocancel () from ./lib/libc.so.6
  #9  0xb767e0c3 in getutline_r_file () from ./lib/libc.so.6
  #10 0xb767d675 in getutline_r () from ./lib/libc.so.6
  #11 0xb76bce42 in logout () from ./lib/libutil.so.1
  #12 0x0804c827 in cleanup ()
  #13 0x0804a0b5 in telnet ()
  #14 0x0804a9c3 in main ()

and what has happened here is that the user closes the telnet session
via the escape character. This causes telnetd to call cleanup in frame
the SIGCHLD signal is delivered while telnetd is executing cleanup.

Telnetd then calls the signal handler for SIGCHLD, which is cleanup().
Ouch. The actual deadlock is in libc. getutline_r in frame #10 gets the
__libc_utmp_lock lock, and utmpname above does the same thing in frame

The fix registers the SIGCHLD handler as cleanup_sighandler, and makes
cleanup disable the SIGCHLD signal before calling cleanup_sighandler.

Signed-off-by: Simon Kagstrom <simon.kagstrom@netinsight.net>
Signed-off-by: Li Wang <li.wang@windriver.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
philb pushed a commit that referenced this issue Aug 31, 2015
the patch comes from:
https://bugs.launchpad.net/ubuntu/+source/netkit-telnet/+bug/507455
https://launchpadlibrarian.net/37882973/0001-telnetd-Fix-deadlock-on-cleanup.patch

The cleanup function in telnetd is called both directly and on SIGCHLD
signals. This, unfortunately, triggered a deadlock in eglibc 2.9 while
running on a 2.6.31.11 kernel.

What we were seeing is hangs like these:

  (gdb) bt
  #0  0xb7702424 in __kernel_vsyscall ()
  #1  0xb7658e61 in __lll_lock_wait_private () from ./lib/libc.so.6
  #2  0xb767e7b5 in _L_lock_15 () from ./lib/libc.so.6
  #3  0xb767e6e0 in utmpname () from ./lib/libc.so.6
  #4  0xb76bcde7 in logout () from ./lib/libutil.so.1
  #5  0x0804c827 in cleanup ()
  #6  <signal handler called>
  #7  0xb7702424 in __kernel_vsyscall ()
  #8  0xb7641003 in __fcntl_nocancel () from ./lib/libc.so.6
  #9  0xb767e0c3 in getutline_r_file () from ./lib/libc.so.6
  #10 0xb767d675 in getutline_r () from ./lib/libc.so.6
  #11 0xb76bce42 in logout () from ./lib/libutil.so.1
  #12 0x0804c827 in cleanup ()
  #13 0x0804a0b5 in telnet ()
  #14 0x0804a9c3 in main ()

and what has happened here is that the user closes the telnet session
via the escape character. This causes telnetd to call cleanup in frame
the SIGCHLD signal is delivered while telnetd is executing cleanup.

Telnetd then calls the signal handler for SIGCHLD, which is cleanup().
Ouch. The actual deadlock is in libc. getutline_r in frame #10 gets the
__libc_utmp_lock lock, and utmpname above does the same thing in frame

The fix registers the SIGCHLD handler as cleanup_sighandler, and makes
cleanup disable the SIGCHLD signal before calling cleanup_sighandler.

Signed-off-by: Simon Kagstrom <simon.kagstrom@netinsight.net>
Signed-off-by: Li Wang <li.wang@windriver.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
philb pushed a commit that referenced this issue Sep 14, 2015
the patch comes from:
https://bugs.launchpad.net/ubuntu/+source/netkit-telnet/+bug/507455
https://launchpadlibrarian.net/37882973/0001-telnetd-Fix-deadlock-on-cleanup.patch

The cleanup function in telnetd is called both directly and on SIGCHLD
signals. This, unfortunately, triggered a deadlock in eglibc 2.9 while
running on a 2.6.31.11 kernel.

What we were seeing is hangs like these:

  (gdb) bt
  #0  0xb7702424 in __kernel_vsyscall ()
  #1  0xb7658e61 in __lll_lock_wait_private () from ./lib/libc.so.6
  #2  0xb767e7b5 in _L_lock_15 () from ./lib/libc.so.6
  #3  0xb767e6e0 in utmpname () from ./lib/libc.so.6
  #4  0xb76bcde7 in logout () from ./lib/libutil.so.1
  #5  0x0804c827 in cleanup ()
  #6  <signal handler called>
  #7  0xb7702424 in __kernel_vsyscall ()
  #8  0xb7641003 in __fcntl_nocancel () from ./lib/libc.so.6
  #9  0xb767e0c3 in getutline_r_file () from ./lib/libc.so.6
  #10 0xb767d675 in getutline_r () from ./lib/libc.so.6
  #11 0xb76bce42 in logout () from ./lib/libutil.so.1
  #12 0x0804c827 in cleanup ()
  #13 0x0804a0b5 in telnet ()
  #14 0x0804a9c3 in main ()

and what has happened here is that the user closes the telnet session
via the escape character. This causes telnetd to call cleanup in frame
the SIGCHLD signal is delivered while telnetd is executing cleanup.

Telnetd then calls the signal handler for SIGCHLD, which is cleanup().
Ouch. The actual deadlock is in libc. getutline_r in frame #10 gets the
__libc_utmp_lock lock, and utmpname above does the same thing in frame

The fix registers the SIGCHLD handler as cleanup_sighandler, and makes
cleanup disable the SIGCHLD signal before calling cleanup_sighandler.

Signed-off-by: Simon Kagstrom <simon.kagstrom@netinsight.net>
Signed-off-by: Li Wang <li.wang@windriver.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
@shr-project
Copy link
Contributor

If the issue is still valid, then send a patch to openembedded-devel@lists.openembedded.org

halstead pushed a commit that referenced this issue Apr 9, 2018
Fix QA warning:

WARNING: python-m2crypto-native-0.26.4-r0 do_patch:
Some of the context lines in patches were ignored. This can lead to
incorrectly applied patches.
The context lines in the patches can be updated with devtool:

    devtool modify <recipe>
    devtool finish --force-patch-refresh <recipe> <layer_path>

Then the updated patches and the source tree (in devtool's workspace)
should be reviewed to make sure the patches apply in the correct place
and don't introduce duplicate lines (which can, and does happen
when some of the context is ignored). Further information:
http://lists.openembedded.org/pipermail/openembedded-core/2018-March/148675.html
https://bugzilla.yoctoproject.org/show_bug.cgi?id=10450
Details:
Applying patch
0001-setup.py-link-in-sysroot-not-in-host-directories.patch
patching file setup.py
Hunk #1 succeeded at 127 with fuzz 1 (offset 65 lines).
Hunk #2 succeeded at 143 (offset 68 lines).

Now at patch 0001-setup.py-link-in-sysroot-not-in-host-directories.patch

Signed-off-by: Yi Zhao <yi.zhao@windriver.com>
Signed-off-by: Armin Kuster <akuster808@gmail.com>
halstead pushed a commit that referenced this issue Apr 9, 2018
WARNING: pidgin-2.12.0-r0 do_patch:
Some of the context lines in patches were ignored. This can lead to
incorrectly applied patches.
The context lines in the patches can be updated with devtool:

    devtool modify <recipe>
    devtool finish --force-patch-refresh <recipe> <layer_path>

Then the updated patches and the source tree (in devtool's workspace)
should be reviewed to make sure the patches apply in the correct place
and don't introduce duplicate lines (which can, and does happen
when some of the context is ignored). Further information:
http://lists.openembedded.org/pipermail/openembedded-core/2018-March/148675.html
https://bugzilla.yoctoproject.org/show_bug.cgi?id=10450
Details:
Applying patch sanitize-configure.ac.patch
patching file configure.ac
Hunk #1 succeeded at 642 with fuzz 1 (offset 170 lines).
Hunk #2 succeeded at 2397 (offset 537 lines).
Hunk #3 succeeded at 2429 (offset 537 lines).

Now at patch sanitize-configure.ac.patch

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Armin Kuster <akuster808@gmail.com>
halstead pushed a commit that referenced this issue Apr 9, 2018
Fix QA warning:

WARNING: python-m2crypto-native-0.26.4-r0 do_patch:
Some of the context lines in patches were ignored. This can lead to
incorrectly applied patches.
The context lines in the patches can be updated with devtool:

    devtool modify <recipe>
    devtool finish --force-patch-refresh <recipe> <layer_path>

Then the updated patches and the source tree (in devtool's workspace)
should be reviewed to make sure the patches apply in the correct place
and don't introduce duplicate lines (which can, and does happen
when some of the context is ignored). Further information:
http://lists.openembedded.org/pipermail/openembedded-core/2018-March/148675.html
https://bugzilla.yoctoproject.org/show_bug.cgi?id=10450
Details:
Applying patch
0001-setup.py-link-in-sysroot-not-in-host-directories.patch
patching file setup.py
Hunk #1 succeeded at 127 with fuzz 1 (offset 65 lines).
Hunk #2 succeeded at 143 (offset 68 lines).

Now at patch 0001-setup.py-link-in-sysroot-not-in-host-directories.patch

Signed-off-by: Yi Zhao <yi.zhao@windriver.com>
Signed-off-by: Armin Kuster <akuster808@gmail.com>
halstead pushed a commit that referenced this issue Apr 9, 2018
WARNING: pidgin-2.12.0-r0 do_patch:
Some of the context lines in patches were ignored. This can lead to
incorrectly applied patches.
The context lines in the patches can be updated with devtool:

    devtool modify <recipe>
    devtool finish --force-patch-refresh <recipe> <layer_path>

Then the updated patches and the source tree (in devtool's workspace)
should be reviewed to make sure the patches apply in the correct place
and don't introduce duplicate lines (which can, and does happen
when some of the context is ignored). Further information:
http://lists.openembedded.org/pipermail/openembedded-core/2018-March/148675.html
https://bugzilla.yoctoproject.org/show_bug.cgi?id=10450
Details:
Applying patch sanitize-configure.ac.patch
patching file configure.ac
Hunk #1 succeeded at 642 with fuzz 1 (offset 170 lines).
Hunk #2 succeeded at 2397 (offset 537 lines).
Hunk #3 succeeded at 2429 (offset 537 lines).

Now at patch sanitize-configure.ac.patch

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Armin Kuster <akuster808@gmail.com>
halstead pushed a commit that referenced this issue Apr 9, 2018
Fix QA warning:

WARNING: crda-3.18-r0 do_patch:
Some of the context lines in patches were ignored. This can lead to
incorrectly applied patches.
The context lines in the patches can be updated with devtool:

    devtool modify <recipe>
    devtool finish --force-patch-refresh <recipe> <layer_path>

Then the updated patches and the source tree (in devtool's workspace)
should be reviewed to make sure the patches apply in the correct place
and don't introduce duplicate lines (which can, and does happen
when some of the context is ignored). Further information:
http://lists.openembedded.org/pipermail/openembedded-core/2018-March/148675.html
https://bugzilla.yoctoproject.org/show_bug.cgi?id=10450
Details:
Applying patch fix-linking-of-libraries-used-by-reglib.patch
patching file Makefile
Hunk #2 succeeded at 40 with fuzz 2.
Hunk #3 succeeded at 46 (offset -5 lines).
Hunk #4 succeeded at 116 (offset -5 lines).

Now at patch fix-linking-of-libraries-used-by-reglib.patch

Signed-off-by: Yi Zhao <yi.zhao@windriver.com>
Signed-off-by: Armin Kuster <akuster808@gmail.com>
schnitzeltony added a commit to schnitzeltony/meta-openembedded that referenced this issue Feb 8, 2021
Release notes for 0.5.2
=======================
- New Features:
  - Add a "Viewer Mode" toggle (openembedded#50, !72)
  - Improve `--quit` option: close all windows interactively (!71)
  - Improve encoding management (openembedded#42, !69)
    - Display the current encoding in the status bar
    - Make the default encoding configurable via GSettings
    - Allow to choose encoding in the "Open" and "Save As" dialogs (openembedded#42)
    - Add a command line option to choose encoding
  - Add a "Delete Line" action (openembedded#13, !66)
  - Make automatic addition of the last EOL character configurable (openembedded#53,!65)
  - Switch to GFile for I/O operations (openembedded#4, openembedded#27, openembedded#75, !64)
    - Add file monitoring (openembedded#75)
    - Add a setting to create a tilde-backup file when saving (openembedded#27)
    - Make saving atomic (openembedded#4)

- Appearance Changes:
  - Filter files on mime type in the "Open" and "Save As" dialogs (openembedded#2, openembedded#35, !67)

- Code Refactoring:
  - Improve encoding management (openembedded#42, !69)
    - Make encoding dialog more generic and self-contained
    - Encodings definition review
    - Clarify encoding management when opening files
    - Improve unicode BOM management
  - Switch to GFile for I/O operations (openembedded#4, openembedded#27, openembedded#75, !64)
    - Set the save action sensitivity more precisely
    - Let GFile APIs check for file existence when reading
    - Let GFile APIs check for external modifications when saving
    - Basic switch to GFile for I/O operations

- Bug Fixes:
  - Make "replace" and "replace all" behaviors consistent (openembedded#94)
  - Ensure that the page setup is properly applied when printing (openembedded#90)
  - Avoid character escape issues in menu item action names (openembedded#91)
  - Properly initialize document search properties
  - Avoid illegal memory access when searching with tab changes (!73)
  - Revert to "Wrap Around" always true for the search bar (openembedded#83)
  - Prevent too late accesses to the buffer in selection mode
  - Direct call to keybinding signals for "Delete" and "Select All" (openembedded#83)
  - Improve editing keybindings consistency (openembedded#83)

- Translation Updates

Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this issue Feb 11, 2021
Release notes for 0.5.2
=======================
- New Features:
  - Add a "Viewer Mode" toggle (openembedded#50, !72)
  - Improve `--quit` option: close all windows interactively (!71)
  - Improve encoding management (openembedded#42, !69)
    - Display the current encoding in the status bar
    - Make the default encoding configurable via GSettings
    - Allow to choose encoding in the "Open" and "Save As" dialogs (openembedded#42)
    - Add a command line option to choose encoding
  - Add a "Delete Line" action (openembedded#13, !66)
  - Make automatic addition of the last EOL character configurable (openembedded#53,!65)
  - Switch to GFile for I/O operations (openembedded#4, openembedded#27, openembedded#75, !64)
    - Add file monitoring (openembedded#75)
    - Add a setting to create a tilde-backup file when saving (openembedded#27)
    - Make saving atomic (openembedded#4)

- Appearance Changes:
  - Filter files on mime type in the "Open" and "Save As" dialogs (openembedded#2, openembedded#35, !67)

- Code Refactoring:
  - Improve encoding management (openembedded#42, !69)
    - Make encoding dialog more generic and self-contained
    - Encodings definition review
    - Clarify encoding management when opening files
    - Improve unicode BOM management
  - Switch to GFile for I/O operations (openembedded#4, openembedded#27, openembedded#75, !64)
    - Set the save action sensitivity more precisely
    - Let GFile APIs check for file existence when reading
    - Let GFile APIs check for external modifications when saving
    - Basic switch to GFile for I/O operations

- Bug Fixes:
  - Make "replace" and "replace all" behaviors consistent (openembedded#94)
  - Ensure that the page setup is properly applied when printing (openembedded#90)
  - Avoid character escape issues in menu item action names (openembedded#91)
  - Properly initialize document search properties
  - Avoid illegal memory access when searching with tab changes (!73)
  - Revert to "Wrap Around" always true for the search bar (openembedded#83)
  - Prevent too late accesses to the buffer in selection mode
  - Direct call to keybinding signals for "Delete" and "Select All" (openembedded#83)
  - Improve editing keybindings consistency (openembedded#83)

- Translation Updates

Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this issue Feb 11, 2021
Release notes for 0.5.2
=======================
- New Features:
  - Add a "Viewer Mode" toggle (openembedded#50, !72)
  - Improve `--quit` option: close all windows interactively (!71)
  - Improve encoding management (openembedded#42, !69)
    - Display the current encoding in the status bar
    - Make the default encoding configurable via GSettings
    - Allow to choose encoding in the "Open" and "Save As" dialogs (openembedded#42)
    - Add a command line option to choose encoding
  - Add a "Delete Line" action (openembedded#13, !66)
  - Make automatic addition of the last EOL character configurable (openembedded#53,!65)
  - Switch to GFile for I/O operations (openembedded#4, openembedded#27, openembedded#75, !64)
    - Add file monitoring (openembedded#75)
    - Add a setting to create a tilde-backup file when saving (openembedded#27)
    - Make saving atomic (openembedded#4)

- Appearance Changes:
  - Filter files on mime type in the "Open" and "Save As" dialogs (openembedded#2, openembedded#35, !67)

- Code Refactoring:
  - Improve encoding management (openembedded#42, !69)
    - Make encoding dialog more generic and self-contained
    - Encodings definition review
    - Clarify encoding management when opening files
    - Improve unicode BOM management
  - Switch to GFile for I/O operations (openembedded#4, openembedded#27, openembedded#75, !64)
    - Set the save action sensitivity more precisely
    - Let GFile APIs check for file existence when reading
    - Let GFile APIs check for external modifications when saving
    - Basic switch to GFile for I/O operations

- Bug Fixes:
  - Make "replace" and "replace all" behaviors consistent (openembedded#94)
  - Ensure that the page setup is properly applied when printing (openembedded#90)
  - Avoid character escape issues in menu item action names (openembedded#91)
  - Properly initialize document search properties
  - Avoid illegal memory access when searching with tab changes (!73)
  - Revert to "Wrap Around" always true for the search bar (openembedded#83)
  - Prevent too late accesses to the buffer in selection mode
  - Direct call to keybinding signals for "Delete" and "Select All" (openembedded#83)
  - Improve editing keybindings consistency (openembedded#83)

- Translation Updates

Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this issue Feb 11, 2021
Release notes for 0.5.2
=======================
- New Features:
  - Add a "Viewer Mode" toggle (openembedded#50, !72)
  - Improve `--quit` option: close all windows interactively (!71)
  - Improve encoding management (openembedded#42, !69)
    - Display the current encoding in the status bar
    - Make the default encoding configurable via GSettings
    - Allow to choose encoding in the "Open" and "Save As" dialogs (openembedded#42)
    - Add a command line option to choose encoding
  - Add a "Delete Line" action (openembedded#13, !66)
  - Make automatic addition of the last EOL character configurable (openembedded#53,!65)
  - Switch to GFile for I/O operations (openembedded#4, openembedded#27, openembedded#75, !64)
    - Add file monitoring (openembedded#75)
    - Add a setting to create a tilde-backup file when saving (openembedded#27)
    - Make saving atomic (openembedded#4)

- Appearance Changes:
  - Filter files on mime type in the "Open" and "Save As" dialogs (openembedded#2, openembedded#35, !67)

- Code Refactoring:
  - Improve encoding management (openembedded#42, !69)
    - Make encoding dialog more generic and self-contained
    - Encodings definition review
    - Clarify encoding management when opening files
    - Improve unicode BOM management
  - Switch to GFile for I/O operations (openembedded#4, openembedded#27, openembedded#75, !64)
    - Set the save action sensitivity more precisely
    - Let GFile APIs check for file existence when reading
    - Let GFile APIs check for external modifications when saving
    - Basic switch to GFile for I/O operations

- Bug Fixes:
  - Make "replace" and "replace all" behaviors consistent (openembedded#94)
  - Ensure that the page setup is properly applied when printing (openembedded#90)
  - Avoid character escape issues in menu item action names (openembedded#91)
  - Properly initialize document search properties
  - Avoid illegal memory access when searching with tab changes (!73)
  - Revert to "Wrap Around" always true for the search bar (openembedded#83)
  - Prevent too late accesses to the buffer in selection mode
  - Direct call to keybinding signals for "Delete" and "Select All" (openembedded#83)
  - Improve editing keybindings consistency (openembedded#83)

- Translation Updates

Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
halstead pushed a commit that referenced this issue Apr 7, 2021
* fixes:
WARNING: opencv-4.1.0-r0 do_patch: Fuzz detected:

Applying patch CVE-2019-14491.patch
patching file modules/objdetect/src/cascadedetect.cpp
Hunk #1 succeeded at 46 with fuzz 1 (offset -1 lines).
Hunk #2 succeeded at 540 (offset -1 lines).
Hunk #3 succeeded at 552 (offset -1 lines).
Hunk #4 succeeded at 613 (offset -1 lines).
Hunk #5 succeeded at 774 (offset -1 lines).
Hunk #6 succeeded at 825 (offset -1 lines).
Hunk #7 succeeded at 1470 (offset -36 lines).
patching file modules/objdetect/src/cascadedetect.hpp

The context lines in the patches can be updated with devtool:

    devtool modify opencv
    devtool finish --force-patch-refresh opencv <layer_path>

Don't forget to review changes done by devtool!

WARNING: opencv-4.1.0-r0 do_patch: QA Issue: Patch log indicates that patches do not apply cleanly. [patch-fuzz]

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Armin Kuster <akuster808@gmail.com>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this issue Apr 7, 2021
Release notes for 0.5.2
=======================
A bugfix and translation update, a new icon, various cleanups.. thanks
to all contributors !

======
- Update TODO
- Refresh Glade file, drop unused tab labels (fixes openembedded#13)
- move the logic setting GtkSpin port value to setup_for_type() (openembedded#11)
- Use new icon in window titlebar
- Fix compilation warnings
- autoconf: Some updates
- Only show an error dialog if the host field is visible/required
- Remove capitalization from icon name
- Update GenericName (openembedded#2)
- Fix comment style.
- Remove GSourceFunc casts
- Update Makefile.am
- Add gigolo.ui to POTFILES.in (Issue openembedded#6)
- Added new icons following new style and reverse DNS format.
- Add new README.md and update AM_INIT_AUTOMAKE
- Add basic GitLab pipeline
- Bug #16717: Move from exo-csource to xdt-csource
- Translation Updates

Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
jpuhlman pushed a commit to MontaVista-OpenSourceTechnology/meta-openembedded that referenced this issue Apr 8, 2021
Source: meta-openembedded
MR: 108246
Type: Integration
Disposition: Merged from meta-openembedded
ChangeID: 637967e
Description:

* fixes:
WARNING: opencv-4.1.0-r0 do_patch: Fuzz detected:

Applying patch CVE-2019-14491.patch
patching file modules/objdetect/src/cascadedetect.cpp
Hunk openembedded#1 succeeded at 46 with fuzz 1 (offset -1 lines).
Hunk openembedded#2 succeeded at 540 (offset -1 lines).
Hunk openembedded#3 succeeded at 552 (offset -1 lines).
Hunk openembedded#4 succeeded at 613 (offset -1 lines).
Hunk openembedded#5 succeeded at 774 (offset -1 lines).
Hunk openembedded#6 succeeded at 825 (offset -1 lines).
Hunk openembedded#7 succeeded at 1470 (offset -36 lines).
patching file modules/objdetect/src/cascadedetect.hpp

The context lines in the patches can be updated with devtool:

    devtool modify opencv
    devtool finish --force-patch-refresh opencv <layer_path>

Don't forget to review changes done by devtool!

WARNING: opencv-4.1.0-r0 do_patch: QA Issue: Patch log indicates that patches do not apply cleanly. [patch-fuzz]

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Armin Kuster <akuster808@gmail.com>
Signed-off-by: Jeremy Puhlman <jpuhlman@mvista.com>
halstead pushed a commit that referenced this issue Apr 8, 2021
Release notes for 0.5.2
=======================
A bugfix and translation update, a new icon, various cleanups.. thanks
to all contributors !

======
- Update TODO
- Refresh Glade file, drop unused tab labels (fixes #13)
- move the logic setting GtkSpin port value to setup_for_type() (#11)
- Use new icon in window titlebar
- Fix compilation warnings
- autoconf: Some updates
- Only show an error dialog if the host field is visible/required
- Remove capitalization from icon name
- Update GenericName (#2)
- Fix comment style.
- Remove GSourceFunc casts
- Update Makefile.am
- Add gigolo.ui to POTFILES.in (Issue #6)
- Added new icons following new style and reverse DNS format.
- Add new README.md and update AM_INIT_AUTOMAKE
- Add basic GitLab pipeline
- Bug #16717: Move from exo-csource to xdt-csource
- Translation Updates

Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
halstead pushed a commit that referenced this issue Apr 10, 2021
Release notes for 0.5.2
=======================
A bugfix and translation update, a new icon, various cleanups.. thanks
to all contributors !

======
- Update TODO
- Refresh Glade file, drop unused tab labels (fixes #13)
- move the logic setting GtkSpin port value to setup_for_type() (#11)
- Use new icon in window titlebar
- Fix compilation warnings
- autoconf: Some updates
- Only show an error dialog if the host field is visible/required
- Remove capitalization from icon name
- Update GenericName (#2)
- Fix comment style.
- Remove GSourceFunc casts
- Update Makefile.am
- Add gigolo.ui to POTFILES.in (Issue #6)
- Added new icons following new style and reverse DNS format.
- Add new README.md and update AM_INIT_AUTOMAKE
- Add basic GitLab pipeline
- Bug #16717: Move from exo-csource to xdt-csource
- Translation Updates

Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
(cherry picked from commit e2add12)
Signed-off-by: Armin Kuster <akuster808@gmail.com>
halstead pushed a commit that referenced this issue Mar 27, 2022
Applying patch CVE-2021-22570.patch
patching file src/google/protobuf/descriptor.cc
Hunk #1 succeeded at 2603 with fuzz 1 (offset -23 lines).
Hunk #2 succeeded at 2817 with fuzz 1 (offset -14 lines).
Hunk #3 succeeded at 4006 (offset -17 lines).
Hunk #4 succeeded at 4050 (offset -18 lines).
Hunk #5 succeeded at 4368 (offset -18 lines).

Signed-off-by: Ross Burton <ross.burton@arm.com>
Signed-off-by: Armin Kuster <akuster808@gmail.com>
jpuhlman pushed a commit to MontaVista-OpenSourceTechnology/meta-openembedded that referenced this issue Mar 28, 2022
Source: meta-openembedded
MR: 115838
Type: Integration
Disposition: Merged from meta-openembedded
ChangeID: a14eb5e
Description:

Applying patch CVE-2021-22570.patch
patching file src/google/protobuf/descriptor.cc
Hunk openembedded#1 succeeded at 2603 with fuzz 1 (offset -23 lines).
Hunk openembedded#2 succeeded at 2817 with fuzz 1 (offset -14 lines).
Hunk openembedded#3 succeeded at 4006 (offset -17 lines).
Hunk openembedded#4 succeeded at 4050 (offset -18 lines).
Hunk openembedded#5 succeeded at 4368 (offset -18 lines).

Signed-off-by: Ross Burton <ross.burton@arm.com>
Signed-off-by: Armin Kuster <akuster808@gmail.com>
Signed-off-by: Jeremy A. Puhlman <jpuhlman@mvista.com>
gmarescotti pushed a commit to gmarescotti/meta-openembedded that referenced this issue Apr 13, 2022
gmarescotti pushed a commit to gmarescotti/meta-openembedded that referenced this issue Apr 14, 2022
halstead pushed a commit that referenced this issue May 26, 2022
Applying patch CVE-2021-22570.patch
patching file src/google/protobuf/descriptor.cc
Hunk #1 succeeded at 2603 with fuzz 1 (offset -23 lines).
Hunk #2 succeeded at 2817 with fuzz 1 (offset -14 lines).
Hunk #3 succeeded at 4006 (offset -17 lines).
Hunk #4 succeeded at 4050 (offset -18 lines).
Hunk #5 succeeded at 4368 (offset -18 lines).

Signed-off-by: Ross Burton <ross.burton@arm.com>
Signed-off-by: Armin Kuster <akuster808@gmail.com>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this issue May 27, 2022
Changelog:
==========
Added
------
    Support Python 3.11 (openembedded#13)
    Add Arabic language (jmoiron/humanize#256)
    Docs: add dark mode toggle and default to system preference (jmoiron/humanize#255)
    Documentation improvements (jmoiron/humanize#254)

Changed
-------
    Update repo links (openembedded#2)

Fixed
-------
    Removed VERSION from __all__ (openembedded#11)

Signed-off-by: Zheng Ruoqin <zhengrq.fnst@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this issue May 27, 2022
Changelog:
==========
Added
------
    Support Python 3.11 (openembedded#13)
    Add Arabic language (jmoiron/humanize#256)
    Docs: add dark mode toggle and default to system preference (jmoiron/humanize#255)
    Documentation improvements (jmoiron/humanize#254)

Changed
-------
    Update repo links (openembedded#2)

Fixed
-------
    Removed VERSION from __all__ (openembedded#11)

Signed-off-by: Zheng Ruoqin <zhengrq.fnst@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this issue May 27, 2022
Changelog:
==========
Added
------
    Support Python 3.11 (openembedded#13)
    Add Arabic language (jmoiron/humanize#256)
    Docs: add dark mode toggle and default to system preference (jmoiron/humanize#255)
    Documentation improvements (jmoiron/humanize#254)

Changed
-------
    Update repo links (openembedded#2)

Fixed
-------
    Removed VERSION from __all__ (openembedded#11)

Signed-off-by: Zheng Ruoqin <zhengrq.fnst@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this issue May 28, 2022
Changelog:
==========
Added
------
    Support Python 3.11 (openembedded#13)
    Add Arabic language (jmoiron/humanize#256)
    Docs: add dark mode toggle and default to system preference (jmoiron/humanize#255)
    Documentation improvements (jmoiron/humanize#254)

Changed
-------
    Update repo links (openembedded#2)

Fixed
-------
    Removed VERSION from __all__ (openembedded#11)

Signed-off-by: Zheng Ruoqin <zhengrq.fnst@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this issue May 28, 2022
Changelog:
==========
Added
------
    Support Python 3.11 (openembedded#13)
    Add Arabic language (jmoiron/humanize#256)
    Docs: add dark mode toggle and default to system preference (jmoiron/humanize#255)
    Documentation improvements (jmoiron/humanize#254)

Changed
-------
    Update repo links (openembedded#2)

Fixed
-------
    Removed VERSION from __all__ (openembedded#11)

Signed-off-by: Zheng Ruoqin <zhengrq.fnst@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this issue May 28, 2022
Changelog:
==========
Added
------
    Support Python 3.11 (openembedded#13)
    Add Arabic language (jmoiron/humanize#256)
    Docs: add dark mode toggle and default to system preference (jmoiron/humanize#255)
    Documentation improvements (jmoiron/humanize#254)

Changed
-------
    Update repo links (openembedded#2)

Fixed
-------
    Removed VERSION from __all__ (openembedded#11)

Signed-off-by: Zheng Ruoqin <zhengrq.fnst@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this issue May 28, 2022
Changelog:
==========
Added
------
    Support Python 3.11 (openembedded#13)
    Add Arabic language (jmoiron/humanize#256)
    Docs: add dark mode toggle and default to system preference (jmoiron/humanize#255)
    Documentation improvements (jmoiron/humanize#254)

Changed
-------
    Update repo links (openembedded#2)

Fixed
-------
    Removed VERSION from __all__ (openembedded#11)

Signed-off-by: Zheng Ruoqin <zhengrq.fnst@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this issue May 29, 2022
Changelog:
==========
Added
------
    Support Python 3.11 (openembedded#13)
    Add Arabic language (jmoiron/humanize#256)
    Docs: add dark mode toggle and default to system preference (jmoiron/humanize#255)
    Documentation improvements (jmoiron/humanize#254)

Changed
-------
    Update repo links (openembedded#2)

Fixed
-------
    Removed VERSION from __all__ (openembedded#11)

Signed-off-by: Zheng Ruoqin <zhengrq.fnst@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this issue Sep 5, 2022
Fix the following warning:

WARNING: polkit-0.119-r0 do_patch: Fuzz detected:

Applying patch 0004-Make-netgroup-support-optional.patch
patching file configure.ac
Hunk openembedded#1 succeeded at 117 with fuzz 2 (offset 17 lines).
patching file meson.build
patching file src/polkit/polkitidentity.c
patching file src/polkit/polkitunixnetgroup.c
patching file src/polkitbackend/polkitbackendinteractiveauthority.c
patching file src/polkitbackend/polkitbackendjsauthority.cpp
Hunk openembedded#1 succeeded at 1291 (offset -233 lines).
Hunk openembedded#2 succeeded at 1306 (offset -233 lines).
patching file test/polkit/polkitidentitytest.c
patching file test/polkit/polkitunixnetgrouptest.c
patching file test/polkitbackend/test-polkitbackendjsauthority.c

Signed-off-by: Sergio Prado <sergio.prado@e-labworks.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this issue Sep 6, 2022
Fix the following warning:

WARNING: polkit-0.119-r0 do_patch: Fuzz detected:

Applying patch 0004-Make-netgroup-support-optional.patch
patching file configure.ac
Hunk openembedded#1 succeeded at 117 with fuzz 2 (offset 17 lines).
patching file meson.build
patching file src/polkit/polkitidentity.c
patching file src/polkit/polkitunixnetgroup.c
patching file src/polkitbackend/polkitbackendinteractiveauthority.c
patching file src/polkitbackend/polkitbackendjsauthority.cpp
Hunk openembedded#1 succeeded at 1291 (offset -233 lines).
Hunk openembedded#2 succeeded at 1306 (offset -233 lines).
patching file test/polkit/polkitidentitytest.c
patching file test/polkit/polkitunixnetgrouptest.c
patching file test/polkitbackend/test-polkitbackendjsauthority.c

Signed-off-by: Sergio Prado <sergio.prado@e-labworks.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
jhershbe pushed a commit to jhershbe/meta-openembedded that referenced this issue Sep 8, 2022
Pass parameter "--disable-optimizations" to
configure script to disable compiler optimizations
to fix below issue:
$ gdb /usr/bin/fio
(gdb) r -h
Starting program: /usr/bin/fio -h
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib64/libthread_db.so.1".

Program received signal SIGILL, Illegal instruction.
0x0000000000407220 in prio_tree_init () at lib/prio_tree.c:61
 61	index_bits_to_maxindex[i] = (1UL << (i + 1)) - 1;
(gdb) bt
 #0 0x0000000000407220 in prio_tree_init () at lib/prio_tree.c:61
 #1 0x0000000000482208 in __libc_csu_init (argc=argc@entry=2,
    argv=argv@entry=0x7fffffffecc8, envp=0x7fffffffece0)
    at /usr/src/debug/glibc/2.26-r0/git/csu/elf-init.c:88
 openembedded#2 0x00000031c742095e in __libc_start_main (main=0x407700 <main>, argc=2,
    argv=0x7fffffffecc8, init=0x4821b6 <__libc_csu_init>,
    fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7fffffffecb8)
    at /usr/src/debug/glibc/2.26-r0/git/csu/libc-start.c:264
 openembedded#3 0x00000000004077ea in _start () at ../sysdeps/x86_64/start.S:120

Signed-off-by: Mingli Yu <Mingli.Yu@windriver.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
jhershbe pushed a commit to jhershbe/meta-openembedded that referenced this issue Oct 5, 2022
Pass parameter "--disable-optimizations" to
configure script to disable compiler optimizations
to fix below issue:
$ gdb /usr/bin/fio
(gdb) r -h
Starting program: /usr/bin/fio -h
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib64/libthread_db.so.1".

Program received signal SIGILL, Illegal instruction.
0x0000000000407220 in prio_tree_init () at lib/prio_tree.c:61
 61	index_bits_to_maxindex[i] = (1UL << (i + 1)) - 1;
(gdb) bt
 #0 0x0000000000407220 in prio_tree_init () at lib/prio_tree.c:61
 #1 0x0000000000482208 in __libc_csu_init (argc=argc@entry=2,
    argv=argv@entry=0x7fffffffecc8, envp=0x7fffffffece0)
    at /usr/src/debug/glibc/2.26-r0/git/csu/elf-init.c:88
 openembedded#2 0x00000031c742095e in __libc_start_main (main=0x407700 <main>, argc=2,
    argv=0x7fffffffecc8, init=0x4821b6 <__libc_csu_init>,
    fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7fffffffecb8)
    at /usr/src/debug/glibc/2.26-r0/git/csu/libc-start.c:264
 openembedded#3 0x00000000004077ea in _start () at ../sysdeps/x86_64/start.S:120

Signed-off-by: Mingli Yu <Mingli.Yu@windriver.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
halstead pushed a commit that referenced this issue Sep 10, 2023
fixes:

WARNING: postgresql-12.16-r0 do_patch: Fuzz detected:

Applying patch 0001-Add-support-for-RISC-V.patch
patching file src/include/storage/s_lock.h
Hunk #2 succeeded at 339 with fuzz 1.

Signed-off-by: Armin Kuster <akuster808@gmail.com>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this issue May 9, 2024
In particular, make it build with gcc 14.

License-Update: Remove "All rights reserved" from copyright line

Changelog:

2939632 xkbutils 1.0.6
e2ee9c2 Change sprintf calls to use snprintf instead
aa03a3b Remove uSetErrorFile()
5f875c8 xkbwatch: Fix -Wincompatible-pointer-types warning (Issue openembedded#2)
6dbcbb5 Remove "All rights reserved" from Oracle copyright notices
56c99e3 gitlab CI: stop requiring Signed-off-by in commits

Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this issue May 10, 2024
In particular, make it build with gcc 14.

License-Update: Remove "All rights reserved" from copyright line

Changelog:

2939632 xkbutils 1.0.6
e2ee9c2 Change sprintf calls to use snprintf instead
aa03a3b Remove uSetErrorFile()
5f875c8 xkbwatch: Fix -Wincompatible-pointer-types warning (Issue openembedded#2)
6dbcbb5 Remove "All rights reserved" from Oracle copyright notices
56c99e3 gitlab CI: stop requiring Signed-off-by in commits

Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this issue May 12, 2024
In particular, make it build with gcc 14.

License-Update: Remove "All rights reserved" from copyright line

Changelog:

2939632 xkbutils 1.0.6
e2ee9c2 Change sprintf calls to use snprintf instead
aa03a3b Remove uSetErrorFile()
5f875c8 xkbwatch: Fix -Wincompatible-pointer-types warning (Issue openembedded#2)
6dbcbb5 Remove "All rights reserved" from Oracle copyright notices
56c99e3 gitlab CI: stop requiring Signed-off-by in commits

Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants