Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude Dunfell (Kernel 5.4.74) from PNBLACKLIST #296

Open
jinparksj opened this issue Dec 4, 2020 · 4 comments
Open

Exclude Dunfell (Kernel 5.4.74) from PNBLACKLIST #296

jinparksj opened this issue Dec 4, 2020 · 4 comments

Comments

@jinparksj
Copy link

Hello

I would like to build module for can-isoto.ko and it is blacklisted.
My Yocto framework's kernel is Dunfell Kernel 5.4.74.
Based on the error comment, is it okay to take out below command in can-isot_git.bb?
PNBLACKLIST[can-isotp] = "Kernel module Needs forward porting to kernel 5.2+"

https://github.com/openembedded/meta-openembedded/blob/master/meta-oe/recipes-extended/socketcan/can-isotp_git.bb

https://github.com/openembedded/meta-openembedded/blob/dunfell/meta-oe/recipes-extended/socketcan/can-isotp_git.bb

@kraj
Copy link
Contributor

kraj commented Dec 4, 2020

you can remove that line and see if it builds with your kernel. if not then fixing it will be required, if you fix it, don't forget to send your patch upstream.

@jinparksj
Copy link
Author

jinparksj commented Dec 4, 2020

I revised the recipe like below and it works for me.

If it seems okay for you, I would like to upstream below my one of below recipes.

I changed master to the branch '4.17+' which is built for mainline, which will be used for Linux Kernel 5.10+, and change the commit id to d50a2001ec994031233ad9c0cc1647fad41835f3, which reverts before Kernel Update from 5.4 to 5.9.

hartkopp/can-isotp@98986fc2f07cb5c7fa73a86d9
hartkopp/can-isotp@d50a200

I think that the master branch also should work with removing PNBLACKLIST. But, I only built up kernel module and image, not checking with physical communication, such as monitoring packets in CAN bus.

<can-isotp_git.bb>

Comment out PNBLACKLIST
Move branch
Revert commit id

LICENSE = "GPLv2"
LIC_FILES_CHKSUM = "file://COPYING;md5=72d977d697c3c05830fdff00a7448931"
SRCREV = "d50a2001ec994031233ad9c0cc1647fad41835f3"
PV = "1.0+git${SRCPV}"
SRC_URI = "git://github.com/hartkopp/can-isotp.git;branch=4.17+;protocol=https"
S = "${WORKDIR}/git"
inherit module
EXTRA_OEMAKE += "KERNELDIR=${STAGING_KERNEL_DIR}"
#PNBLACKLIST[can-isotp] = "Kernel module Needs forward porting to kernel 5.2+"

Comment out only PNBLACKLIST

LICENSE = "GPLv2"
LIC_FILES_CHKSUM = "file://COPYING;md5=72d977d697c3c05830fdff00a7448931"
SRCREV = "b31bce98d65f894aad6427bcf6f3f7822e261a59"
PV = "1.0+git${SRCPV}"

SRC_URI = "git://github.com/hartkopp/can-isotp.git;protocol=https"

S = "${WORKDIR}/git"

inherit module

EXTRA_OEMAKE += "KERNELDIR=${STAGING_KERNEL_DIR}"

#PNBLACKLIST[can-isotp] = "Kernel module Needs forward porting to kernel 5.2+"

@akuster
Copy link
Contributor

akuster commented Feb 7, 2021

Does this patch for can-isotp address this ?

hartkopp/can-isotp@cee2887

and maybe this
hartkopp/can-isotp@0cb92ae

hmm or maybe just update to a later hash

@akuster
Copy link
Contributor

akuster commented Feb 7, 2021

can you send a patch for master then we can propagate it to the other branches. From what I can see, the changes appear to be bug fixes.

kraj pushed a commit to YoeDistro/meta-openembedded that referenced this issue Jan 4, 2023
Changelog:
==========
- Fix regression (openembedded#310)
- Merge pull request openembedded#303 from rsnapshot/update-HOWTO-to-talk-about-retain-instead-of-interval
- Removing legacy Docbook files, as per discussion at rsnapshot/rsnapshot#296
- Merge pull request openembedded#296 from hoclun-rigsep/hoclun-rigsep-patch-1
- Use @Prefix@ instead of hardcoded value in rsnapshot.conf.default.in comment line (openembedded#289).

Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this issue Jan 4, 2023
Changelog:
==========
- Fix regression (openembedded#310)
- Merge pull request openembedded#303 from rsnapshot/update-HOWTO-to-talk-about-retain-instead-of-interval
- Removing legacy Docbook files, as per discussion at rsnapshot/rsnapshot#296
- Merge pull request openembedded#296 from hoclun-rigsep/hoclun-rigsep-patch-1
- Use @Prefix@ instead of hardcoded value in rsnapshot.conf.default.in comment line (openembedded#289).

Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this issue Jan 5, 2023
Changelog:
==========
- Fix regression (openembedded#310)
- Merge pull request openembedded#303 from rsnapshot/update-HOWTO-to-talk-about-retain-instead-of-interval
- Removing legacy Docbook files, as per discussion at rsnapshot/rsnapshot#296
- Merge pull request openembedded#296 from hoclun-rigsep/hoclun-rigsep-patch-1
- Use @Prefix@ instead of hardcoded value in rsnapshot.conf.default.in comment line (openembedded#289).

Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this issue Jan 6, 2023
Changelog:
==========
- Fix regression (openembedded#310)
- Merge pull request openembedded#303 from rsnapshot/update-HOWTO-to-talk-about-retain-instead-of-interval
- Removing legacy Docbook files, as per discussion at rsnapshot/rsnapshot#296
- Merge pull request openembedded#296 from hoclun-rigsep/hoclun-rigsep-patch-1
- Use @Prefix@ instead of hardcoded value in rsnapshot.conf.default.in comment line (openembedded#289).

Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this issue Nov 12, 2023
- `universal`: Enable `application/vnd.cups-postscript` as input
  There are filters which produce this MIME type (such as `hpps` of
  HPLIP), and if someone uses such driver on a client and the server
  has an IPP Everywhere/driverless printer, the job fails (Pull
  request openembedded#534).

- beh backend: Use `execv()` instead of `system()` - CVE-2023-24805
  With `execv()` command line arguments are passed as separate strings
  and not the full command line in a single string. This prevents
  arbitrary command execution by escaping the quoting of the arguments
  in a job with forged job title.

- beh backend: Extra checks against odd/forged input - CVE-2023-24805

  * Do not allow `/` in the scheme of the URI (= backend executable
    name), to assure that only backends inside
    `/usr/lib/cups/backend/` are used.

  * Pre-define scheme buffer to empty string, to be defined for case
    of URI being NULL.

  * URI must have `:`, to split off scheme, otherwise error.

  * Check return value of `snprintf()` to create call path for
    backend, to error out on truncation of a too long scheme or on
    complete failure due to a completely odd scheme.

- beh backend: Further improvements - CVE-2023-24805

  * Use `strncat()` instead of `strncpy()` for getting scheme from
    URI, the latter does not require setting terminating zero byte in
    case of truncation.

  * Also exclude `.` or `..` as scheme, as directories are not valid
    CUPS backends.

  * Do not use `fprintf()` in `sigterm_handler()`, to not interfere
    with a `fprintf()` which could be running in the main process when
    `sigterm_handler()` is triggered.

  * Use `static volatile int` for global variable job_canceled.

- `parallel` backend: Added missing `#include` lines

- foomatic-rip: Fix a SIGPIPE error when calling gs (Pull request openembedded#517)
  [Ubuntu's autopkgtest for
  foo2zjs](https://autopkgtest.ubuntu.com/packages/f/foo2zjs/lunar/ppc64el)
  shows foo2zjs's testsuite failing with cups-filters 2.0beta3 on
  ppc64el. This is cause by a timing issue in foomatic-rip which is
  fixed now.

- Coverity check done by Zdenek Dohnal for the inclusion of
  cups-filters in Fedora and Red Hat. Zdenek has fixed all the issues:
  Missing `free()`, files not closed, potential string overflows,
  ... Thanks a lot! (Pull request openembedded#510).

- Dropped all C++ references and obsolete C standards (Pull requests
  openembedded#504 and openembedded#513)
  With no C++ compiler needed, there is no need for any checks or
  setting for C++ in configure.ac.

- configure.ac: Change deprecated AC_PROG_LIBTOOL for LT_INIT (Pull
  request openembedded#508)

- texttopdf: Do not include fontconfig.h in the CUPS filter wrapper

- Build system: Do not explicitly check for libpoppler-cpp
  The cups-filters package does not contain any code using
  libpoppler-cpp, therefore we let ./configure not check for it.

- COPYING, NOTICE: Simplification for autotools-generated files
  autotools-generated files can be included under the license of the
  upstream code, and FSF copyright added to upstream copyright
  list. Simplified COPYING appropriately.

- Makefile.am: Include LICENSE in distribution tarball

- Add templates for issue reports on GitHub. This makes a selection
  screen appear when clicking "New Issue" in the web UI, to selct
  whether the issue is a regular bug, a feature request, or a security
  vulnerability.

- Corrected installation path for *.h files of *.drv files.  The ppdc
  (and underlying functions) of libppd searches for include files in
  /usr/share/ppdc and not in /usr/share/cups/ppdc any more.

- configure.ac: Remove unnecessary "AVAHI_GLIB_..." definitions.

- Makefile.am: Include NOTICE in distribution tarball

- configure.ac: Added "foreign" to to AM_INIT_AUTOMAKE() call. Makes
  automake not require a file named README.

- Cleaned up .gitignore

- Tons of fixes in the source code documentation: README.md, INSTALL,
  DEVELOPING.md, CONTRIBUTING.md, COPYING, NOTICE, ... Adapted to the
  cups-filters component, added links.

- Converted nearly all filters to filter functions, only exceptions
  are `rastertoescpx`, `rastertopclx`, `commandtoescpx`,
  `commandtopclx`, and `foomatic-rip`. The latter is deeply involved
  with Foomatic PPDs and the others are legacy printer drivers. The
  filter functions are mainly in libcupsfilters, the ones which
  generate PostScript are in libppd.

- Replaced all the filters converted to filter functions by simple
  wrapper executables using `ppdFilterCUPSWrapper()` of libppd for
  backward compatibility with CUPS 2.x.

- Added new streaming mode triggered by the boolean
  "filter-streaming-mode" option. In this mode a filter (function) is
  supposed to avoid everything which prevents the job data from
  streaming, as loading the whole job (or good part of it) into a
  temporary file or into memory, interpreting PDF, pre-checking input
  file type or zero-page jobs, ... This is mainly to be used by
  Printer Applications when they do raster printing in streaming mode,
  to run with lowest resources possible. Currently `foomatic-rip`,
  `ghostscript`, and `pdftopdf` got a streaming mode. For the former
  two PostScript (not PDF) is assumed as input and no zero-page-job
  check is done, in the latter all QPDF processing (page management,
  page size adjustment, ...) is skipped and only JCL according to the
  PPD added.

- The CUPS filter `imagetops` uses the `ppdFilterImageToPS()` filter
  function of libppd now.

- `driverless`, `driverless-fax`: Added IPP Fax Out support. Now
  printer setup tools list an additional fax "driver". A fax queue is
  created by selecting this driver. Jobs have to be sent with "-o
  phone=12345" to supply the destination phone number (Pull request
  openembedded#280, openembedded#293, openembedded#296, openembedded#302, openembedded#304, openembedded#305, openembedded#306, openembedded#309, Issue openembedded#298, openembedded#308).

- `sys5ippprinter`: Removed `sys5ippprinter`, as CUPS does not support
  System V interface scripts any more. This first approach of PPD-less
  printing was also not actually made use of.

- `urftopdf`: Removed as we require CUPS 2.2.2+ now which supports
  Apple Raster by itself.

- Build system, `README.md`: Require CUPS 2.2.2+. Removed now unneeded
  `./configure` switches for use of the `urftopdf` filter for old CUPS
  versions.

- Sample PPDs: Renamed source directory from `ppd/` to `ppdfiles/`.

- Build system: Remove '-D_PPD_DEPRECATED=""' from the compiling
  command lines of the source files which use libcups. The flag is not
  supported any more for longer times already and all the PPD-related
  functions deprecated by CUPS have moved into libppd now.

- Build system: Add files in `.gitignore` that are generated by
  "autogen.sh", "configure", and "make" (Pull request openembedded#336).

Signed-off-by: Markus Volk <f_l_k@t-online.de>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants