Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readline no longer a DEPENDS for jack 1.19.22 on the master branch #732

Closed
large2021 opened this issue Aug 15, 2023 · 7 comments
Closed

Comments

@large2021
Copy link
Contributor

For recipe meta-oe/recipes-multimedia/jack/jack_1.19.22.bb, on the "master" branch, the DEPENDS includes "readline". Since "jack-utils" is no longer being built, this dependency is obsolete.

As "readline" is GPLv3, this introduces the need to "DEPENDS:remove" the dependency for those of us who strive to be GPLv3-free.

@large2021
Copy link
Contributor Author

Also present on the "mickledore" branch.

@kraj
Copy link
Contributor

kraj commented Aug 15, 2023

@large2021 thanks for the report. Are you also working on a patch to fix this. ?

@large2021
Copy link
Contributor Author

large2021 commented Aug 15, 2023 via email

@kraj
Copy link
Contributor

kraj commented Aug 15, 2023

I’d be happy to submit a patch, and am capable of doing so, but am unfamiliar with the openembedded process/requirements. Please advise. Kindest, Kirk Hays From: Khem Raj @.> Sent: Tuesday, August 15, 2023 9:25 AM To: openembedded/meta-openembedded @.> Cc: Kirk Hays @.>; Mention @.> Subject: Re: [openembedded/meta-openembedded] readline no longer a DEPENDS for jack 1.19.22 on the master branch (Issue #732) @large2021<https://urldefense.com/v3/https:/github.com/large2021;!!HBnMciuwfVSXJQ!RON4-XEJHkHvzQhnOSD7DjvOta1CkGCZb73Mdcd-N6-hn3RuPY-14bmtUxxUzzAIPzAjXImM8HZcGjtpXlvoLgJ-$> thanks for the report. Are you also working on a patch to fix this. ? — Reply to this email directly, view it on GitHub<https://urldefense.com/v3/https:/github.com/openembedded/meta-openembedded/issues/732*issuecomment-1679251106;Iw!!HBnMciuwfVSXJQ!RON4-XEJHkHvzQhnOSD7DjvOta1CkGCZb73Mdcd-N6-hn3RuPY-14bmtUxxUzzAIPzAjXImM8HZcGjtpXnrBkY11$>, or unsubscribe<https://urldefense.com/v3/https:/github.com/notifications/unsubscribe-auth/AS7HQGB534VSMAIUSFKRHNLXVOPE5ANCNFSM6AAAAAA3RHPQOI;!!HBnMciuwfVSXJQ!RON4-XEJHkHvzQhnOSD7DjvOta1CkGCZb73Mdcd-N6-hn3RuPY-14bmtUxxUzzAIPzAjXImM8HZcGjtpXliRzw-H$>. You are receiving this because you were mentioned.Message ID: @.@.>>

you can create a patch and send to openembedded-devel@lists.openembedded.org, you can also create a github pull which I can take to the mailing list.

@large2021
Copy link
Contributor Author

A patch has been submitted to the mailing list.

@kraj
Copy link
Contributor

kraj commented Aug 15, 2023

mailing lists are subscriber only, non-subscriber posts needs to be channelled by a moderator, so it may take a while for your post to reach the mailing list distribution.

@kraj
Copy link
Contributor

kraj commented Aug 18, 2023

fixed with 4bacc11

@kraj kraj closed this as completed Aug 18, 2023
PheeL79 pushed a commit to PheeL79/meta-openembedded that referenced this issue Aug 29, 2023
Changelog:
===========
Added:
-----------
 add ${BATS_TEST_TAGS[@]} for querying the tags during a test (openembedded#705)
 print tags on failing tests (openembedded#705)
 test for negative arguments to --jobs (openembedded#693)
 add tests for --formatter cat (openembedded#710)
 test coverage in CI (openembedded#718)
 Support for rush as alternative to GNU parallel (openembedded#729)
 add bats_pipe helper function for run that executes \| as pipes (openembedded#663)
 publish docker images to ghcr.io (additionally to Dockerhub) (openembedded#740)

Fixed:
---------
 fix run with options overwriting the value of i (openembedded#726, openembedded#727)
 fix ${BATS_TEST_NAMES[@]} containing only --tags instead of test name since Bats v1.8.0 (openembedded#705)
 fix run --keep-empty-lines counting trailing \n as (empty) new line (openembedded#711)
 fix short flag unpacker creating bogus command lines with valued flags (openembedded#732)
 fix formatter becoming confused with retries (openembedded#734)
 fix --gather-test-outputs-in fails on tests with / (openembedded#735)
 fix overriding date breaks --timing (openembedded#736)

Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants