Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix SRCREV_FORMAT errors #442

Closed
wants to merge 5 commits into from
Closed

Conversation

awe-1989
Copy link

No description provided.

Since it uses multiple fetch URIs make it explicit to define SRCREV_FORMAT

Signed-off-by: Khem Raj <raj.khem@gmail.com>
Since it uses multiple fetch URIs make it explicit to define SRCREV_FORMAT

Signed-off-by: Khem Raj <raj.khem@gmail.com>
@awe-1989 awe-1989 changed the base branch from master to dunfell September 27, 2021 15:40
@akuster
Copy link
Contributor

akuster commented Sep 27, 2021

the commits from awe-1989 are missing signed-off-by

@akuster akuster self-assigned this Sep 27, 2021
@akuster akuster requested a review from kraj September 27, 2021 15:54
@@ -21,6 +21,7 @@ SRCREV_spirv-headers = "af64a9e826bf5bb5fcd2434dd71be1e41e922563"
SRCREV_effcee = "cd25ec17e9382f99a895b9ef53ff3c277464d07d"
SRCREV_re2 = "5bd613749fd530b576b890283bfb6bc6ea6246cb"
SRCREV_googletest = "f2fb48c3b3d79a75a88a99fba6576b25d42ec528"
SRCREV_FORMAT ="ttols_headers_effcee_re2_googletest"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a typo s/ttools/spirv-tools/ and headers should be spirv-headers

@@ -15,6 +15,7 @@ SRC_URI = "git://github.com/LINBIT/drbd-utils;name=drbd-utils \
# v9.12.0
SRCREV_drbd-utils = "91629a4cce49ca0d4f917fe0bffa25cfe8db3052"
SRCREV_drbd-headers = "233006b4d26cf319638be0ef6d16ec7dee287b66"
SRCREV_FORMAT = "utils_headers"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be drbd-utils_drbd-headers

Since it uses multiple fetch URIs make it explicit to define SRCREV_FORMAT

Signed-off-by: Andreas Weger <weger@hs-mittweida.de>

Change-Id: I062eb971a83594315cc674ccb6eba67a14d5656f
Since it uses multiple fetch URIs make it explicit to define SRCREV_FORMAT

Signed-off-by: Andreas Weger <weger@hs-mittweida.de>

Change-Id: Ib24fce16b3986a465f1c5854166b8f28446b5186
Since it uses multiple fetch URIs make it explicit to define SRCREV_FORMAT

Signed-off-by: Andreas Weger <weger@hs-mittweida.de>

Change-Id: Id1d0a1062d09f690123b2a1c06137ae5c04d7b20
@awe-1989
Copy link
Author

Thanks for the comments. I pushed a new patch set.

Copy link
Contributor

@kraj kraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks ok to me. I see that you proposed it for dunfell. I would like you to first ensure that all these changes are already present in one way or other in master branch as well. Then we can apply it for dunfell.

@awe-1989
Copy link
Author

this looks ok to me. I see that you proposed it for dunfell. I would like you to first ensure that all these changes are already present in one way or other in master branch as well. Then we can apply it for dunfell.

meta-networking/recipes-support/drbd/drbd-utils_9.12.0.bb was changed to drbd-utils_9.13.1.bb and fixed in bd49915

meta-oe/recipes-devtools/grpc/grpc_1.24.3.bb was changed to grpc_1.35.0.bb. during this time was switched to a single source. 15cff67

meta-oe/recipes-graphics/spir/spirv-tools_git.bb was moved to openembedded-core with 8a5d7f2. There it has only one source in the master branch.

Thus, these problems should no longer occur in the master branch.

@kraj
Copy link
Contributor

kraj commented Sep 27, 2021

this looks ok to me. I see that you proposed it for dunfell. I would like you to first ensure that all these changes are already present in one way or other in master branch as well. Then we can apply it for dunfell.

meta-networking/recipes-support/drbd/drbd-utils_9.12.0.bb was changed to drbd-utils_9.13.1.bb and fixed in bd49915

meta-oe/recipes-devtools/grpc/grpc_1.24.3.bb was changed to grpc_1.35.0.bb. during this time was switched to a single source. 15cff67

meta-oe/recipes-graphics/spir/spirv-tools_git.bb was moved to openembedded-core with 8a5d7f2. There it has only one source in the master branch.

Thus, these problems should no longer occur in the master branch.

sounds good then. Thanks for followup. @akuster we should be good for dunfell here.

kanavin pushed a commit to kanavin/meta-openembedded that referenced this pull request Sep 28, 2021
Release notes for 4.16.3
========================
- panel: Change width of default panel-2 to 1% (Fixes openembedded#454)
- panel: Fix xfce4-panel-CRITICAL
- panel: Fix xfce4-panel-CRITICAL when already running
- libxfce4panel: Do not destroy context menu if popped up (Fixes openembedded#442)
- launcher: Check for menu item initialization
- launcher: Fix garcon-CRITICAL at startup
- systray: Fix GObject-CRITICAL
- systray: Fix Gtk-CRITICAL at startup/shutdown
- systray: Fix libsystray-CRITICAL
- tasklist: Fix Gtk-CRITICAL
- Silent `-Wcast-align` from Clang
- Translation Updates

Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
@akuster
Copy link
Contributor

akuster commented Nov 2, 2021

pulled changes in for testing

@akuster
Copy link
Contributor

akuster commented Nov 2, 2021

some of these also pulled in for hardknott

@akuster
Copy link
Contributor

akuster commented Nov 16, 2021

@akuster
Copy link
Contributor

akuster commented Nov 16, 2021

thanks

@akuster akuster closed this Nov 16, 2021
mike-petersen-ni pushed a commit to mike-petersen-ni/meta-openembedded that referenced this pull request Jul 12, 2022
Release notes for 4.16.3
========================
- panel: Change width of default panel-2 to 1% (Fixes openembedded#454)
- panel: Fix xfce4-panel-CRITICAL
- panel: Fix xfce4-panel-CRITICAL when already running
- libxfce4panel: Do not destroy context menu if popped up (Fixes openembedded#442)
- launcher: Check for menu item initialization
- launcher: Fix garcon-CRITICAL at startup
- systray: Fix GObject-CRITICAL
- systray: Fix Gtk-CRITICAL at startup/shutdown
- systray: Fix libsystray-CRITICAL
- tasklist: Fix Gtk-CRITICAL
- Silent `-Wcast-align` from Clang
- Translation Updates

Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
(cherry picked from commit 2b9f0a5)
mike-petersen-ni pushed a commit to mike-petersen-ni/meta-openembedded that referenced this pull request Jul 12, 2022
Release notes for 4.16.3
========================
- panel: Change width of default panel-2 to 1% (Fixes openembedded#454)
- panel: Fix xfce4-panel-CRITICAL
- panel: Fix xfce4-panel-CRITICAL when already running
- libxfce4panel: Do not destroy context menu if popped up (Fixes openembedded#442)
- launcher: Check for menu item initialization
- launcher: Fix garcon-CRITICAL at startup
- systray: Fix GObject-CRITICAL
- systray: Fix Gtk-CRITICAL at startup/shutdown
- systray: Fix libsystray-CRITICAL
- tasklist: Fix Gtk-CRITICAL
- Silent `-Wcast-align` from Clang
- Translation Updates

Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Mike Petersen <mike.petersen@ni.com>
(cherry picked from commit 2b9f0a5)
amstewart pushed a commit to ni/meta-openembedded that referenced this pull request Jul 12, 2022
Release notes for 4.16.3
========================
- panel: Change width of default panel-2 to 1% (Fixes openembedded#454)
- panel: Fix xfce4-panel-CRITICAL
- panel: Fix xfce4-panel-CRITICAL when already running
- libxfce4panel: Do not destroy context menu if popped up (Fixes openembedded#442)
- launcher: Check for menu item initialization
- launcher: Fix garcon-CRITICAL at startup
- systray: Fix GObject-CRITICAL
- systray: Fix Gtk-CRITICAL at startup/shutdown
- systray: Fix libsystray-CRITICAL
- tasklist: Fix Gtk-CRITICAL
- Silent `-Wcast-align` from Clang
- Translation Updates

Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Mike Petersen <mike.petersen@ni.com>
(cherry picked from commit 2b9f0a5)
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this pull request Sep 21, 2022
Changelog:
=========
Improve transcoding error message (openembedded#442) (538df80)

Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this pull request Aug 17, 2023
…27995b38eb4271044f)

Drop patches now part of new upstream release:
- 449.patch
- 481.patch
- 482.patch

Refresh patches due to GENIVI->COVESA renaming

What's Changed:

    Update ReleaseNotes and version to v2.18.9 by @minminlittleshrimp in openembedded#468
    Update status badges on README.md by @michael-methner in openembedded#467
    logstorage: Adds option to write logs in gzip format by @LiquidityC in openembedded#442
    Re-Initialize internal logging in daemon mode only by @lvklevankhanh in openembedded#459
    Remove use of DLT_LOG in signal handler by @michael-methner in openembedded#472
    Update gtest_dlt_daemon_multiple_files_logging.cpp by @LocutusOfBorg in openembedded#481
    Update AUTOSAR standard link by @lucafrance in openembedded#480
    cmake: set version to 2.18.9 by @alexmohr in openembedded#478
    Fix macro code to use boolean value in while instruction (false) by @michael-methner in openembedded#469
    dlt_user_shared: Add timeout to writev by @alexmohr in openembedded#385
    build: add static lib only if necessary by @alexmohr in openembedded#479
    Update CMakeLists.txt by @LocutusOfBorg in openembedded#482
    watchdog: improve dlt watchdog by @alexmohr in openembedded#470
    log-level-config: add option to configure log levels by @alexmohr in openembedded#474
    gtest_dlt_daemon_gateway: dlt-daemon run without dlt_passive.conf file by @lti9hc in openembedded#487
    dlt_unit_test: Fix and improve quality of unit tests by @minminlittleshrimp in openembedded#494
    dlt-qnx-system improvement by @lvklevankhanh in openembedded#495
    gtest: Init submodule and update version by @minminlittleshrimp in openembedded#497
    dlt-qnx-system: prevent message loss in high load situations by @alexmohr in openembedded#490
    Fix compile error stringop-truncation with GCC 9.4 by @michael-methner in openembedded#499
    Update README.md by @lvklevankhanh in openembedded#503
    dlt-coverage: Add coverage report generator for dlt by @minminlittleshrimp in openembedded#501
    dlt-system: move journal reading to its own thread by @alexmohr in openembedded#471
    Switch from GENIVI to COVESA by @minminlittleshrimp in openembedded#511
    Update CMakeLists.txt: set required std version to gnu++14 by @LocutusOfBorg in openembedded#504
    cmake: Policy CMP0115 set to OLD behavior for dlt-daemon with cmake >= 3.20 by @minminlittleshrimp in openembedded#510
    fix usage of pthread_cond_timedwait by @alexmohr in openembedded#491
    DLT Upstream for minor release by @minminlittleshrimp in openembedded#515
    cmake: disable network trace by @alexmohr in openembedded#477
    doc: add COVESA logo image by @minminlittleshrimp in openembedded#516
    Prepare for 2.18.10 release by @michael-methner in openembedded#517

Signed-off-by: Gianfranco Costamagna <costamagnagianfranco@yahoo.it>
Signed-off-by: Gianfranco Costamagna <locutusofborg@debian.org>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this pull request Aug 17, 2023
…27995b38eb4271044f)

Drop patches now part of new upstream release:
- 449.patch
- 481.patch
- 482.patch

Refresh patches due to GENIVI->COVESA renaming

What's Changed:

    Update ReleaseNotes and version to v2.18.9 by @minminlittleshrimp in openembedded#468
    Update status badges on README.md by @michael-methner in openembedded#467
    logstorage: Adds option to write logs in gzip format by @LiquidityC in openembedded#442
    Re-Initialize internal logging in daemon mode only by @lvklevankhanh in openembedded#459
    Remove use of DLT_LOG in signal handler by @michael-methner in openembedded#472
    Update gtest_dlt_daemon_multiple_files_logging.cpp by @LocutusOfBorg in openembedded#481
    Update AUTOSAR standard link by @lucafrance in openembedded#480
    cmake: set version to 2.18.9 by @alexmohr in openembedded#478
    Fix macro code to use boolean value in while instruction (false) by @michael-methner in openembedded#469
    dlt_user_shared: Add timeout to writev by @alexmohr in openembedded#385
    build: add static lib only if necessary by @alexmohr in openembedded#479
    Update CMakeLists.txt by @LocutusOfBorg in openembedded#482
    watchdog: improve dlt watchdog by @alexmohr in openembedded#470
    log-level-config: add option to configure log levels by @alexmohr in openembedded#474
    gtest_dlt_daemon_gateway: dlt-daemon run without dlt_passive.conf file by @lti9hc in openembedded#487
    dlt_unit_test: Fix and improve quality of unit tests by @minminlittleshrimp in openembedded#494
    dlt-qnx-system improvement by @lvklevankhanh in openembedded#495
    gtest: Init submodule and update version by @minminlittleshrimp in openembedded#497
    dlt-qnx-system: prevent message loss in high load situations by @alexmohr in openembedded#490
    Fix compile error stringop-truncation with GCC 9.4 by @michael-methner in openembedded#499
    Update README.md by @lvklevankhanh in openembedded#503
    dlt-coverage: Add coverage report generator for dlt by @minminlittleshrimp in openembedded#501
    dlt-system: move journal reading to its own thread by @alexmohr in openembedded#471
    Switch from GENIVI to COVESA by @minminlittleshrimp in openembedded#511
    Update CMakeLists.txt: set required std version to gnu++14 by @LocutusOfBorg in openembedded#504
    cmake: Policy CMP0115 set to OLD behavior for dlt-daemon with cmake >= 3.20 by @minminlittleshrimp in openembedded#510
    fix usage of pthread_cond_timedwait by @alexmohr in openembedded#491
    DLT Upstream for minor release by @minminlittleshrimp in openembedded#515
    cmake: disable network trace by @alexmohr in openembedded#477
    doc: add COVESA logo image by @minminlittleshrimp in openembedded#516
    Prepare for 2.18.10 release by @michael-methner in openembedded#517

Signed-off-by: Gianfranco Costamagna <costamagnagianfranco@yahoo.it>
Signed-off-by: Gianfranco Costamagna <locutusofborg@debian.org>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this pull request Aug 17, 2023
…27995b38eb4271044f)

Drop patches now part of new upstream release:
- 449.patch
- 481.patch
- 482.patch

Refresh patches due to GENIVI->COVESA renaming

What's Changed:

    Update ReleaseNotes and version to v2.18.9 by @minminlittleshrimp in openembedded#468
    Update status badges on README.md by @michael-methner in openembedded#467
    logstorage: Adds option to write logs in gzip format by @LiquidityC in openembedded#442
    Re-Initialize internal logging in daemon mode only by @lvklevankhanh in openembedded#459
    Remove use of DLT_LOG in signal handler by @michael-methner in openembedded#472
    Update gtest_dlt_daemon_multiple_files_logging.cpp by @LocutusOfBorg in openembedded#481
    Update AUTOSAR standard link by @lucafrance in openembedded#480
    cmake: set version to 2.18.9 by @alexmohr in openembedded#478
    Fix macro code to use boolean value in while instruction (false) by @michael-methner in openembedded#469
    dlt_user_shared: Add timeout to writev by @alexmohr in openembedded#385
    build: add static lib only if necessary by @alexmohr in openembedded#479
    Update CMakeLists.txt by @LocutusOfBorg in openembedded#482
    watchdog: improve dlt watchdog by @alexmohr in openembedded#470
    log-level-config: add option to configure log levels by @alexmohr in openembedded#474
    gtest_dlt_daemon_gateway: dlt-daemon run without dlt_passive.conf file by @lti9hc in openembedded#487
    dlt_unit_test: Fix and improve quality of unit tests by @minminlittleshrimp in openembedded#494
    dlt-qnx-system improvement by @lvklevankhanh in openembedded#495
    gtest: Init submodule and update version by @minminlittleshrimp in openembedded#497
    dlt-qnx-system: prevent message loss in high load situations by @alexmohr in openembedded#490
    Fix compile error stringop-truncation with GCC 9.4 by @michael-methner in openembedded#499
    Update README.md by @lvklevankhanh in openembedded#503
    dlt-coverage: Add coverage report generator for dlt by @minminlittleshrimp in openembedded#501
    dlt-system: move journal reading to its own thread by @alexmohr in openembedded#471
    Switch from GENIVI to COVESA by @minminlittleshrimp in openembedded#511
    Update CMakeLists.txt: set required std version to gnu++14 by @LocutusOfBorg in openembedded#504
    cmake: Policy CMP0115 set to OLD behavior for dlt-daemon with cmake >= 3.20 by @minminlittleshrimp in openembedded#510
    fix usage of pthread_cond_timedwait by @alexmohr in openembedded#491
    DLT Upstream for minor release by @minminlittleshrimp in openembedded#515
    cmake: disable network trace by @alexmohr in openembedded#477
    doc: add COVESA logo image by @minminlittleshrimp in openembedded#516
    Prepare for 2.18.10 release by @michael-methner in openembedded#517

Signed-off-by: Gianfranco Costamagna <costamagnagianfranco@yahoo.it>
Signed-off-by: Gianfranco Costamagna <locutusofborg@debian.org>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants