Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ot-br-posix: Add dep to ipset as used by firewall #611

Closed

Conversation

rzr
Copy link
Contributor

@rzr rzr commented Sep 20, 2022

ipset is used by firewall module of ot-br-posix:

third_party/openthread/repo/src/posix/platform/firewall.cpp:
return ExecuteCommand("%s add %s %s -exist", kIpsetCommand, aSetName, aAddress);

Related observed issue looked like:

oniro@oniro-linux-blueprint-gateway-raspberrypi4-64:~$ sudo journalctl -u otbr-agent.service
Apr 28 17:42:32 oniro-linux-blueprint-gateway-raspberrypi4-64 systemd[1]: Started OpenThread Border Router Agent.
Apr 28 17:42:38 oniro-linux-blueprint-gateway-raspberrypi4-64 otbr-agent[330]: sh: ipset: not found

Relate-to: https://gitlab.eclipse.org/eclipse/oniro-blueprints/transparent-gateway/meta-oniro-blueprints-gateway/-/issues/6
Cc: Stefan Schmidt stefan.schmidt@huawei.com
Forwarded: https://github.com/openembedded/meta-openembedded/pulls?q=author%3Arzr
Signed-off-by: Philippe Coval philippe.coval.ext@huawei.com

ipset is used by firewall module of ot-br-posix:

   third_party/openthread/repo/src/posix/platform/firewall.cpp:\
   return ExecuteCommand("%s add %s %s -exist", kIpsetCommand, aSetName, aAddress);

Related observed issue looked like:

```
oniro@oniro-linux-blueprint-gateway-raspberrypi4-64:~$ sudo journalctl -u otbr-agent.service
Apr 28 17:42:32 oniro-linux-blueprint-gateway-raspberrypi4-64 systemd[1]: Started OpenThread Border Router Agent.
Apr 28 17:42:38 oniro-linux-blueprint-gateway-raspberrypi4-64 otbr-agent[330]: sh: ipset: not found
```

Relate-to: https://gitlab.eclipse.org/eclipse/oniro-blueprints/transparent-gateway/meta-oniro-blueprints-gateway/-/issues/6
Cc: Stefan Schmidt <stefan.schmidt@huawei.com>
Forwarded: openembedded#611
Signed-off-by: Philippe Coval <philippe.coval.ext@huawei.com>
@Stefan-Schmidt
Copy link
Contributor

This looks good to me.

kraj pushed a commit to YoeDistro/meta-openembedded that referenced this pull request Sep 21, 2022
ipset is used by firewall module of ot-br-posix:

   third_party/openthread/repo/src/posix/platform/firewall.cpp:\
   return ExecuteCommand("%s add %s %s -exist", kIpsetCommand, aSetName, aAddress);

Related observed issue looked like:

```
oniro@oniro-linux-blueprint-gateway-raspberrypi4-64:~$ sudo journalctl -u otbr-agent.service
Apr 28 17:42:32 oniro-linux-blueprint-gateway-raspberrypi4-64 systemd[1]: Started OpenThread Border Router Agent.
Apr 28 17:42:38 oniro-linux-blueprint-gateway-raspberrypi4-64 otbr-agent[330]: sh: ipset: not found
```

Relate-to: https://gitlab.eclipse.org/eclipse/oniro-blueprints/transparent-gateway/meta-oniro-blueprints-gateway/-/issues/6
Cc: Stefan Schmidt <stefan.schmidt@huawei.com>
Forwarded: openembedded#611
Signed-off-by: Philippe Coval <philippe.coval.ext@huawei.com>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this pull request Sep 21, 2022
ipset is used by firewall module of ot-br-posix:

   third_party/openthread/repo/src/posix/platform/firewall.cpp:\
   return ExecuteCommand("%s add %s %s -exist", kIpsetCommand, aSetName, aAddress);

Related observed issue looked like:

```
oniro@oniro-linux-blueprint-gateway-raspberrypi4-64:~$ sudo journalctl -u otbr-agent.service
Apr 28 17:42:32 oniro-linux-blueprint-gateway-raspberrypi4-64 systemd[1]: Started OpenThread Border Router Agent.
Apr 28 17:42:38 oniro-linux-blueprint-gateway-raspberrypi4-64 otbr-agent[330]: sh: ipset: not found
```

Relate-to: https://gitlab.eclipse.org/eclipse/oniro-blueprints/transparent-gateway/meta-oniro-blueprints-gateway/-/issues/6
Cc: Stefan Schmidt <stefan.schmidt@huawei.com>
Forwarded: openembedded#611
Signed-off-by: Philippe Coval <philippe.coval.ext@huawei.com>
@kraj
Copy link
Contributor

kraj commented Sep 23, 2022

merged with fc8209e

@kraj kraj closed this Sep 23, 2022
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this pull request Apr 19, 2024
WirePlumber 0.5.1
~~~~~~~~~~~~~~~~~

Highlights:

  - Added a guide documenting how to migrate configuration from 0.4 to 0.5,
    also available online at:
    https://pipewire.pages.freedesktop.org/wireplumber/daemon/configuration/migration.html
    If you are packaging WirePlumber for a distribution, please consider
    informing users about this.

Fixes:

  - Fixed an odd issue where microphones would stop being usable when a
    Bluetooth headset was connected in the HSP/HFP profile (openembedded#598, !620)

  - Fixed an issue where it was not possible to store the volume/mute state of
    system notifications (openembedded#604)

  - Fixed a rare crash that could occur when a node was destroyed while the
    'select-target' event was still being processed (!621)

  - Fixed deleting all the persistent settings via ``wpctl --delete`` (!622)

  - Fixed using Bluetooth autoswitch with A2DP profiles that have an input route
    (!624)

  - Fixed sending an error to clients when linking fails due to a format
    mismatch (!625)

Additions:

  - Added a check that prints a verbose warning when old-style 0.4.x Lua
    configuration files are found in the system. (openembedded#611)

  - The "policy-dsp" script, used in Asahi Linux to provide a software DSP
    for Apple Sillicon devices, has now been ported to 0.5 properly and
    documented (openembedded#619, !627)

Signed-off-by: Markus Volk <f_l_k@t-online.de>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
halstead pushed a commit that referenced this pull request Apr 21, 2024
WirePlumber 0.5.1
~~~~~~~~~~~~~~~~~

Highlights:

  - Added a guide documenting how to migrate configuration from 0.4 to 0.5,
    also available online at:
    https://pipewire.pages.freedesktop.org/wireplumber/daemon/configuration/migration.html
    If you are packaging WirePlumber for a distribution, please consider
    informing users about this.

Fixes:

  - Fixed an odd issue where microphones would stop being usable when a
    Bluetooth headset was connected in the HSP/HFP profile (#598, !620)

  - Fixed an issue where it was not possible to store the volume/mute state of
    system notifications (#604)

  - Fixed a rare crash that could occur when a node was destroyed while the
    'select-target' event was still being processed (!621)

  - Fixed deleting all the persistent settings via ``wpctl --delete`` (!622)

  - Fixed using Bluetooth autoswitch with A2DP profiles that have an input route
    (!624)

  - Fixed sending an error to clients when linking fails due to a format
    mismatch (!625)

Additions:

  - Added a check that prints a verbose warning when old-style 0.4.x Lua
    configuration files are found in the system. (#611)

  - The "policy-dsp" script, used in Asahi Linux to provide a software DSP
    for Apple Sillicon devices, has now been ported to 0.5 properly and
    documented (#619, !627)

Signed-off-by: Markus Volk <f_l_k@t-online.de>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
daregit pushed a commit to daregit/yocto-combined that referenced this pull request May 22, 2024
ipset is used by firewall module of ot-br-posix:

   third_party/openthread/repo/src/posix/platform/firewall.cpp:\
   return ExecuteCommand("%s add %s %s -exist", kIpsetCommand, aSetName, aAddress);

Related observed issue looked like:

```
oniro@oniro-linux-blueprint-gateway-raspberrypi4-64:~$ sudo journalctl -u otbr-agent.service
Apr 28 17:42:32 oniro-linux-blueprint-gateway-raspberrypi4-64 systemd[1]: Started OpenThread Border Router Agent.
Apr 28 17:42:38 oniro-linux-blueprint-gateway-raspberrypi4-64 otbr-agent[330]: sh: ipset: not found
```

Relate-to: https://gitlab.eclipse.org/eclipse/oniro-blueprints/transparent-gateway/meta-oniro-blueprints-gateway/-/issues/6
Cc: Stefan Schmidt <stefan.schmidt@huawei.com>
Forwarded: openembedded/meta-openembedded#611
Signed-off-by: Philippe Coval <philippe.coval.ext@huawei.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants