fix PHP 8.2 warnings

openemr · Apr 30, 2024 · 902ae3e · 902ae3e
1 parent 029af98
commit 902ae3e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/src/Billing/BillingProcessor/BillingClaimBatch.php b/src/Billing/BillingProcessor/BillingClaimBatch.php
@@ -58,10 +58,10 @@ public function __construct(
         $this->bat_hhmm = date('Hi', $this->bat_time);
         $this->bat_yymmdd = date('ymd', $this->bat_time);
         $this->bat_yyyymmdd = date('Ymd', $this->bat_time);
-        $this->bat_icn = (strpos($this->context['claims'][0]->action, 'validate') !== false) ? '000000001' : BillingClaimBatchControlNumber::getIsa13();
+        $this->bat_icn = (strpos($this->context['claims'][0]->action ?? '', 'validate') !== false) ? '000000001' : BillingClaimBatchControlNumber::getIsa13();
         $this->bat_filename = date("Y-m-d-His", $this->bat_time) . "-batch" . $this->ext;
         $this->bat_filedir = $GLOBALS['OE_SITE_DIR'] . DIRECTORY_SEPARATOR . "documents" . DIRECTORY_SEPARATOR . "edi";
-        $this->bat_gs06 = (strpos($this->context['claims'][0]->action, 'validate') !== false) ? '2' : BillingClaimBatchControlNumber::getGs06();
+        $this->bat_gs06 = (strpos($this->context['claims'][0]->action ?? '', 'validate') !== false) ? '2' : BillingClaimBatchControlNumber::getGs06();
     }
 
     /**

diff --git a/src/Billing/X125010837I.php b/src/Billing/X125010837I.php
@@ -29,7 +29,13 @@ public static function generateX12837I($pid, $encounter, $x12_partner, &$log, $u
         $out = '';
         $claim = new Claim($pid, $encounter, $x12_partner);
         $edicount = 0;
-
+        // Qualify data array
+        if (!empty($ub04id)) {
+            for ($i = 0; $i < 428; ++$i) {
+                $ub04id[$i] = $ub04id[$i] ?? '';
+            }
+        }
+        // This is the start of the 837I claim
         $log .= "Generating 837I claim $pid-$encounter for " .
             $claim->patientFirstName() . ' ' .
             $claim->patientMiddleName() . ' ' .