Need help fixing bugs and enhancements.

[sjpadgett]

I beg some of our dev's pitching in and fixing bugs. They present a poor opinion by users for an otherwise great application.

• We need to decide if we will continue to support frames! Time is coming when the frame tag will no longer be supported by browsers. Plus as more development occurs, we're not testing and allowing for the framed feature. It's popular with our long standing users but time is coming to address.
• Layout editor must be addressed to prevent users from changing ID on our core forms. Helps and documentation does not work.
• Our procedure reports no longer work.
• Transaction report needs addressing to report better across facilities and providers.
• Restyle EDI's UI.
• Restyle most all reports.
• Fix all window popups (dialog as well) where window.close won't work because browsers have now locked down what is considered a security flaw in perceived cross-site scripting.
• One alert should suffice for CDR.
• Either prevent user that does not have Provider set in users from creating encounters or go through code and remover the provider flag in encounter lookups. To see problem: create encounter as a user that is not provider auth and take a look at what encounter history/summary shows as user for encounter ie not populated.
• Go through issues and fix at least one.
• Fix js null skiparray global in options inc. (LBF forms).

Seems like everytime I look to add something to code a bug pops ups. Please, if you see an issue, report it. Better yet fix it.

The faster issues are fixed, the faster 502 can be release and 502 is going to be a great release with some more help.

If you want to better understand code, track down some issues. I promise you can learn alot by one, seeing how other dev's approach development and two, it's rewarding!
Thanks..

Note: Turn on Users Debug in Globals->Logging. It will catch and notify many js errors normally not seen during development or testing. PHP errors will goto screen. Very handy...

[ghost]

1. We should not support iFrames. We need to get rid of them. I am more than happy to help / take point. How can I contribute to that @sjpadgett? I will make it a big big priority, and can turn it around in a few weeks if you have a plan / project scope I can follow.

2. Can you break out the other things you mentioned into separate issues with a paragraph of instructions for each? Maybe start with just 2 or 3 issues that you break out from this issue. I can find coders to do them if you can do that.

[sjpadgett]

Hi @danehrlich1 Thanks for replying.
Note that the frames i'm talking about is the html frameset and frame tags that have been around since html started but is not supported any longer with html5. They have been depreciate for awhile.
Also note I don't see a problem with iframes and maybe ES6 can aid you if you were to take on iframes but remember, our tabs interface is based largely on iframes.
Some of the issues i've outlined here already have an issue I believe. I know I created one for encounter a while back and discussed with Rod. The layout editor will require an experienced OpenEMR dev as that code can get involved but doable if someone was up to trying. I will see if I don't already have an issue up for it and add some guidance. Same with others.

[ghost]

Jerry: Ok got it. Thought you were talking about iframes so got super excited, but the other old stuff is cool to remove too and I will look into it Yes I don’t see a way out of iFrames at all, but if you ever see one, let me know.

…

Sent from my iPhone

On Mar 18, 2019, at 7:24 PM, Jerry Padgett ***@***.***> wrote: Hi @danehrlich1 Thanks for replying. Note that the frames i'm talking about is the html frameset and frame tags that have been around since html started but is not supported any longer with html5. They have been depreciate for awhile. Also note I don't see a problem with iframes and maybe ES6 can aid you if you were to take on iframes but remember, our tabs interface is based largely on iframes. Some of the issues i've outlined here already have an issue I believe. I know I created one for encounter a while back and discussed with Rod. The layout editor will require an experienced OpenEMR dev as that code can get involved but doable if someone was up to trying. I will see if I don't already have an issue up for it and add some guidance. Same with others. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[robertogagliotta]

Hi @sjpadgett
I tested the non provider user creating encounters
Physicians and Clinicians non providers are able to create the encounter, but the encounter does not show in the caLENDAR.
Front Office users are not able to create encounter because visit category drop down list is lock.
Probably these is the original design. I don't know. What do you think?

[sjpadgett]

@robertogagliotta Creating, permissions etc is not the issue but many of our lookups instead. ie if an encounter is created by a user w/o provider flag then most our lookups will not report the user as the owner of the encounter probably because the sqls use the provider flag as a delim for lookup.
Even the encounter history/summary doesn't display creator.

[robertogagliotta]

@sjpadgett
Prevent user that does not have Provider set in users from creating encounters is a good solution, I will dig into the code.

[sjpadgett]

@robertogagliotta I don't think that is going to work because many times a receptionist or LPN or someone doing the pre screening may not have provider status but wants to have encounter ready for doctor. thus creating and doing vitals etc.
We need to have some of our clinicians and/or doctors to give some guidance for best way to handle.
If up to me i'd say if user doesn't have provider flag set then they should not be able to create encounters. @bradymiller thoughts.

[robertogagliotta]

TRUE, when I go to see my doc. Some one else takes (clinician) my vitals first. Therefore the encounter needs to be created for the clinician/nurse. In this case the clinician should be provider. All the uses groups can be provider according to out Add User Interface.
The point is that users non providers have not able to create encounter.

[sjpadgett]

I'd say go ahead and look into changing encounter to alert if user is not a provider and lets see what Doctor Brady has to say.

…

On Tue, May 21, 2019 at 6:40 PM Roberto Vasquez ***@***.***> wrote: TRUE, when I go to see my doc. Some one else takes (clinician) my vitals first. Therefore the encounter needs to be created for the clinician/nurse. In this case the clinician should be provider. All the uses groups can be provider according to out Add User Interface. The point is that users non providers have not able to create encounter. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2293?email_source=notifications&email_token=AAOGDEPCL5IWJ7EXVQ557TDPWR243A5CNFSM4G7IYIG2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODV5MLQY#issuecomment-494585283>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAOGDEMI2I2EV4AGNH5U6HLPWR243ANCNFSM4G7IYIGQ> .

-- Jerry Padgett Padgett's Consulting Brandon, Florida 33511 sjpadgett@gmail.com <sjpadgett@gmailo.com>

[robertogagliotta]

Other option could be to look out the Create Visit tab when the user is non provider.
I ll check this option also.
We ll see what Brady say

[bradymiller]

Hi,
Recommend seeing how the encounter autogeneration works by grepping for is_tracker_encounter_exist() . Note it uses the provider from the appointment to autocreate the encounter. So, probably need a mechanism for a user that manually creates a encounter to set the provider for it.
-brady

[sjpadgett]

I believe I recently fixed that feature for creating more than one encounter for multi appointments in same day and it would be interesting to see if tracker is missing encounters due to provider flag not set.

[robertogagliotta]

Hi @sjpadgett @bradymiller
openemr dev allow only physicians to create encounter, the other access control groups cannot create encounters even if the clinician has being checked provider when the user/clinician was created.
I believe that what we want is to allow some access control groups/ clinicians to set the provider/physician and create the encounter
Is this the objective?

[robertogagliotta]

function is_tracker_encounter_exist($apptdate, $appttime, $pid, $eid)
$enc_yn = sqlQuery("SELECT encounter from patient_tracker WHERE apptdate = ? AND encounter > 0 " .
"AND eid = ? AND pid = ?", array($apptdate, $eid, $pid));
Table patient_tracker hold the provider in the "original_user" field; the function tracker_encounter_exist does not query the original_user or the provider that create the encounter. We may need other function to create the mechanism.

[robertogagliotta]

When we make the appointment in the calendar we enter the provider. This provider can be selected or changed in the create visit UI.
Some that needs to be modified also is the Administration Users-Create User Form allow to set Provider up to any group.

[sjpadgett]

Hi @robertogagliotta I checked most of our encounter references in reports etc and only have found this an issue with populating the encounter visit summary by field and certain CCM's API methods. I just did a fix in our patient.inc api and will included in my next PR.
Not sure if this issue pops up elsewhere, my gut says it will, the api fix will make it easy to address if it does.
If you're curious the culprit I decided on is the function getProviderName($providerID) in library/patient.inc. I added a flag to ignore users authorized flag in lookup call.
Thanks for looking at this issue.

[stale]

This issue has been automatically marked as stale because it has not had any recent activity within the past 90 days. It will be closed in 7 days if no further activity occurs.

[stale]

This issue has been automatically closed because it has not had any recent activity within the past 97 days.