Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSIE fails with tabs layout #525

Closed
sunsetsystems opened this issue Mar 7, 2017 · 11 comments
Closed

MSIE fails with tabs layout #525

sunsetsystems opened this issue Mar 7, 2017 · 11 comments

Comments

@sunsetsystems
Copy link
Member

sunsetsystems commented Mar 7, 2017

Testing with MSIE in Windows 10, I see the Tabs layout occupies the left 1/5 or so of the page, with the remainder blank. See attached image.
msie_tabs

@MatthewVita
Copy link
Member

@sunsetsystems
Copy link
Member Author

Well I get that, but MSIE still has close to 20% market share. If one little bug makes it unusable it should be fixed.

@bradymiller
Copy link
Sponsor Member

I vote for a fix :)

@sjpadgett
Copy link
Member

Will most likely need to wrap iframe in div.

@sjpadgett
Copy link
Member

Here is a fix that works for me in Edge. Add a width to frame in tabs_style_???.css
#framesDisplay > div > iframe
{
flex: 1 0 auto;
border: 0px solid black;
width: 100%
}

@sunsetsystems
Copy link
Member Author

Awesome. That works for me too.

@sunsetsystems
Copy link
Member Author

Jerry why don't you make a PR so you'll get credit for it.

@sjpadgett
Copy link
Member

okay, just going to test in chrome then I'll put it up.

@MatthewVita
Copy link
Member

Nice fix! Btw, I am for a fix, I was just noting the supported browsers so one doesn't spend too much time on this (I'm sure at least 1/4th of my craziness comes from trying to support IE in my relatively short career so far :) )

@robertdown
Copy link
Member

@sjpadgett have you had a chance to submit a PR for this?

@MatthewVita Would be great to drop support for MSIE (It's a dead browser ((would still have to support Edge))) but I imagine that's a losing battle :)

@bradymiller
Copy link
Sponsor Member

Sorry, we forgot to close this. The PR for this was submitted and accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants