-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSIE fails with tabs layout #525
Comments
Well I get that, but MSIE still has close to 20% market share. If one little bug makes it unusable it should be fixed. |
I vote for a fix :) |
Will most likely need to wrap iframe in div. |
Here is a fix that works for me in Edge. Add a width to frame in tabs_style_???.css |
Awesome. That works for me too. |
Jerry why don't you make a PR so you'll get credit for it. |
okay, just going to test in chrome then I'll put it up. |
Nice fix! Btw, I am for a fix, I was just noting the supported browsers so one doesn't spend too much time on this (I'm sure at least 1/4th of my craziness comes from trying to support IE in my relatively short career so far :) ) |
@sjpadgett have you had a chance to submit a PR for this? @MatthewVita Would be great to drop support for MSIE (It's a dead browser ((would still have to support Edge))) but I imagine that's a losing battle :) |
Sorry, we forgot to close this. The PR for this was submitted and accepted. |
Testing with MSIE in Windows 10, I see the Tabs layout occupies the left 1/5 or so of the page, with the remainder blank. See attached image.
The text was updated successfully, but these errors were encountered: