tracking standard header code walk through #635
Comments
|
Reports->Visits->Superbill will take extra effort, so will skip this for now. |
|
Reports->Visits->Eligibility Response was skipped since only an upload element there and unable to test. |
|
wooohooo, @robertdown added a full bootstrap conversion example to the following PR: |
|
Reports->Procedures->Statistics was skipped since will require more extensive work.. |
|
Hi Brady, Robert |
|
Hi @robertogagliotta - I'll write up some documentation later tonight so you can get started. Looking forward to your help! |
|
@robertogagliotta , And I'll look through openemr this evening to find a good script to start with. -brady |
|
Hi @robertogagliotta , 2 good simple scripts to learn bootstrap support are on: See the SOAP conversion to get an idea of what we are doing in conversion (note this was in smarty code, which is a little different than the pure php of the above scripts): I do the following steps when convert:
(this is a nifty script that brings in all the standard assets including the css_header and sets up bootstrap; so can remove the include of the css_header in these scripts)
I warn you. Converting to bootstrap is addictive because it's super cool to watch a gui go from legacy to modern and responsive (responsive meaning that as the web browser gets smaller, the positioning of the elements respond; as an example, see what happens on both the SOAP form and the Encounter->procedure order form when you make the browser width smaller). There is a bit of a learning curve and I still am trying to climb it also (and this is why we have @robertdown :) ) -brady |
|
… On Tue, May 23, 2017 at 12:17 AM, Brady Miller ***@***.***> wrote:
Hi @robertogagliotta <https://github.com/robertogagliotta> ,
2 good simple scripts to learn bootstrap suppoer are on:
Popups->Export
(custom/export_xml.php starting at line 253)
Popups->Import
(custom/import_xml.php starting at line 191)
(not need to have a patient selected to open these)
See the SOAP conversion to get an idea of what we are doing in conversion
(note this was in a smarty code):
https://github.com/openemr/openemr/pull/741/files
I do the following steps when convert:
1. bring in the standard asset header template:
require "{$GLOBALS['srcdir']}/templates/standard_header_template.php";
(this is a nifty script that brings in all the standard assets including
the css_header and sets up bootstrap; so can remove the include of the
css_header in these scripts)
1.
deconstruct the html styling element. In this case, remove the 'p' and
'center' html tags.
2.
then use bootstrap classes and div (basically try to mimick the
class/div structure in the above SOAP form link); and when you are doing
this google search the bootstrap classes and divs to begin to get an idea
of what it all means(this was very helpful for me to begin to learn this
stuff).
3.
Bring in the new button style (this is really neat and I'll point out
how to do this on the first review; note can try to mimick what is done in
SOAP here also)
4.
convert script to new security model (this will just be a couple line
changes, which I will point out on the review)
I warn you. Converting to bootstrap is addictive because it's super cool
to watch a gui go from legacy to modern and responsive (responsive meaning
that as the web browser gets smaller, the positioning of the elements
respond; as an example, see what happens on both the SOAP form and the
Encounter->procedure order form when you wake the browser width smaller).
There is a bit of a learning curve and I still am trying to climb it also
(and this is why we have @robertdown <https://github.com/robertdown> :) )
-brady
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#635 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFBzEPs-FVBuZBh7sYjMxfedlRSKRa8Mks5r8ofwgaJpZM4M5qqp>
.
|
|
Can close this since this is being taken care of in the bootstrap update PR. |
Project to standardize headers of assets and bring in bootstrap.
More details can be found on this PR:
#587
Some more work from above commit on the patient_list.php report:
d606eb8
Note added fontawesome ti it here:
97b2670
And here is example using it in procedure order form:
434e449
Planning to walk through the codebase with this template (have completed the reports and now working on others)
The text was updated successfully, but these errors were encountered: