Mod to base url structure #1232
Conversation
|
Just set up a Up For Grabs demo for this at: |
|
@bradymiller Forcing protocol works as I expected. Not too worried I have to do this for Docker Demo's and I suggest you setup a rewrite rule for the ngnix or set the forwarded super somehow but, I am a little concerned with the AWS install whether that environment carries along the https protocol supers. I'm pretty sure it needs to be handled because of the load balancing or proxies. I think the acceptable solution for indicating SSL via redirects is using/setting the $_SERVER['HTTP_X_FORWARDED_PROTO']( I don't mind being educated here ). |
|
@sjpadgett , I gotta read up on this. Sounds like you at least got it working on the demo farm with the https force. I'll research the HTTP_X_FORWARDED_PROTO stuff. |
|
I'll fix the travis errors but this isn't really a solution. This situation
will come up again even if I re-write portal rest interface(calendar comes
to mind). I'm just worried if I write a new controller just for the one
form and just to satisfy a relative path, the issue will still remain and
will come up again. This I am sure of..
…On Fri, Nov 17, 2017 at 5:11 AM, Brady Miller ***@***.***> wrote:
@sjpadgett <https://github.com/sjpadgett> , I gotta read up on this.
Sounds like you at least got it working on the demo farm with the https
force. I'll research the HTTP_X_FORWARDED_PROTO stuff.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1232 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABxhkYkYbTObbb_WBhRa-6o9610fneTaks5s3Vu6gaJpZM4QhV4P>
.
--
Jerry Padgett
Padgett's Consulting
Brandon, Florida 33511
sjpadgett@gmail.com <sjpadgett@gmailo.com>
|
|
@bradymiller I don't know why I didn't think of sooner but I'll just handle my url builder same way I did for the calendar classes and exclude the protocol..duh. Surprise you didn't catch me on that. So Doctor, is there a pill for senility? Thank goodness you're a patient man... |
This reverts commit d9f99fa.
|
@bradymiller Fingers crossed this will work with Docker thus should be okay for AWS. Reset my up for grab and I can test both eye and this. |
|
Demo has been restarted. |
|
@bradymiller Finally, Looks like we're good to go. Once again, thank you for the help and patience... |
|
Great! Do we still need the global? |
|
Most likely not. Works on my Linux and windows box plus docker as relative
base paths however:) that global allows me to turn on a protocol/host url
just in case, so I want to keep for now.
…On Sat, Nov 18, 2017 at 6:22 PM, Brady Miller ***@***.***> wrote:
Great! Do we still need the global?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1232 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABxhkd55yEk_gDmiI-t1_BQdX9tHc_ecks5s32bMgaJpZM4QhV4P>
.
--
Jerry Padgett
Padgett's Consulting
Brandon, Florida 33511
sjpadgett@gmail.com <sjpadgett@gmailo.com>
|
|
Just brought it in. Thanks for the fix! -brady |
Trying to live in Docker and AWS world. @bradymiller Think you could get this on demo site or my up for grab? I can use relative pathing to a point for my rest api calls but depending where my call originates, I may need base path, especially if sharing same controller between two app's(Openemr and portal). Proxies, Redirects and load balancer's tend to leave a trail and hoping it is with HTTP_X_FORWARDED_PROTO and if not I put a flag in Globals to force proper protocol....
(below added by bradymiller)
Demo: http://www.open-emr.org/wiki/index.php/Development_Demo#Epsilon_-_Up_For_Grabs_Demo