Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

font-awesome #136

Closed
wants to merge 3 commits into from
Closed

font-awesome #136

wants to merge 3 commits into from

Conversation

robertdown
Copy link
Member

Add font-awesome in a new folder (interface/static) which will hold all our global CSS/JS files and change the icons on the left menu

@bradymiller
Copy link
Sponsor Member

Hi Robert,
This looks very nice. Recommend posting this on the forum to ensure community is ok with the path where storing the font-awesome library.
-brady

@olegsv
Copy link

olegsv commented Jun 9, 2016

@robertdown nice work.
Why do you think we need to bring SCSS source files under the same folder?

@robertdown
Copy link
Member Author

robertdown commented Jun 9, 2016

@olegsv The font-awesome folder is the full font-awesome download, installed via the Bower package manager. It contains everything they provided, I did not add, remove, or change anything. We could strip out everything but the final build, but since we aren't making any changes to the library I think we should just leave everything the way it is.

@bradymiller this was already discussed in the forums. interface/static will represent external files/libraries such as bootstrap and font-awesome. https://sourceforge.net/p/openemr/discussion/202506/thread/53f41e90/#5ec5/ef11/166d/06a3/9ecb/6d5d

Note I added a .bowerrc and bower.json file that helps to manage this

@robertdown
Copy link
Member Author

Link doesn't seem to be working... it's on that thread, page 4, about halfway down

@@ -0,0 +1,20 @@
{
"name": "openemr",
"homepage": "http://open-emr.dev",
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be open-emr.org ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robertdown
Copy link
Member Author

Note I just rebased the latest changes from master onto this branch and did a force push. Still no conflicts :)

@bradymiller
Copy link
Sponsor Member

Hi Robert,

I just rebased these commits into 1 commit and brought it into the main codebase.

I also created a bower wiki page here to track things and not "lose" this feature: http://www.open-emr.org/wiki/index.php/OpenEMR_Wiki_Home_Page#Embedded_Components

I am guessing bootstrap will be next :)

-brady

@openemr openemr closed this Jun 14, 2016
@robertdown robertdown deleted the fontawesome branch May 11, 2017 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants