Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed directory names to match lowercase standard #158

Closed
wants to merge 1 commit into from

Conversation

Wakie87
Copy link
Member

@Wakie87 Wakie87 commented Jul 17, 2016

No description provided.

@bradymiller
Copy link
Sponsor Member

This makes me very nervous, because there are likely lots of downstream links dependent on this. I used to believe that all paths and names needed to be lowercase, but then I realized things work just fine in cases where classes and packages (including the paths) use uppercase a lot. Do you know of situation where things break when not using lowercase?

@robertdown
Copy link
Member

Disagree with this PR. Symfony, ZF2, and plenty of other large libraries use uppercase folders throughout the keep things in line with namespaces and classes. My logger code (and subsequent modernization code) will do the same thing (i.e. Patient/src/Patient/Demographics.php).

PHP-FIG PSRs don't seem to take a stand on this. Those are the standards I suggest we stick to (will post on forums separately about the PSR standards).

@bradymiller
Copy link
Sponsor Member

Too funny. I just sent Scott a message on slack that I was warming up to this commit.

@bradymiller
Copy link
Sponsor Member

As long as we follow the standards or change to the standards, if needed. Is there a nice site that covers the PSR standards (will link this in the Modernization wiki page).

@robertdown
Copy link
Member

@bradymiller
Copy link
Sponsor Member

thanks,
I posted the link on the modernization wiki page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants