Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong passed variable name #1609

Merged
merged 1 commit into from May 7, 2018
Merged

Conversation

sjpadgett
Copy link
Sponsor Member

oops

@sjpadgett sjpadgett merged commit bf555e9 into openemr:master May 7, 2018
@sjpadgett
Copy link
Sponsor Member Author

@bradymiller Quick question. Wht do we need to run code travis compliance checks on all versions of PHP we support? Why not just PHP 7.1 or 7.2 because if it fails for one it fails for all.

bradymiller pushed a commit that referenced this pull request May 7, 2018
@bradymiller
Copy link
Sponsor Member

@sjpadgett , agreed on the styling checks.
@TheToolbox , does it make sense to only have the travis styling check run through one version of php (and keep the syntax checks for all versions of php)?

@TheToolbox
Copy link
Contributor

Makes sense to me. After a quick review I don't thiiiiink I see anything in styling that should vary between versions. Is travis taking too long?

@sjpadgett
Copy link
Sponsor Member Author

Seem's so. Plus I think it adds some confusion to some as to what to fix where.

@bradymiller
Copy link
Sponsor Member

bradymiller commented May 8, 2018

It significantly increases travis time to run these seemingly redundant checks (since PSR2 is not different between PHP versions). Sometimes I need to wait 15 minutes to be able to push my PR :)

@sjpadgett sjpadgett deleted the fax-fix2 branch July 20, 2018 20:44
sloboy pushed a commit to sloboy/openemr that referenced this pull request Sep 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants