made tabs bold #1656
Closed
made tabs bold #1656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradymiller
reviewed
May 23, 2018
| @@ -26,7 +26,7 @@ | |||
| </div> | |||
| <!-- ko foreach: tabsList --> | |||
| <div class="tabSpan bgcolor2" data-bind="click: tabClicked, css: {tabNotchosen: !visible()}"> | |||
| <span class="tabTitle" data-bind="text: title, click: tabClicked, css: {tabHidden: !visible()}"></span> | |||
| <b><span class="tabTitle" data-bind="text: title, click: tabClicked, css: {tabHidden: !visible()}"></span></b> | |||
There was a problem hiding this comment.
I think this is best to do in styling; and rec doing that in a day or 2 after the new styling engine by @d3sandoval is in place:
#1651
There was a problem hiding this comment.
Yup! This can be done by using the font-weight rule in the tabTitle selector
There was a problem hiding this comment.
ok,
I saw that the PR has been merged.
With the new engine, where is the proper place to add css which is relevant to all themes (and not just a specific one)?
thanks
There was a problem hiding this comment.
OH MAN
I just saw I mistakenly uploaded the sql conf file.
I'll fix this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
made tab titles bold like the menu titles