Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New build docs #1837

Merged
merged 54 commits into from Sep 15, 2018
Merged

New build docs #1837

merged 54 commits into from Sep 15, 2018

Conversation

DreaminDani
Copy link

Sorry for the ridiculous amount of commits. This was branched off of an earlier unmerged branch.

The purpose of this PR is to bring in better documentation and local workflows for working with docker and stylesheets.

docker-compose up from the root directory now provide a sane build that mounts all changes. Running npm run dev-sync from root will allow the user to see changes to stylesheets automatically, without having to reload the page.

See this video for an example.

Once openemr/openemr-devops#155 is merged, the docker-compose file at the root should be updated to use an image instead of a local path to the openemr-devops repo.

```
FLEX_REPOSITORY: https://github.com/[my_user_name]/openemr.git
FLEX_REPOSITORY_BRANCH: master
```
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the git repo/branch in step 2 need to align with the repo/branch set up in step 3?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. They can be different. It should probably be updated to openemr/openemr master branch before this is merged

@bradymiller
Copy link
Sponsor Member

Super exciting stuff. Rec following prep to get it ready for codebase:

  1. changing to openemr/openemr master branch as default
  2. assume that the flex-edge docker will be ready to go
    (plan to then bring in this after that is set up and available)

@DreaminDani
Copy link
Author

@bradymiller made the updates you've requested! Please bring this in after openemr/openemr-devops#155 is merged :)

@bradymiller
Copy link
Sponsor Member

hi @d3sandoval ,
Dockers are updated, so gonna bring this in now. Thanks for yet another awesome contribution!
-brady

@bradymiller bradymiller merged commit 7657a73 into openemr:master Sep 15, 2018
@bradymiller
Copy link
Sponsor Member

hi @d3sandoval ,

Just tried this out and simply awesome. Note the flex-edge environment was throwing an error:
m ERR! cb() never called!
(this happened when it tried to call npm and then failed out)

I fixed this by changing the flex-edge tag to just flex (this goes to the most recent stable alpine version which is now flex-3.8).

I also added the ccdaservice dir to be a shared drive since it gets built out in the flex dockers.

Here's the commit I just brought in with these changes:
8611bf5

-brady

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants