Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class reorganization #2449

Merged
merged 3 commits into from May 25, 2019
Merged

Class reorganization #2449

merged 3 commits into from May 25, 2019

Conversation

bradymiller
Copy link
Sponsor Member

@bradymiller bradymiller commented May 25, 2019

@adunsulag
Copy link
Sponsor Member

We won't pull this into 5.0.2 right? Or do you think it will be part of that?

@bradymiller
Copy link
Sponsor Member Author

So far testing really well (gotta do more code analysis/testing to ensure not missing any paths). Ideally would get this in for 5.0.2 or else patches will be really tough (if master had reorg code and 5.0.2 didn't, then would make it much more difficult to patch code over from master to 5.0.2 for patches).

@bradymiller
Copy link
Sponsor Member Author

(this is assuming that this reorg is helpful)

@adunsulag
Copy link
Sponsor Member

@bradymiller Your right patches will be difficult if people are modifying the code which I wasn't thinking about that. The reorg is very helpful as people can start adding additional classes and they are just auto-loaded. Makes it better for Matrix and others to minimize composer.json conflicts.

@bradymiller
Copy link
Sponsor Member Author

Testing well and bringing this in. Another step towards modern code :)
And giving a shout out to @Wakie87 for starting all this composer stuff!

@bradymiller bradymiller merged commit dc351b0 into openemr:master May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants