gacl code cleanup #2894
Merged
gacl code cleanup #2894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradymiller
commented
Jan 21, 2020
library/classes/gacl/gacl.class.php
Outdated
| require_once(dirname(__FILE__) . "/../../../library/sqlconf.php"); | ||
| require_once(dirname(__FILE__) . "/../../../vendor/adodb/adodb-php/adodb.inc.php"); | ||
| require_once(dirname(__FILE__) . "/../../../vendor/adodb/adodb-php/drivers/adodb-mysqli.inc.php"); | ||
| require_once(dirname(__FILE__) . "/../../../library/ADODB_mysqli_mod.php"); |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
GACL seriously needs a makeover tbh |
bradymiller
commented
Jan 21, 2020
| /* | ||
| * Path to ADODB. | ||
| */ | ||
|
|
||
| if ( !defined('ADODB_DIR') ) { | ||
| define('ADODB_DIR', dirname(__FILE__).'/../vendor/adodb/adodb-php'); | ||
| } |
There was a problem hiding this comment.
Looked into why above is needed and decided to keep as is.
bradymiller
commented
Jan 21, 2020
| require_once(dirname(__FILE__) . "/../../library/sqlconf.php"); | ||
| require_once(dirname(__FILE__) . "/../../vendor/adodb/adodb-php/adodb.inc.php"); | ||
| require_once(dirname(__FILE__) . "/../../vendor/adodb/adodb-php/drivers/adodb-mysqli.inc.php"); | ||
| require_once(dirname(__FILE__) . "/../../library/ADODB_mysqli_mod.php"); |
There was a problem hiding this comment.
Looked into why above is needed and decided to keep as is.
bradymiller
added
Status: Needs Work
Status: Needs Review
and removed
Status: Needs Work
labels
Converted to psr4 classes and codebase changes supporting that.
bradymiller
force-pushed
the
gacl-clean-up_1
branch
from
ae51196
to
4ac4b59
Compare
|
This is testing well and plan to bring in soon (crossing fingers it will be easy merge to bootstrap PR :) ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gacl code cleanup