Refactor #3700: refine dashboard disclosures page #3701
Conversation
Add the bootstrap grid system, form and table style. Follow the OpenEMR current style guide. Remove outdated code. issue openemr#3700
| <input type='entry' size='20' class='datepicker form-control' name='dates' id='dates' value='<?php echo attr($disc_date);?>'/> <?php | ||
| } else { | ||
| ?> <input type='entry' size='20' class='datepicker form-control' name='dates' id='dates' value=''/> <?php |
There was a problem hiding this comment.
Hi @bradymiller and @tywrenn
I guess the type="entry" is invalid code syntax. What do I replace?
There was a problem hiding this comment.
There are so many of these in the codebase that this will need to be a separate PR.
| ?> <input type="entry" class="form-control" name="recipient_name" size="20" value="<?php echo attr($recipient_name); ?>" /> | ||
| <?php | ||
| } else {?> | ||
| <input type="entry" class="form-control" name="recipient_name" size="20" value="" /> | ||
| <?php |
There was a problem hiding this comment.
Hi @bradymiller and @tywrenn
I guess the type="entry" is invalid code syntax. What do I replace?
There was a problem hiding this comment.
There are so many of these in the codebase that this will need to be a separate PR.
There was a problem hiding this comment.
Did you mean to create a PR and focus on removing the type="entry" ?
There was a problem hiding this comment.
Yeah and replacing it with type="text"
|
@stu01509 Looks like you need to rebase your branch before I can test this |
|
Thanks for your mention, resolved. |
|
@tywrenn Such as this one?
|
|
@stu01509 That's correct. |
|
Updated the commit.
|
tywrenn
added
Status: Ready for Integration
Status: Reviewed
and removed
Status: Needs Review
labels
|
|
Fixes #3700
Short description of what this resolves:
Refine the dashboard disclosures pages.
Add the bootstrap grid system, form, and table style.
Follow the OpenEMR current style guide.
Remove outdated code.