Fix medex navbar overflow #3732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stu01509
force-pushed
the
fix-medex-navbar-overflow
branch
from
2505bf2
to
e964469
Compare
|
Update the commit. In Firefox:
In chrome:
|
stu01509
commented
Jul 28, 2020
library/MedEx/API.php
Outdated
Comment on lines
1524
to
1527
| <div id="hide_nav" style="<?php if ($setting_bootstrap_submenu == 'hide') { | ||
| <div id="hide_nav" class="mt-3" style="<?php if ($setting_bootstrap_submenu == 'hide') { | ||
| echo "display:none;"; } ?>"> | ||
| <nav id="navbar_oe" class="bgcolor2 fixed-top navbar-expand-md navbar-custom navbar-bright navbar-inner" name="kiosk_hide" data-role="page banner navigation"> | ||
| <!-- Brand and toggle get grouped for better mobile display --> |
There was a problem hiding this comment.
Hi @tywrenn and @bradymiller
In my opinion, this arrow button is unnecessary, because the navbar already has the toggle to collapse or show.
What do you think?
There was a problem hiding this comment.
I agree, it seems like an outdated measure for mobile devices that we used to do. You can go ahead and remove it.
There was a problem hiding this comment.
@tywrenn update the commit, please take a look.
|
@stu01509 Please rebase this to master |
|
Hi @tywrenn Please check again :) |
tywrenn
added
Status: Ready for Integration
Status: Reviewed
and removed
Status: Needs Review
labels
|
I think Brady is working on patch 4. If you're okay with this, i'll bring in to prevent conflicts with other ongoing PRs.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
Fix the medex navbar overflow.
Before:
After:
