Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some portal cleanup and fixes #4221

Merged
merged 4 commits into from Feb 6, 2021
Merged

Conversation

sjpadgett
Copy link
Sponsor Member

Fixes #4218

Short description of what this resolves:

Some feature changes and portal not starting, logging.

Changes proposed in this pull request:

  • add portal session destroy in session utils to prevent logging to system log.
  • remove unneeded demographics
  • fix layout excludes!!!
  • default providers to Admin
  • only allow/list providers that have portal auth in their users permissions
  • fix register again!

- add portal session destroy in session utils to prevent logging to system log.
- remove unneeded demographics
- fix layout excludes!!!
- default providers to Admin
- only allow/list providers that have portal auth in their users permissions
- fix register again!
@sjpadgett
Copy link
Sponsor Member Author

@bradymiller i'm leaving patch out stuff in source. I need the reminders later.

@sjpadgett sjpadgett self-assigned this Feb 5, 2021
@sjpadgett
Copy link
Sponsor Member Author

This PR enforces that a user has their Portal User check selected and authorized in users dialog for Profile and just portal permission is required for Secure Messaging provider selection and send to.
This is so one could setup practice so any non authorized user can manage portal mail and forward to physician that needs messages attention or handle themself. I'd imagine this would be preferred by physicians!

However, I have to dust off my angular skills and fix up messaging as somehow it no longer works as designed and needs to be seamless without any instructionals except setup.

@bradymiller
Copy link
Sponsor Member

tenor99

- fix portal secure messaging
- minor nitpick of utility escaping function vars
@sjpadgett
Copy link
Sponsor Member Author

sjpadgett commented Feb 6, 2021

We need to rethink recommend FF as default browser! They've messed up debugger, they style different than Chrome or Edge(Edge uses Chromes engine now) but lax with ES!
Does anyone think this will be my last go around with portal? Tired of it for now so bringing in.
oh, folks have my permission to work on it, hint!:)

@gutiersa
Can you add any of this to your wiki.

@sjpadgett sjpadgett merged commit 0685a72 into openemr:master Feb 6, 2021
@sjpadgett sjpadgett deleted the portal-fixes branch February 6, 2021 15:50
@stephenwaite
Copy link
Sponsor Member

seems like everyone is supporting Chrome first and even internet explorer before FF

@stephenwaite
Copy link
Sponsor Member

even on the certified health products page it's ranked last :)
Screenshot from 2021-02-07 00-07-39

@gutiersa
Copy link
Contributor

gutiersa commented Feb 8, 2021 via email

@gutiersa
Copy link
Contributor

gutiersa commented Feb 10, 2021

@sjpadgett
Let me ask, are we recommending browsers in this order for everyone, or is it just for developers?
Is it for all hardware, or just laptop and desktops?
On occasion, I look at my schedule on my cell phone.
I would like to be as specific as possible on the manual/wiki.
Thanks

sjpadgett added a commit that referenced this pull request Feb 16, 2021
* Some portal cleanup and fixes
- add portal session destroy in session utils to prevent logging to system log.
- remove unneeded demographics
- fix layout excludes!!!
- default providers to Admin
- only allow/list providers that have portal auth in their users permissions
- fix register again!

* - only allow auth portal providers in mail.

* - add CurrentDate and CurrentTime tags to both template downloads
- fix portal secure messaging
- minor nitpick of utility escaping function vars

* - style compromise between FF, Chrome!

(cherry picked from commit 0685a72)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Portal broken
4 participants