Update ORDataObject persist method #4862
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since metaColumns provides all properties about the field, this will provide opportunity to eliminate or at least limit use of sequences counter.
Do not set sequences value for auto_incremented keys.
|
Just a suggestion - extensive testing needed since it is probably used by legacy code. The optional block allows for 'id' in tables like documents to be auto_incremented rather than use of global 'sequences'. |
|
This issue has been automatically marked as stale because it has not had any recent activity within the past 90 days. It will be closed in 7 days if no further activity occurs. |
This change 1. Eliminates the use of 'REPLACE' statement. 2. Allows incremental transition to autoincremented primary key.
Styling fixes.
|
This issue has been automatically marked as stale because it has not had any recent activity within the past 90 days. It will be closed in 7 days if no further activity occurs. |
|
This issue has been automatically closed because it has not had any recent activity within the past 97 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use metaColumns function to get field objects.