limit access to reports for front and back office #4893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradymiller
reviewed
Feb 12, 2022
acl_upgrade.php
Outdated
| AclExtended::shiftAcl($accounting_view, 'Accounting', 'patients', 'Patients', 'pat_rep', 'Patient Report', 'view'); | ||
| AclExtended::shiftAcl($frontoffice_view, 'Front Office', 'patients', 'Patients', 'pat_rep', 'Patient Report', 'view'); | ||
| AclExtended::shiftAcl($frontoffice_wsome, 'Front Office', 'patients', 'Patients', 'trans', 'Transactions (write,wsome optional)', 'wsome'); | ||
| AclExtended::shiftAcl($frontoffice_wsome, 'Front Office', 'patients', 'Patients', 'notes', 'Patient Notes (write,wsome optional)', 'wsome'); |
There was a problem hiding this comment.
would put these in below category Update the ACLs
Otherwise:
bradymiller
reviewed
Feb 12, 2022
acl_upgrade.php
Outdated
| // Upgrade for acl_version 12 | ||
| $upgrade_acl = 12; | ||
| if ($acl_version < $upgrade_acl) { | ||
| echo "<B>UPGRADING ACCESS CONTROLS TO VERSION " . $upgrade_acl . ":</B></BR>"; | ||
|
|
||
| //Collect the ACL ID numbers. | ||
| echo "<B>Checking to ensure all the proper ACL(access control list) are present:</B></BR>"; | ||
| $accounting_view = AclExtended::getAclIdNumber('Accounting', 'view'); | ||
| $frontoffice_view = AclExtended::getAclIdNumber('Front Office', 'view'); | ||
| $frontoffice_wsome = AclExtended::getAclIdNumber('Front Office', 'wsome'); |
There was a problem hiding this comment.
looks like modifying write acl and not the wsome acl in install_gacl() changes
bradymiller
reviewed
Feb 12, 2022
| @@ -1017,7 +1017,7 @@ public function install_gacl() | |||
| // xl('Things that front office can read and partly modify') | |||
| $gacl->add_acl( | |||
| array( | |||
| 'patients' => array('appt', 'demo', 'trans', 'notes'), | |||
| 'patients' => array('appt', 'demo'), | |||
There was a problem hiding this comment.
note these changes are in the front office write acl and not the wsome acl
bradymiller
reviewed
Feb 12, 2022
| } | ||
|
|
||
| return; | ||
| } |
bradymiller
reviewed
Feb 13, 2022
acl_upgrade.php
Outdated
| AclExtended::shiftAcl($accounting_view, 'Accounting', 'patients', 'Patients', 'pat_rep', 'Patient Report', 'view'); | ||
| AclExtended::shiftAcl($frontoffice_view, 'Front Office', 'patients', 'Patients', 'pat_rep', 'Patient Report', 'view'); | ||
| AclExtended::shiftAcl($frontoffice_wsome, 'Front Office', 'patients', 'Patients', 'trans', 'Transactions (write,wsome optional)', 'write'); | ||
| AclExtended::shiftAcl($frontoffice_wsome, 'Front Office', 'patients', 'Patients', 'notes', 'Patient Notes (write,wsome optional)', 'write'); |
There was a problem hiding this comment.
above 2 lines change to $frontoffice_write
There was a problem hiding this comment.
also need to increment $v_acl in version.php
if testing well after fixes, then ready for codebase :)
|
testing well |
bradymiller
approved these changes
Feb 14, 2022
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
limit access to reports for front and back office