Openemr fix 5665 vitals being squashed #5668
Conversation
Big overhaul of vitals from changing it from smarty to twig format. Cleaned up a lot of the rendering as well so we can both easily extend the vitals form and handle additional fields. This is prep work to make the form responsive. Added some additional extension to twig so we could handle the wierd date formats for the vital forms.
Prevent the form from being squashed up and move the historical data into its own section further down in the form. Fix some minor twig issues.
|
@stephenwaite I'd love your feedback on this if you want to give it a whirl and see if you think it addresses the problems that Nerik was having. |
Forgot to remove the smarty controller class now that we are no longer using any of the smarty templates.
|
I wonder how important the historical table view is to clinicians? From my experience with my doctors they seem to always bring up a graph. |
|
Up For Grabs demo (includes the standard demo data) for this PR is at: https://www.open-emr.org/wiki/index.php/Development_Demo#Epsilon_-_Up_For_Grabs_Demo |
|
@sjpadgett , getting to historical view is very helpful and dependent on specialist. For myself, I usually just care about weight changes over time, which is one of the first things i look at when prepping. |
|
On testing on the up for grabs demo. Note the timestamps are messed up for the demo patients and old demo data; this is not a new issue, so can disregard that. The graphing appears to not be working, for example, should see the bp data graphed here: (can see graphing when click on 'Click here to view and graph all vitals.' in patient summary vitals widget; if have more than 1 data point fro BP then it will show bp; and can click on other rows to see other data graphed ) |
|
@bradymiller Thanks for catching that, I'll work on a fix for the graphing. |
|
@adunsulag , disregard my report of the broken vitals graphing. It is working the same as prior to your changes. The reason it was not working in my testing is that graph goes blank if vitals are too close together (ie. less than 1 minute), which is the same behavior as prior to this PR (ie. a preexisting bug). I'll do a more detailed code review of this later today will goal of getting this into patch 2 to give it a bit more time for testing (planning to release patch 1 today). |
| @@ -21,8 +21,10 @@ | |||
| use OpenEMR\Common\Uuid\UuidRegistry; | |||
| use OpenEMR\Services\VitalsService; | |||
| use OpenEMR\Services\ListService; | |||
| use OpenEMR\Common\Twig\TwigContainer; | |||
| use Twig\Environment; | |||
There was a problem hiding this comment.
can't see where class in above line is used
|
|
||
| class C_FormVitals extends Controller | ||
| class C_FormVitals |
| <head> | ||
| <title>{{ "Vitals"|xlt }}</title> | ||
| {{ setupHeader(["datetime-picker","reason-code-widget"]) }} | ||
| <!--Update the version (v flag) to cache bust if you modify this file --> |
There was a problem hiding this comment.
can drop above comment
| console.error("Failed to find vitalsForm object to initialize javascript vitals form"); | ||
| } | ||
| </script> | ||
| <!--Update the version (v flag) to cache bust if you modify this file --> |
There was a problem hiding this comment.
can drop above comment
| </div> | ||
| {% endif %} | ||
| <div class="col-sm-12"> | ||
| <form id="vitalsForm" name="vitals" method="post" action="{{ FORM_ACTION }}/interface/forms/vitals/save.php"> |
| <td colspan='2' class="text-center pt-2"> | ||
| {% endif %} | ||
| <input type="button" class="btn btn-primary" id="pdfchart" value='{{ "Growth-Chart"|xla }} ({{ "PDF"|xlt }})'> | ||
| <input type="button" class="btn btn-primary" id="htmlchart" value='{{ "Growth-Chart"|xla }} ({{ "HTML"|xlt }})'> |
There was a problem hiding this comment.
xla for the PDF and HTML above
| {% if vitalDetails is not null and option.id == vitalDetails.get_interpretation_option_id() %} | ||
| <option selected="selected" value="{{ option.id|attr }}">{{ option.title|xlt }}</option> | ||
| {% else %} | ||
| <option {% if option.is_default %}selected="selected"{% endif%} value="{{ option.id|attr }}">{{ option.title }}</option> |
|
review completed :) |
* Convert Vitals form from smarty to twig Big overhaul of vitals from changing it from smarty to twig format. Cleaned up a lot of the rendering as well so we can both easily extend the vitals form and handle additional fields. This is prep work to make the form responsive. Added some additional extension to twig so we could handle the wierd date formats for the vital forms. * Fix styles * Fixes #5665 vitals form Prevent the form from being squashed up and move the historical data into its own section further down in the form. Fix some minor twig issues. * Fix css styles * Remove SMARTY controller class Forgot to remove the smarty controller class now that we are no longer using any of the smarty templates.
Fixes #5665
Prevent the form from being squashed up and move the historical data into its own section further down in the form. Fix some minor twig issues.
Big overhaul of vitals from changing it from smarty to twig format. Cleaned up a lot of the rendering as well so we can both easily extend the vitals form and handle additional fields. This is prep work to make
the form responsive.
Added some additional extension to twig so we could handle the weird date formats for the vital forms
below added by bradymiller:
Up For Grabs demo (includes the standard demo data) for this PR is at: https://www.open-emr.org/wiki/index.php/Development_Demo#Epsilon_-_Up_For_Grabs_Demo