Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICD10 import update #5885

Merged
merged 11 commits into from
Nov 6, 2022
Merged

Conversation

stephenwaite
Copy link
Sponsor Member

testing out a different way to import icd10

@stephenwaite stephenwaite marked this pull request as ready for review November 2, 2022 01:01
@stephenwaite
Copy link
Sponsor Member Author

this could be optimized for sure but since it's only run once a year for a site it should be ok for production

@bradymiller
Copy link
Sponsor Member

Is this dropping icd9 support? (if so, then will make sense to complete excise it from code; i can do this after it is in codebase)

@bradymiller
Copy link
Sponsor Member

bradymiller commented Nov 2, 2022

btw, when i say excise, just mean remove it from the import user interface (would leave it in other places to support old medical records).

@stephenwaite stephenwaite changed the title Icd10import csv ICD10 import update Nov 2, 2022
@stephenwaite
Copy link
Sponsor Member Author

testing well

// find active revision
$res = sqlStatementNoLog("SELECT max(revision) rev FROM icd10_pcs_order_code");
$row = sqlFetchArray($res);
$next_rev = $row['rev'] + 1;

This comment was marked as outdated.

Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

guessing will have issues since variables don't match up. Would make the following changes:

$res = sqlQueryNoLog("SELECT max(revision) rev FROM icd10_pcs_order_code");
$next_rev = ($res['rev'] ?? 0) + 1;


$res = sqlStatementNoLog("SELECT max(revision) rev FROM icd10_dx_order_code");
$row = sqlFetchArray($res);
$next_rev = $row['rev'] + 1;

This comment was marked as outdated.

This comment was marked as outdated.

Copy link
Sponsor Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

guessing will have issues since variables don't match up. Would make the following changes:

$res = sqlQueryNoLog("SELECT max(revision) rev FROM icd10_dx_order_code");
$next_rev = ($res['rev'] ?? 0) + 1;

Copy link
Sponsor Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for catching that!

@stephenwaite stephenwaite merged commit 1b1f687 into openemr:master Nov 6, 2022
@stephenwaite stephenwaite deleted the icd10import-csv branch November 6, 2022 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants