-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ICD10 import update #5885
ICD10 import update #5885
Conversation
this could be optimized for sure but since it's only run once a year for a site it should be ok for production |
Is this dropping icd9 support? (if so, then will make sense to complete excise it from code; i can do this after it is in codebase) |
btw, when i say excise, just mean remove it from the import user interface (would leave it in other places to support old medical records). |
testing well |
// find active revision | ||
$res = sqlStatementNoLog("SELECT max(revision) rev FROM icd10_pcs_order_code"); | ||
$row = sqlFetchArray($res); | ||
$next_rev = $row['rev'] + 1; |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
guessing will have issues since variables don't match up. Would make the following changes:
$res = sqlQueryNoLog("SELECT max(revision) rev FROM icd10_pcs_order_code");
$next_rev = ($res['rev'] ?? 0) + 1;
|
||
$res = sqlStatementNoLog("SELECT max(revision) rev FROM icd10_dx_order_code"); | ||
$row = sqlFetchArray($res); | ||
$next_rev = $row['rev'] + 1; |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
guessing will have issues since variables don't match up. Would make the following changes:
$res = sqlQueryNoLog("SELECT max(revision) rev FROM icd10_dx_order_code");
$next_rev = ($res['rev'] ?? 0) + 1;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for catching that!
testing out a different way to import icd10