add mod to past encounter billing view

[stephenwaite]

No description provided.

[bradymiller]

This is very straightforward and will bring this into the codebase. thanks for the contribution! -brady

[robertdown]

Would prefer to follow coding standards on new PRs. Gladly would have done this but it was merged so quickly I didn't even get a chance to see it.

Perhaps we can add a tag "Code Standards Approved" (Along with "Code Standards Exception Approved" for times when we are willing to bring in code w/o it complying with standards)? I'll also look to see if Travis could do this check automatically

[bradymiller]

@robertdown Didn't note that when i brought it in. What code standard did this break?

[robertdown]

http://www.php-fig.org/psr/psr-2/#if-elseif-else

[bradymiller]

Isn't a unnested 1 line ternary ok?

[bradymiller]

oh wait, its not a ternary. just a simple if :)
this would be tough to filter via travis since there are many instances of this structure in the codebase

[bradymiller]

@robertdown , just committed a fix for this:
fa387da

And will start to incorporate code standards into reviews.

thanks, -brady

[MatthewVita]

@robertdown, @bradymiller

I'll also look to see if Travis could do this check automatically

See this conversation I'm having with bobison:

#492 (comment)