Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make component list in Nation Note more user friendly #6755

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

robertdown
Copy link
Member

Make the list of components to insert more manageable by not rendering the body of the component, instead render the short form.

@robertdown robertdown self-assigned this Aug 17, 2023
@robertdown robertdown marked this pull request as draft August 17, 2023 01:34
@robertdown robertdown marked this pull request as ready for review August 31, 2023 21:45
@robertdown
Copy link
Member Author

robertdown commented Aug 31, 2023

This turned out to be bigger than I had thought.

  1. Adding new components or updating components now take place in a dialog
  2. You can now supply a short name to the component, which will render in the list
  3. Insert / Update / Delete is a bit more separated from the UI
  4. Several jQuery ajax calls have been replaced with fetch() calls.
  5. In the event there is only 1 category in the given context, it will automatically load that categories components.
  6. The short name was expanded in the DB to allow longer names
  7. The actual component is now LONGTEXT instead of TEXT in the database
  8. It appears that the short title isn't used in the current structure. Since the UI list is now based on that column, the upgrade script now takes the first 35 characters of the main component text, trims it, appends an ellipsis and uses that as the short title. This prevents disruption to already existing forms

Still Pending

  • SQL to copy current components into the short name and truncate (otherwise the list will break for old components)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant