Fix for opening new tab from picker #7168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The twig custom function function ($subject = 'default', $fieldName = "_token") sig arg $subject will not default to arg value unless null is passed in. Quote counts as populated.
|
Tested well. A simple universal fix so merging. |
|
|
sjpadgett
added a commit
to sjpadgett/openemr
that referenced
this pull request
Feb 21, 2024
The twig custom function function ($subject = 'default', $fieldName = "_token") sig arg $subject will not default to arg value unless null is passed in. Quote counts as populated. (cherry picked from commit 63732ad)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The twig custom function csrfToken($subject = 'default', $fieldName = "_token") sig arg $subject will not default to arg value unless null is passed in. Quote counts as populated.
Fixes #7167
Short description of what this resolves:
Changes proposed in this pull request:
Modify twig function to ensure proper subject from csrf token creation is used in verification.