Cherry pick sjp 702 #7409
Merged
Cherry pick sjp 702 #7409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mr#7391) * fix: check for empty array before looking for offsite document * silence php warning * Changed up event logic,fixed bugs Instead of having the url splitting and parsing in the document class, I pass the file path into the PatientRetrieveOffsiteDocument event and let the module writer be responsible for parsing the url. This ensures that we handle any kind of url variety that is needed. Fixed up the event dispatcher throwing an error because it wasn't even set in the class... Fixed the setter in the event and exposed the URL property. No idea how this was even working in the module. * Bug fix prevent firing events if empty file Made it so that if the filename is empty that the event will not be fired. Changed up the URL so you can get the entire URL schema (which is what I thought was originally happening but apparently it wasn't). This means schemas such as s3:// ftp:// webdav:// etc can be handled by the class properly. Also changed up the event so you can get the entire saved document as an object if additional meta information is needed by the offsite document event handler. --------- Co-authored-by: Stephen Nielson <snielson@discoverandchange.com> (cherry picked from commit a7a58d3)
- this needs a rewrite but maybe later (cherry picked from commit 548db01)
bradymiller
reviewed
Apr 30, 2024
| } | ||
| if ($tasked == 'downloadLog') { | ||
| $wenoLog->insertWenoLog("prescription", "Invalid Prescriber Credentials User Download."); | ||
| echo(js_escape($error)); |
There was a problem hiding this comment.
text()
(same as commit in master)
bradymiller
reviewed
Apr 30, 2024
| exit; | ||
| } | ||
| $wenoLog->insertWenoLog("prescription", "Invalid Prescriber Credentials Hint:see previous errors."); | ||
| echo(js_escape($error)); |
There was a problem hiding this comment.
text()
(same as commit in master)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sherwins and me